Skip to content

Commit dfd003e

Browse files
authored
Do not fetch connectome file list for volume layer without fallback (#8768)
### URL of deployed dev instance (used for testing): - https://noconnectomesforbarevolumelayer.webknossos.xyz ### Steps to test: - Open a volume annotation with no fallback segmentation layer - No error toast saying “DataLayer x not found” should show ### Issues: - fixes https://scm.slack.com/archives/C02H5T8Q08P/p1751993085147359?thread_ts=1751993051.004949&cid=C02H5T8Q08P ------ - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`) - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md)
1 parent c6bed41 commit dfd003e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

frontend/javascripts/viewer/view/right-border-tabs/connectome_tab/connectome_settings.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { connect } from "react-redux";
77
import type { APIConnectomeFile, APIDataset, APISegmentationLayer } from "types/api_types";
88
import { userSettings } from "types/schemas/user_settings.schema";
99
import defaultState from "viewer/default_state";
10+
import { isTracingLayerWithoutFallback } from "viewer/model/accessors/volumetracing_accessor";
1011
import {
1112
updateConnectomeFileListAction,
1213
updateCurrentConnectomeFileAction,
@@ -67,7 +68,12 @@ class ConnectomeFilters extends React.Component<Props> {
6768
pendingConnectomeFileName,
6869
} = this.props;
6970
// If availableConnectomeFiles is not null, they have already been fetched
70-
if (segmentationLayer == null || availableConnectomeFiles != null) return;
71+
if (
72+
segmentationLayer == null ||
73+
isTracingLayerWithoutFallback(segmentationLayer) ||
74+
availableConnectomeFiles != null
75+
)
76+
return;
7177
const connectomeFiles = await getConnectomeFilesForDatasetLayer(
7278
dataset.dataStore.url,
7379
dataset,

unreleased_changes/8768.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Fixed
2+
- Fixed a bug where WEBKNOSSOS would show an error toast for volume annotations that have no fallback segmentation layer.

0 commit comments

Comments
 (0)