Perf improvement for applying MoveTreeComponent update action (#8675)

Measured 133ms when merging two trees of 100k nodes each. On the old
code, I aborted measuring after 3 minutes.

Thanks for noticing this good opportunity @philippotto :)

Author: fm3

webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/tracings/skeleton/updating/SkeletonUpdateActions.scala

@@ -168,15 +168,17 @@ case class MoveTreeComponentSkeletonAction(nodeIds: List[Int],
     extends SkeletonUpdateAction
     with SkeletonUpdateActionHelper {
 
+  private lazy val nodeIdsSet = nodeIds.toSet
+
   // this should only move a whole component,
   // that is disjoint from the rest of the tree
   override def applyOn(tracing: SkeletonTracing): SkeletonTracing = {
     val sourceTree = treeById(tracing, sourceId)
     val targetTree = treeById(tracing, targetId)
 
-    val (movedNodes, remainingNodes) = sourceTree.nodes.partition(nodeIds contains _.id)
+    val (movedNodes, remainingNodes) = sourceTree.nodes.partition(n => nodeIdsSet.contains(n.id))
     val (movedEdges, remainingEdges) =
-      sourceTree.edges.partition(e => nodeIds.contains(e.source) && nodeIds.contains(e.target))
+      sourceTree.edges.partition(e => nodeIdsSet.contains(e.source) && nodeIdsSet.contains(e.target))
     val updatedSource = sourceTree.copy(nodes = remainingNodes, edges = remainingEdges)
     val updatedTarget =
       targetTree.copy(nodes = targetTree.nodes.concat(movedNodes), edges = targetTree.edges.concat(movedEdges))