Skip to content

Commit a20ce9d

Browse files
authored
Fix segment list scrolling (#8709)
### URL of deployed dev instance (used for testing): - https://___.webknossos.xyz ### Steps to test: - create many segments and/or trees so that you have to scroll - the last item should be visible when scrolling to the bottom ### Issues: - fixes https://scm.slack.com/archives/C5AKLAV0B/p1750250013279109 ------ (Please delete unneeded items, merge only when none are left open) - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`)
1 parent 0863410 commit a20ce9d

File tree

3 files changed

+37
-131
lines changed

3 files changed

+37
-131
lines changed

frontend/javascripts/viewer/view/right-border-tabs/segments_tab/segments_view.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1858,7 +1858,7 @@ class SegmentsView extends React.Component<Props, State> {
18581858
).map((node) => node.key);
18591859
return (
18601860
<React.Fragment>
1861-
<div style={{ flex: 0 }}>
1861+
<div style={{ flex: 0, display: "flex" }}>
18621862
<AdvancedSearchPopover
18631863
onSelect={this.handleSearchSelect}
18641864
data={this.state.searchableTreeItemList}
@@ -1929,7 +1929,6 @@ class SegmentsView extends React.Component<Props, State> {
19291929
switcherIcon={<DownOutlined />}
19301930
titleRender={this.titleRender}
19311931
style={{
1932-
marginTop: 12,
19331932
marginLeft: -14, // hide switcherIcon for root group
19341933
flex: "1 1 auto",
19351934
overflow: "auto", // use hidden when not using virtualization

unreleased_changes/8709.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Fixed
2+
- Fixed that one could not scroll to the last item in the segments and trees tab.

yarn.lock

Lines changed: 34 additions & 129 deletions
Original file line numberDiff line numberDiff line change
@@ -71,25 +71,7 @@ __metadata:
7171
languageName: node
7272
linkType: hard
7373

74-
"@ant-design/cssinjs@npm:^1.21.0":
75-
version: 1.22.0
76-
resolution: "@ant-design/cssinjs@npm:1.22.0"
77-
dependencies:
78-
"@babel/runtime": "npm:^7.11.1"
79-
"@emotion/hash": "npm:^0.8.0"
80-
"@emotion/unitless": "npm:^0.7.5"
81-
classnames: "npm:^2.3.1"
82-
csstype: "npm:^3.1.3"
83-
rc-util: "npm:^5.35.0"
84-
stylis: "npm:^4.3.4"
85-
peerDependencies:
86-
react: ">=16.0.0"
87-
react-dom: ">=16.0.0"
88-
checksum: 10c0/f06aa27efba605caffb2e0684479ee5b7b5a6ed558aab52825e889c208e4fc1f1b669abbbc4aa483ce12155ae9d09e7c4abedeff8ef0bd0697900d9821dcd7bf
89-
languageName: node
90-
linkType: hard
91-
92-
"@ant-design/cssinjs@npm:^1.21.1":
74+
"@ant-design/cssinjs@npm:^1.21.0, @ant-design/cssinjs@npm:^1.21.1":
9375
version: 1.23.0
9476
resolution: "@ant-design/cssinjs@npm:1.23.0"
9577
dependencies:
@@ -378,7 +360,7 @@ __metadata:
378360
languageName: node
379361
linkType: hard
380362

381-
"@babel/runtime@npm:^7.1.2, @babel/runtime@npm:^7.10.1, @babel/runtime@npm:^7.10.4, @babel/runtime@npm:^7.11.1, @babel/runtime@npm:^7.11.2, @babel/runtime@npm:^7.12.1, @babel/runtime@npm:^7.12.13, @babel/runtime@npm:^7.12.5, @babel/runtime@npm:^7.16.7, @babel/runtime@npm:^7.18.0, @babel/runtime@npm:^7.18.3, @babel/runtime@npm:^7.18.9, @babel/runtime@npm:^7.20.0, @babel/runtime@npm:^7.20.7, @babel/runtime@npm:^7.21.0, @babel/runtime@npm:^7.22.5, @babel/runtime@npm:^7.23.2, @babel/runtime@npm:^7.23.6, @babel/runtime@npm:^7.23.9, @babel/runtime@npm:^7.24.4, @babel/runtime@npm:^7.24.8, @babel/runtime@npm:^7.6.3, @babel/runtime@npm:^7.7.2, @babel/runtime@npm:^7.9.2":
363+
"@babel/runtime@npm:^7.1.2, @babel/runtime@npm:^7.12.1, @babel/runtime@npm:^7.12.13, @babel/runtime@npm:^7.12.5, @babel/runtime@npm:^7.18.3, @babel/runtime@npm:^7.18.9, @babel/runtime@npm:^7.24.8, @babel/runtime@npm:^7.6.3, @babel/runtime@npm:^7.7.2, @babel/runtime@npm:^7.9.2":
382364
version: 7.25.6
383365
resolution: "@babel/runtime@npm:7.25.6"
384366
dependencies:
@@ -387,16 +369,7 @@ __metadata:
387369
languageName: node
388370
linkType: hard
389371

390-
"@babel/runtime@npm:^7.24.7":
391-
version: 7.26.0
392-
resolution: "@babel/runtime@npm:7.26.0"
393-
dependencies:
394-
regenerator-runtime: "npm:^0.14.0"
395-
checksum: 10c0/12c01357e0345f89f4f7e8c0e81921f2a3e3e101f06e8eaa18a382b517376520cd2fa8c237726eb094dab25532855df28a7baaf1c26342b52782f6936b07c287
396-
languageName: node
397-
linkType: hard
398-
399-
"@babel/runtime@npm:^7.25.7":
372+
"@babel/runtime@npm:^7.10.1, @babel/runtime@npm:^7.10.4, @babel/runtime@npm:^7.11.1, @babel/runtime@npm:^7.11.2, @babel/runtime@npm:^7.16.7, @babel/runtime@npm:^7.18.0, @babel/runtime@npm:^7.20.0, @babel/runtime@npm:^7.20.7, @babel/runtime@npm:^7.21.0, @babel/runtime@npm:^7.22.5, @babel/runtime@npm:^7.23.2, @babel/runtime@npm:^7.23.6, @babel/runtime@npm:^7.23.9, @babel/runtime@npm:^7.24.4, @babel/runtime@npm:^7.24.7, @babel/runtime@npm:^7.25.7":
400373
version: 7.27.6
401374
resolution: "@babel/runtime@npm:7.27.6"
402375
checksum: 10c0/89726be83f356f511dcdb74d3ea4d873a5f0cf0017d4530cb53aa27380c01ca102d573eff8b8b77815e624b1f8c24e7f0311834ad4fb632c90a770fda00bd4c8
@@ -2069,26 +2042,9 @@ __metadata:
20692042
languageName: node
20702043
linkType: hard
20712044

2072-
"@rc-component/trigger@npm:^2.0.0, @rc-component/trigger@npm:^2.1.1":
2073-
version: 2.2.0
2074-
resolution: "@rc-component/trigger@npm:2.2.0"
2075-
dependencies:
2076-
"@babel/runtime": "npm:^7.23.2"
2077-
"@rc-component/portal": "npm:^1.1.0"
2078-
classnames: "npm:^2.3.2"
2079-
rc-motion: "npm:^2.0.0"
2080-
rc-resize-observer: "npm:^1.3.1"
2081-
rc-util: "npm:^5.38.0"
2082-
peerDependencies:
2083-
react: ">=16.9.0"
2084-
react-dom: ">=16.9.0"
2085-
checksum: 10c0/71881fceaa645ae906d765901c23b7c80d96bc6305e943ddc18f2226eb5524d3b61b7d46eae3ab9c6a0519376b7ee5c312df82eb1143942941ba2a56a675ccf6
2086-
languageName: node
2087-
linkType: hard
2088-
2089-
"@rc-component/trigger@npm:^2.2.6":
2090-
version: 2.2.6
2091-
resolution: "@rc-component/trigger@npm:2.2.6"
2045+
"@rc-component/trigger@npm:^2.0.0, @rc-component/trigger@npm:^2.1.1, @rc-component/trigger@npm:^2.2.6":
2046+
version: 2.2.7
2047+
resolution: "@rc-component/trigger@npm:2.2.7"
20922048
dependencies:
20932049
"@babel/runtime": "npm:^7.23.2"
20942050
"@rc-component/portal": "npm:^1.1.0"
@@ -2099,7 +2055,7 @@ __metadata:
20992055
peerDependencies:
21002056
react: ">=16.9.0"
21012057
react-dom: ">=16.9.0"
2102-
checksum: 10c0/e7ef14099fac74a58301ccf65a003ddaefb6f2a410c950c8354e0d63fd13e21e3a1f32dd4e73a11c7c0c6199e66629f7f3e31c09d887198b974d35805c4de8e1
2058+
checksum: 10c0/51e1b0d42503080dad2b3d6a27ddaf49c66b19638eeeb828f183270050cf39c3b50f466b774e2f7d15f07f4856a38aea4311eebe2ed9b93deebad80ff5cfe9ef
21032059
languageName: node
21042060
linkType: hard
21052061

@@ -5024,9 +4980,9 @@ __metadata:
50244980
linkType: hard
50254981

50264982
"compute-scroll-into-view@npm:^3.0.2":
5027-
version: 3.1.0
5028-
resolution: "compute-scroll-into-view@npm:3.1.0"
5029-
checksum: 10c0/bf305c4ece8e5c59ed3f7ed82b6dab5b7487ce26f56a693d903869964712870fccb08fe31d40edcbd600b03c99198f54d443acb315d674bd64fd344410c8672e
4983+
version: 3.1.1
4984+
resolution: "compute-scroll-into-view@npm:3.1.1"
4985+
checksum: 10c0/59761ed62304a9599b52ad75d0d6fbf0669ee2ab7dd472fdb0ad9da36628414c014dea7b5810046560180ad30ffec52a953d19297f66a1d4f3aa0999b9d2521d
50304986
languageName: node
50314987
linkType: hard
50324988

@@ -11326,22 +11282,7 @@ __metadata:
1132611282
languageName: node
1132711283
linkType: hard
1132811284

11329-
"rc-dropdown@npm:~4.2.0":
11330-
version: 4.2.0
11331-
resolution: "rc-dropdown@npm:4.2.0"
11332-
dependencies:
11333-
"@babel/runtime": "npm:^7.18.3"
11334-
"@rc-component/trigger": "npm:^2.0.0"
11335-
classnames: "npm:^2.2.6"
11336-
rc-util: "npm:^5.17.0"
11337-
peerDependencies:
11338-
react: ">=16.11.0"
11339-
react-dom: ">=16.11.0"
11340-
checksum: 10c0/e808172c922f4c3f8bf4fb4641834e34929df9e0af00981e5554d72852d2df016a85c5339119a61f740ea70da7e33c89ed95c11ee8b9c5538533072675287a3a
11341-
languageName: node
11342-
linkType: hard
11343-
11344-
"rc-dropdown@npm:~4.2.1":
11285+
"rc-dropdown@npm:~4.2.0, rc-dropdown@npm:~4.2.1":
1134511286
version: 4.2.1
1134611287
resolution: "rc-dropdown@npm:4.2.1"
1134711288
dependencies:
@@ -11452,21 +11393,7 @@ __metadata:
1145211393
languageName: node
1145311394
linkType: hard
1145411395

11455-
"rc-motion@npm:^2.0.0, rc-motion@npm:^2.0.1, rc-motion@npm:^2.3.0, rc-motion@npm:^2.3.4, rc-motion@npm:^2.4.3, rc-motion@npm:^2.4.4, rc-motion@npm:^2.6.1, rc-motion@npm:^2.6.2, rc-motion@npm:^2.9.0":
11456-
version: 2.9.2
11457-
resolution: "rc-motion@npm:2.9.2"
11458-
dependencies:
11459-
"@babel/runtime": "npm:^7.11.1"
11460-
classnames: "npm:^2.2.1"
11461-
rc-util: "npm:^5.43.0"
11462-
peerDependencies:
11463-
react: ">=16.9.0"
11464-
react-dom: ">=16.9.0"
11465-
checksum: 10c0/e5e4f8fe83238c414fb0fc738b4d71faef0c951b5858bfd90bb3f3ff1dde1577262c258fcdae4e5a53a78f5056e2868ff85335ded92758cc886e610308709d8d
11466-
languageName: node
11467-
linkType: hard
11468-
11469-
"rc-motion@npm:^2.9.5":
11396+
"rc-motion@npm:^2.0.0, rc-motion@npm:^2.0.1, rc-motion@npm:^2.3.0, rc-motion@npm:^2.3.4, rc-motion@npm:^2.4.3, rc-motion@npm:^2.4.4, rc-motion@npm:^2.6.1, rc-motion@npm:^2.6.2, rc-motion@npm:^2.9.0, rc-motion@npm:^2.9.5":
1147011397
version: 2.9.5
1147111398
resolution: "rc-motion@npm:2.9.5"
1147211399
dependencies:
@@ -11496,8 +11423,8 @@ __metadata:
1149611423
linkType: hard
1149711424

1149811425
"rc-overflow@npm:^1.3.1, rc-overflow@npm:^1.3.2":
11499-
version: 1.3.2
11500-
resolution: "rc-overflow@npm:1.3.2"
11426+
version: 1.4.1
11427+
resolution: "rc-overflow@npm:1.4.1"
1150111428
dependencies:
1150211429
"@babel/runtime": "npm:^7.11.1"
1150311430
classnames: "npm:^2.2.1"
@@ -11506,7 +11433,7 @@ __metadata:
1150611433
peerDependencies:
1150711434
react: ">=16.9.0"
1150811435
react-dom: ">=16.9.0"
11509-
checksum: 10c0/1c3741760e21fdc5829ebc1affb2a54fd04bda3abc1c88542b6191845d3490ca255fc423f897f448af1c79311c7eda499ea977ca79bce55ebdaf75397573d125
11436+
checksum: 10c0/ac47d2c7b4cfc99e8ca20c75f99e601eac4d524f6690d9a36fb65d84b9f627f13aa70f11fc5c09b24c1e9a0395a15c16998a57f2517c08a6abe545539cb5e162
1151011437
languageName: node
1151111438
linkType: hard
1151211439

@@ -11569,35 +11496,20 @@ __metadata:
1156911496
linkType: hard
1157011497

1157111498
"rc-rate@npm:~2.13.0":
11572-
version: 2.13.0
11573-
resolution: "rc-rate@npm:2.13.0"
11499+
version: 2.13.1
11500+
resolution: "rc-rate@npm:2.13.1"
1157411501
dependencies:
1157511502
"@babel/runtime": "npm:^7.10.1"
1157611503
classnames: "npm:^2.2.5"
1157711504
rc-util: "npm:^5.0.1"
1157811505
peerDependencies:
1157911506
react: ">=16.9.0"
1158011507
react-dom: ">=16.9.0"
11581-
checksum: 10c0/3e2c15ee41d20837e820b6a1b83bf83e74ecb36c1da05c9e32c22d864586e7a826c961ba8159468ac9c9ac2fcb03b91a812070a5eb8119e77c2248ef95d6febd
11508+
checksum: 10c0/b26d4741fffb06e1beebe1aba135ba6ab4ee898faf1f876ce802ed5ddcdc8dabe7a4662be63e60226713fad9b3dd8d4034ed9b8b3e27ba5ef9673d7e8f47d497
1158211509
languageName: node
1158311510
linkType: hard
1158411511

11585-
"rc-resize-observer@npm:^1.0.0, rc-resize-observer@npm:^1.1.0, rc-resize-observer@npm:^1.3.1, rc-resize-observer@npm:^1.4.0":
11586-
version: 1.4.0
11587-
resolution: "rc-resize-observer@npm:1.4.0"
11588-
dependencies:
11589-
"@babel/runtime": "npm:^7.20.7"
11590-
classnames: "npm:^2.2.1"
11591-
rc-util: "npm:^5.38.0"
11592-
resize-observer-polyfill: "npm:^1.5.1"
11593-
peerDependencies:
11594-
react: ">=16.9.0"
11595-
react-dom: ">=16.9.0"
11596-
checksum: 10c0/50e03fa524e156477e5e083bc11e92b8d2c442b6a9a0caa111d9b9991174f9ac98175d50fba1721e55338472d5344610e30fce8531a65785b3d79c191173d351
11597-
languageName: node
11598-
linkType: hard
11599-
11600-
"rc-resize-observer@npm:^1.4.3":
11512+
"rc-resize-observer@npm:^1.0.0, rc-resize-observer@npm:^1.1.0, rc-resize-observer@npm:^1.3.1, rc-resize-observer@npm:^1.4.0, rc-resize-observer@npm:^1.4.3":
1160111513
version: 1.4.3
1160211514
resolution: "rc-resize-observer@npm:1.4.3"
1160311515
dependencies:
@@ -11798,35 +11710,35 @@ __metadata:
1179811710
languageName: node
1179911711
linkType: hard
1180011712

11801-
"rc-util@npm:^5.0.1, rc-util@npm:^5.16.1, rc-util@npm:^5.17.0, rc-util@npm:^5.18.1, rc-util@npm:^5.2.0, rc-util@npm:^5.20.1, rc-util@npm:^5.21.0, rc-util@npm:^5.24.4, rc-util@npm:^5.25.2, rc-util@npm:^5.27.0, rc-util@npm:^5.30.0, rc-util@npm:^5.31.1, rc-util@npm:^5.32.2, rc-util@npm:^5.34.1, rc-util@npm:^5.35.0, rc-util@npm:^5.36.0, rc-util@npm:^5.37.0, rc-util@npm:^5.38.0, rc-util@npm:^5.38.1, rc-util@npm:^5.40.1, rc-util@npm:^5.43.0":
11802-
version: 5.43.0
11803-
resolution: "rc-util@npm:5.43.0"
11713+
"rc-util@npm:^5.0.1, rc-util@npm:^5.16.1, rc-util@npm:^5.17.0, rc-util@npm:^5.18.1, rc-util@npm:^5.2.0, rc-util@npm:^5.20.1, rc-util@npm:^5.21.0, rc-util@npm:^5.24.4, rc-util@npm:^5.25.2, rc-util@npm:^5.27.0, rc-util@npm:^5.30.0, rc-util@npm:^5.32.2, rc-util@npm:^5.34.1, rc-util@npm:^5.35.0, rc-util@npm:^5.36.0, rc-util@npm:^5.37.0, rc-util@npm:^5.38.0, rc-util@npm:^5.38.1, rc-util@npm:^5.40.1, rc-util@npm:^5.41.0, rc-util@npm:^5.43.0, rc-util@npm:^5.44.0, rc-util@npm:^5.44.1, rc-util@npm:^5.44.3":
11714+
version: 5.44.4
11715+
resolution: "rc-util@npm:5.44.4"
1180411716
dependencies:
1180511717
"@babel/runtime": "npm:^7.18.3"
1180611718
react-is: "npm:^18.2.0"
1180711719
peerDependencies:
1180811720
react: ">=16.9.0"
1180911721
react-dom: ">=16.9.0"
11810-
checksum: 10c0/39f7904c9851f2b0a2dace5ac578f42000498412d7da5ef2063fd547db91d158dcb376bcbacf49fb7790d2721727bd38ea3483294ef51eb6099a793b2e17e9db
11722+
checksum: 10c0/748b71a6280ddaaac93d1fb2c92f03818775468e7ccb6c221484687cc0b7e879d083e98e338f75ac0fe2e942dbb9c2405bd32d25e5a804bf1fb7a11f3f897127
1181111723
languageName: node
1181211724
linkType: hard
1181311725

11814-
"rc-util@npm:^5.41.0, rc-util@npm:^5.44.0, rc-util@npm:^5.44.1, rc-util@npm:^5.44.3":
11815-
version: 5.44.4
11816-
resolution: "rc-util@npm:5.44.4"
11726+
"rc-util@npm:^5.31.1":
11727+
version: 5.43.0
11728+
resolution: "rc-util@npm:5.43.0"
1181711729
dependencies:
1181811730
"@babel/runtime": "npm:^7.18.3"
1181911731
react-is: "npm:^18.2.0"
1182011732
peerDependencies:
1182111733
react: ">=16.9.0"
1182211734
react-dom: ">=16.9.0"
11823-
checksum: 10c0/748b71a6280ddaaac93d1fb2c92f03818775468e7ccb6c221484687cc0b7e879d083e98e338f75ac0fe2e942dbb9c2405bd32d25e5a804bf1fb7a11f3f897127
11735+
checksum: 10c0/39f7904c9851f2b0a2dace5ac578f42000498412d7da5ef2063fd547db91d158dcb376bcbacf49fb7790d2721727bd38ea3483294ef51eb6099a793b2e17e9db
1182411736
languageName: node
1182511737
linkType: hard
1182611738

1182711739
"rc-virtual-list@npm:^3.14.2, rc-virtual-list@npm:^3.5.1, rc-virtual-list@npm:^3.5.2":
11828-
version: 3.14.5
11829-
resolution: "rc-virtual-list@npm:3.14.5"
11740+
version: 3.19.1
11741+
resolution: "rc-virtual-list@npm:3.19.1"
1183011742
dependencies:
1183111743
"@babel/runtime": "npm:^7.20.0"
1183211744
classnames: "npm:^2.2.6"
@@ -11835,7 +11747,7 @@ __metadata:
1183511747
peerDependencies:
1183611748
react: ">=16.9.0"
1183711749
react-dom: ">=16.9.0"
11838-
checksum: 10c0/4e292756d3f48c3d92fa571f52d984bc048cc7f599c8cbb7dad9d7dc34bef83e0ee14963fe86c4662c6072ffade2838dd5a2dbc1e7d8584db4fef5f202fcc3bb
11750+
checksum: 10c0/207d1682aff92d9f40efe6467638bbe22f9f5ad3d7570231b6a5a59cee416d28e134276c43aa71e517fe77f296720a4edcb4ee01a8623591368026942816d03f
1183911751
languageName: node
1184011752
linkType: hard
1184111753

@@ -13613,9 +13525,9 @@ __metadata:
1361313525
linkType: hard
1361413526

1361513527
"stylis@npm:^4.3.4":
13616-
version: 4.3.4
13617-
resolution: "stylis@npm:4.3.4"
13618-
checksum: 10c0/4899c2674cd2538e314257abd1ba7ea3c2176439659ddac6593c78192cfd4a06f814a0a4fc69bc7f8fcc6b997e13d383dd9b578b71074746a0fb86045a83e42d
13528+
version: 4.3.6
13529+
resolution: "stylis@npm:4.3.6"
13530+
checksum: 10c0/e736d484983a34f7c65d362c67dc79b7bce388054b261c2b7b23d02eaaf280617033f65d44b1ea341854f4331a5074b885668ac8741f98c13a6cfd6443ae85d0
1361913531
languageName: node
1362013532
linkType: hard
1362113533

@@ -13808,14 +13720,7 @@ __metadata:
1380813720
languageName: node
1380913721
linkType: hard
1381013722

13811-
"throttle-debounce@npm:^5.0.0":
13812-
version: 5.0.0
13813-
resolution: "throttle-debounce@npm:5.0.0"
13814-
checksum: 10c0/666d5b73bfa7340c5186b244416ce965cd276e4bc91a12453ff6eddcc62f02a19c6f532305601d90c809dd5acbd45dd6eea5eb43e0a879a0b3d66d0886a4d8d2
13815-
languageName: node
13816-
linkType: hard
13817-
13818-
"throttle-debounce@npm:^5.0.2":
13723+
"throttle-debounce@npm:^5.0.0, throttle-debounce@npm:^5.0.2":
1381913724
version: 5.0.2
1382013725
resolution: "throttle-debounce@npm:5.0.2"
1382113726
checksum: 10c0/9a10ac51400b353562770721718486847adb5d7287c94a0c0d47df5326e8d47e5d92fcb74dac53d6734efb9344a2d46d68c7f996c2d0aedfd11446522e4bb356

0 commit comments

Comments
 (0)