Skip to content

Commit 56e8306

Browse files
authored
fix contrast in credits footer (#8718)
- Fix the contrast between background color and text in the credits footer. - Also adjust the height of two onboarding cards while at it. ### Before <img width="1630" alt="Screenshot 2025-06-25 at 12 02 29" src="https://github.com/user-attachments/assets/73c9014c-f655-4965-9df1-648063832216" /> <img width="1086" alt="Screenshot 2025-06-25 at 11 48 50" src="https://github.com/user-attachments/assets/8db76398-d54f-46f9-a5d6-dac492081d35" /> ### After <img width="1548" alt="Screenshot 2025-06-25 at 13 06 14" src="https://github.com/user-attachments/assets/3726a681-74d2-4469-87da-feb0c68a1d0f" /> ### URL of deployed dev instance (used for testing): - https://___.webknossos.xyz ### Steps to test: 1. Go to orga settings 2. Delete your orga 3. You will be redirected to set up a new orga 4. Inspect the footer 5. Setup a new orga in the onboarding view. The last page should have two cards of identical height ------ (Please delete unneeded items, merge only when none are left open) - [ ] Updated [changelog](../blob/master/CHANGELOG.unreleased.md#unreleased) - [ ] Updated [migration guide](../blob/master/MIGRATIONS.unreleased.md#unreleased) if applicable - [ ] Updated [documentation](../blob/master/docs) if applicable - [ ] Adapted [wk-libs python client](https://github.com/scalableminds/webknossos-libs/tree/master/webknossos/webknossos/client) if relevant API parts change - [ ] Removed dev-only changes like prints and application.conf edits - [ ] Considered [common edge cases](../blob/master/.github/common_edge_cases.md) - [ ] Needs datastore update after deployment
1 parent 026cde4 commit 56e8306

File tree

3 files changed

+12
-17
lines changed

3 files changed

+12
-17
lines changed

frontend/javascripts/admin/onboarding.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ class OnboardingView extends React.PureComponent<Props, State> {
561561
header="Skip"
562562
icon={<ClockCircleOutlined />}
563563
action={<LinkButton onClick={this.advanceStep}>Skip this step</LinkButton>}
564-
height={170}
564+
height={250}
565565
>
566566
You can always do this later!
567567
</OptionCard>

frontend/javascripts/components/credits_footer.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
import { Layout } from "antd";
1+
import { ConfigProvider, Layout } from "antd";
22
import { Link } from "react-router-dom";
3+
import { getAntdTheme } from "theme";
34
const { Footer } = Layout;
45

56
const creditsFooter = () => (
6-
<Footer id="credits">
7-
<div>
8-
<div className="container">
7+
<ConfigProvider theme={getAntdTheme("dark")}>
8+
<Footer id="credits">
9+
<div style={{ maxWidth: 600 }}>
910
<h3>WEBKNOSSOS Credits</h3>
1011
<p>
1112
Developed by <a href="https://scalableminds.com">scalable minds</a> and{" "}
@@ -64,8 +65,8 @@ const creditsFooter = () => (
6465
</a>
6566
</p>
6667
</div>
67-
</div>
68-
</Footer>
68+
</Footer>
69+
</ConfigProvider>
6970
);
7071

7172
export default creditsFooter;

frontend/stylesheets/main.less

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -120,16 +120,10 @@ body {
120120
}
121121

122122
#credits {
123-
background-color: var(--ant-layout-footer-bg);
124-
125-
&>div {
126-
max-width: 600px;
127-
128-
img {
129-
margin-right: 10px;
130-
width: 25%;
131-
max-width: 100px;
132-
}
123+
img {
124+
margin-right: 10px;
125+
width: 25%;
126+
max-width: 100px;
133127
}
134128
}
135129

0 commit comments

Comments
 (0)