Skip to content

Commit 41d8490

Browse files
authored
Fix viewing compound volume annotations (#8668)
Compiler didn’t catch that we passed the bool to the wrong argument. ### Steps to test (I tested): - Create volume task type - Create task with this task type - In dashboard, get this task, annotate some, finish - In task list view, click view on this task - Should work (CompoundTask in URI) ### Issues: - fixes https://scm.slack.com/archives/C02H5T8Q08P/p1748888339790129 ------ - [x] Updated [changelog](../blob/master/CHANGELOG.unreleased.md#unreleased) - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md)
1 parent 0bca4a3 commit 41d8490

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

CHANGELOG.unreleased.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
1818
- Improved efficiency of saving bounding box related changes. [#8492](https://github.com/scalableminds/webknossos/pull/8492)
1919
- Fixed regression which caused the import of trees (also of agglomerate skeletons) to crash if the annotation was not empty. [#8656](https://github.com/scalableminds/webknossos/pull/8656)
2020
- When deleting a dataset, its caches are cleared, so that if a new dataset by the same name is uploaded afterwards, only new data is loaded. [#8638](https://github.com/scalableminds/webknossos/pull/8638)
21+
- Fixed viewing the results of volume anotation tasks in compound view. [#8668](https://github.com/scalableminds/webknossos/pull/8668)
2122

2223
### Removed
2324

webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/controllers/TSAnnotationController.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class TSAnnotationController @Inject()(
186186
volumeTracings,
187187
newVolumeId,
188188
newVersion = newTargetVersion,
189-
toTemporaryStore)
189+
toTemporaryStore) ?~> "mergeVolumeData.failed"
190190
mergedVolumeOpt <- Fox.runIf(volumeTracings.nonEmpty)(
191191
volumeTracingService
192192
.merge(volumeTracings, mergedVolumeStats, newMappingName, newVersion = newTargetVersion)

webknossos-tracingstore/app/com/scalableminds/webknossos/tracingstore/tracings/volume/VolumeTracingService.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,8 @@ class VolumeTracingService @Inject()(
848848
mergedAdditionalAxes,
849849
temporaryTracingService,
850850
tc,
851-
toTemporaryStore
851+
isReadOnly = false,
852+
toTemporaryStore = toTemporaryStore
852853
)
853854
volumeBucketPutBuffer = new FossilDBPutBuffer(volumeDataStore, Some(newVersion))
854855
_ <- mergedVolume.withMergedBuckets { (bucketPosition, bucketBytes) =>

0 commit comments

Comments
 (0)