Skip to content

Commit 09d50ea

Browse files
committed
apply feedback
1 parent 77e602a commit 09d50ea

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

frontend/javascripts/admin/auth/account_settings_view.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ import ProfileView from "./profile_view";
88

99
const { Sider, Content } = Layout;
1010

11+
const BREADCRUMB_LABELS = {
12+
token: "Auth Token",
13+
password: "Password",
14+
profile: "Profile",
15+
};
16+
1117
function AccountSettingsView() {
1218
const location = useLocation();
1319
const history = useHistory();
@@ -43,8 +49,6 @@ function AccountSettingsView() {
4349
},
4450
];
4551

46-
const subPageBreadcrumb = selectedKey.charAt(0).toUpperCase() + selectedKey.slice(1);
47-
4852
return (
4953
<Layout style={{ minHeight: "calc(100vh - 64px)" }} className="container">
5054
<Sider width={200}>
@@ -59,7 +63,9 @@ function AccountSettingsView() {
5963
<Content style={{ padding: "24px", paddingTop: 0, minHeight: 280, maxWidth: 1000 }}>
6064
<Breadcrumb style={{ marginBottom: "16px", padding: "8px 0" }}>
6165
<Breadcrumb.Item>Account Settings</Breadcrumb.Item>
62-
<Breadcrumb.Item>{subPageBreadcrumb}</Breadcrumb.Item>
66+
<Breadcrumb.Item>
67+
{BREADCRUMB_LABELS[selectedKey as keyof typeof BREADCRUMB_LABELS]}
68+
</Breadcrumb.Item>
6369
</Breadcrumb>
6470
<Switch>
6571
<Route path="/account/profile" component={ProfileView} />

frontend/javascripts/admin/auth/change_password_view.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ function ChangePasswordView({ history }: Props) {
148148
) : (
149149
<>
150150
<Space.Compact>
151-
<Input.Password visibilityToggle={false} readOnly value="******************" />
151+
<Input.Password visibilityToggle={false} disabled value="******************" />
152152
<Button type="primary" onClick={handleResetPassword}>
153153
Reset Password
154154
</Button>

0 commit comments

Comments
 (0)