Update ReTyper to Ycheck patterns

Author: OlivierBlanvillain

compiler/src/dotty/tools/dotc/transform/TreeChecker.scala

@@ -261,9 +261,6 @@ class TreeChecker extends Phase with SymTransformer {
 
     override def typedUnadapted(tree: untpd.Tree, pt: Type)(implicit ctx: Context): tpd.Tree = {
       val res = tree match {
-        case _: untpd.UnApply =>
-          // can't recheck patterns
-          tree.asInstanceOf[tpd.Tree]
         case _: untpd.TypedSplice | _: untpd.Thicket | _: EmptyValDef[_] =>
           super.typedUnadapted(tree)
         case _ if tree.isType =>

compiler/src/dotty/tools/dotc/typer/ReTyper.scala

@@ -5,6 +5,7 @@ import core._
 import Contexts._
 import Types._
 import Symbols._
+import StdNames._
 import Decorators._
 import typer.ProtoTypes._
 import ast.{tpd, untpd}
@@ -24,18 +25,20 @@ import config.Printers.typr
 class ReTyper extends Typer {
   import tpd._
 
+  private def assertTyped(tree: untpd.Tree)(implicit ctx: Context): Unit =
+    assert(tree.hasType, i"$tree ${tree.getClass} ${tree.uniqueId}")
+
   /** Checks that the given tree has been typed */
   protected def promote(tree: untpd.Tree)(implicit ctx: Context): tree.ThisTree[Type] = {
-    assert(tree.hasType, i"$tree ${tree.getClass} ${tree.uniqueId}")
+    assertTyped(tree)
     tree.withType(tree.typeOpt)
   }
 
   override def typedIdent(tree: untpd.Ident, pt: Type)(implicit ctx: Context): Tree =
     promote(tree)
 
   override def typedSelect(tree: untpd.Select, pt: Type)(implicit ctx: Context): Tree = {
-    assert(tree.hasType, tree)
-    // a qualifier cannot be a pattern
+    assertTyped(tree)
     val qual1 = typed(tree.qualifier, AnySelectionProto)(ctx.retractMode(Mode.Pattern))
     untpd.cpy.Select(tree)(qual1, tree.name).withType(tree.typeOpt)
   }
@@ -49,11 +52,22 @@ class ReTyper extends Typer {
   override def typedSuper(tree: untpd.Super, pt: Type)(implicit ctx: Context): Tree =
     promote(tree)
 
+  override def typedTyped(tree: untpd.Typed, pt: Type)(implicit ctx: Context): Tree = {
+    assertTyped(tree)
+    val type1 = checkSimpleKinded(typedType(tree.tpt))
+    val tree1 = tree.expr match {
+      case id: untpd.Ident if (ctx.mode is Mode.Pattern) && untpd.isVarPattern(id) && (id.name == nme.WILDCARD || id.name == nme.WILDCARD_STAR) =>
+        tree.expr.withType(type1.tpe)
+      case _ => typed(tree.expr)
+    }
+   untpd.cpy.Typed(tree)(tree1, type1).withType(tree.typeOpt)
+  }
+
   override def typedTypeTree(tree: untpd.TypeTree, pt: Type)(implicit ctx: Context): TypeTree =
     promote(tree)
 
   override def typedBind(tree: untpd.Bind, pt: Type)(implicit ctx: Context): Bind = {
-    assert(tree.hasType)
+    assertTyped(tree)
     val body1 = typed(tree.body, pt)
     untpd.cpy.Bind(tree)(tree.name, body1).withType(tree.typeOpt)
   }
@@ -65,6 +79,10 @@ class ReTyper extends Typer {
     untpd.cpy.UnApply(tree)(fun1, implicits1, patterns1).withType(tree.tpe)
   }
 
+  override def typedUnApply(tree: untpd.Apply, selType: Type)(implicit ctx: Context): Tree = {
+    typedApply(tree, selType)
+  }
+
   override def localDummy(cls: ClassSymbol, impl: untpd.Template)(implicit ctx: Context) = impl.symbol
 
   override def retrieveSym(tree: untpd.Tree)(implicit ctx: Context): Symbol = tree.symbol

compiler/src/dotty/tools/dotc/typer/TypeAssigner.scala

@@ -265,7 +265,6 @@ trait TypeAssigner {
    *   - typed child trees it needs to access to cpmpute that type,
    *   - any further information it needs to access to compute that type.
    */
-
   def assignType(tree: untpd.Ident, tp: Type)(implicit ctx: Context) =
     tree.withType(tp)