Skip to content

Commit a9f3433

Browse files
authored
Fix Version Check
1 parent b03938b commit a9f3433

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

web/includes/sb-callback.php

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2319,31 +2319,32 @@ function CheckVersion()
23192319
$objResponse = new xajaxResponse();
23202320
$version = json_decode(file_get_contents("https://sbpp.github.io/version.json"), true);
23212321

2322-
if(version_compare($relver, SB_VERSION) > 0)
2323-
$versmsg = "<span style='color:#aa0000;'><strong>A new release is available.</strong></span>";
2324-
else
2325-
$versmsg = "<span style='color:#00aa00;'><strong>You have the latest release.</strong></span>";
2326-
2327-
$msg = $versmsg;
2328-
if(strlen($version['version'])>8 || $version['version']=="") {
2329-
$version['version'] = "<span style='color:#aa0000;'>Error</span>";
2330-
$msg = "<span style='color:#aa0000;'><strong>Error retrieving latest release.</strong></span>";
2322+
if(version_compare($version['version'], SB_VERSION) > 0) {
2323+
$msg = "<span style='color:#aa0000;'><strong>A New Release is Available.</strong></span>";
2324+
} else {
2325+
$msg = "<span style='color:#00aa00;'><strong>You have the Latest Release.</strong></span>";
23312326
}
2327+
2328+
if(strlen($version['version']) > 8 || $version['version'] == "") {
2329+
$version['version'] = "<span style='color:#aa0000;'>Error</span>";
2330+
$msg = "<span style='color:#aa0000;'><strong>Error Retrieving Latest Release.</strong></span>";
2331+
}
2332+
23322333
$objResponse->addAssign("relver", "innerHTML", $version['version']);
23332334

2334-
if(defined('SB_GIT'))
2335-
{
2336-
if(intval($version['git']) > SB_GITREV)
2337-
$svnmsg = "<span style='color:#aa0000;'><strong>A new Dev release is available.</strong></span>";
2338-
else
2339-
$svnmsg = "<span style='color:#00aa00;'><strong>You have the latest Dev release.</strong></span>";
2340-
2341-
if(strlen($version['git'])>8 || $version['git']=="") {
2342-
$version['git'] = "<span style='color:#aa0000;'>Error</span>";
2343-
$svnmsg = "<span style='color:#aa0000;'><strong>Error retrieving latest Git Commit.</strong></span>";
2344-
}
2345-
$msg .= "<br />" . $svnmsg;
2346-
$objResponse->addAssign("svnrev", "innerHTML", $version['git']);
2335+
if(defined('SB_GIT') {
2336+
if(intval($version['git']) > SB_GITREV)
2337+
$svnmsg = "<span style='color:#aa0000;'><strong>A New Beta Version is Available.</strong></span>";
2338+
} else {
2339+
$svnmsg = "<span style='color:#00aa00;'><strong>You have the Latest Beta Version.</strong></span>";
2340+
}
2341+
2342+
if(strlen($version['git']) > 8 || $version['git'] == "") {
2343+
$version['git'] = "<span style='color:#aa0000;'>Error</span>";
2344+
$svnmsg = "<span style='color:#aa0000;'><strong>Error retrieving latest Beta Release.</strong></span>";
2345+
}
2346+
$msg .= "<br>".$svnmsg;
2347+
$objResponse->addAssign("svnrev", "innerHTML", $version['git']);
23472348
}
23482349

23492350
$objResponse->addAssign("versionmsg", "innerHTML", $msg);

0 commit comments

Comments
 (0)