Skip to content

No opting out of the vercel app footnote link #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmgolembiowski opened this issue Jul 4, 2024 · 3 comments
Open

No opting out of the vercel app footnote link #20

dmgolembiowski opened this issue Jul 4, 2024 · 3 comments

Comments

@dmgolembiowski
Copy link

dmgolembiowski commented Jul 4, 2024

Regarding this:

content: "Created using https://atsresume.vercel.app/";

I get wanting to advertise the fruits of your labor, but not allowing an obvious opt-out on something people submit to prospective employers is not a good-faith practice. Would you accept a PR that at least binds this to a boolean value determined by a checkbox on the page? It could default to true.

@sauravhathi
Copy link
Owner

Thank you for bringing this up! We appreciate your feedback and suggestion. We would be open to a PR that implements the following changes:

  1. Introduces a boolean value that controls the visibility of the footnote link.
  2. Adds a checkbox on the page to allow users to opt-out of displaying the footnote link.
  3. The checkbox should default to true to maintain the current behavior unless the user chooses to opt-out.

Please ensure that the changes are well-documented and tested. We look forward to reviewing your contribution!

@joeyjooste
Copy link

Hey just going to pop in here and add that I would have used this tool if it wasn't for this painful footnote

@Mrsluggan
Copy link

Please make a option to include the footnode, i get that you want to get credit for your work, but having it just makes us fork the repo and change it ourselfs.

This app has huge potantial, so please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants