Skip to content

Commit dcf9250

Browse files
Elaborate code review process in CONTRIBUTING.md (#398)
1 parent 362c050 commit dcf9250

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

CONTRIBUTING.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
# How to Contribute
2-
3-
We'd love to accept your patches and contributions to this project. There are
4-
just a few small guidelines you need to follow.
2+
We'd love to accept your patches and contributions to this project.
3+
We just ask that you follow our contribution guidelines when you do.
54

65
## Contributor License Agreement
7-
8-
Contributions to this project must be accompanied by a signed
9-
[Contributor Agreement](ContributorAgreement.txt).
10-
You (or your employer) retain the copyright to your contribution,
11-
this simply gives us permission to use and redistribute your contributions as
12-
part of the project.
6+
Contributions to this project must be accompanied by a signed [Contributor Agreement](ContributorAgreement.txt).
7+
You (or your employer) retain the copyright to your contribution; this simply grants us permission to use and redistribute your contributions as part of the project.
138

149
## Code reviews
10+
All submissions to this project—including submissions from project members—require review.
11+
Our review process typically involves performing unit tests, development tests, integration tests, and security scans using internal SAS infrastructure.
12+
For this reason, we don’t often merge pull requests directly from GitHub.
13+
14+
Instead, we work with submissions internally first, vetting them to ensure they meet our security and quality standards.
15+
We’ll do our best to work with contributors in public issues and pull requests; however, to ensure our code meets our internal compliance standards, we may need to incorporate your submission into a solution we push ourselves.
1516

16-
All submissions, including submissions by project members, require review. We
17-
use GitHub pull requests for this purpose. Consult
18-
[GitHub Help](https://help.github.com/articles/about-pull-requests/) for more
19-
information on using pull requests.
17+
This does not mean we don’t value or appreciate your contribution.
18+
We simply need to review your code internally before merging it.
19+
We work to ensure all contributors receive appropriate recognition for their contributions, at least by acknowledging them in our release notes.

0 commit comments

Comments
 (0)