Skip to content

Commit fc8d375

Browse files
authored
Merge pull request #635 from sassoftware/staging
8.2.1 - May 8, 2025
2 parents 656d6ac + d0d00b7 commit fc8d375

File tree

4 files changed

+50
-9
lines changed

4 files changed

+50
-9
lines changed

CONTRIBUTING.md

Lines changed: 44 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,49 @@ We just ask that you follow our contribution guidelines when you do.
66
Contributions to this project must be accompanied by a signed [Contributor Agreement](ContributorAgreement.txt).
77
You (or your employer) retain the copyright to your contribution; this simply grants us permission to use and redistribute your contributions as part of the project.
88

9-
## Code reviews
10-
All submissions to this project—including submissions from project members—require review.
11-
Our review process typically involves performing unit tests, development tests, integration tests, and security scans using internal SAS infrastructure.
12-
For this reason, we don’t often merge pull requests directly from GitHub.
9+
## Code Reviews
10+
All submissions to this project—including submissions from project members—require
11+
review. Our review process typically involves performing unit tests, development
12+
tests, integration tests, and security scans.
1313

14-
Instead, we work with submissions internally first, vetting them to ensure they meet our security and quality standards.
15-
We’ll do our best to work with contributors in public issues and pull requests; however, to ensure our code meets our internal compliance standards, we may need to incorporate your submission into a solution we push ourselves.
14+
## Pull Request Requirement
1615

17-
This does not mean we don’t value or appreciate your contribution.
18-
We simply need to review your code internally before merging it.
19-
We work to ensure all contributors receive appropriate recognition for their contributions, at least by acknowledging them in our release notes.
16+
### Conventional Commits
17+
All pull requests must follow the [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/)
18+
standard for commit messages. This helps maintain a consistent and meaningful
19+
commit history. Pull requests with commits that do not follow the Conventional
20+
Commit format will not be merged.
21+
22+
### Developer Certificate of Origin Sign-Off
23+
This project requires all commits to be signed off in accordance with the [Developer Certificate of Origin (DCO)](https://developercertificate.org/).
24+
By signing off your commits, you certify that you have the right to submit the
25+
contribution under the open source license used by this project.
26+
27+
To sign off your commits, use the --signoff flag with git commit:
28+
29+
```bash
30+
git commit --signoff -m "Your commit message"
31+
```
32+
33+
This will add a Signed-off-by line to your commit message, e.g.:
34+
35+
```bash
36+
Signed-off-by: You Name <your.email@example.com>
37+
```
38+
39+
For more information, please refer to https://probot.github.io/apps/dco/
40+
41+
### Linter Analysis Checks
42+
All pull requests must pass our automated analysis checks before they can be
43+
merged. These checks include:
44+
45+
- **Hadolint** – for Dockerfile best practices
46+
- **ShellCheck** – for shell script issues
47+
- **Ansible-lint** – for Ansible playbook and role validation
48+
49+
## Security Scans
50+
To ensure that all submissions meet our security and quality standards, we perform
51+
security scans using internal SAS infrastructure. Contributions might be subjected
52+
to security scans before they can be accepted. Reporting of any Common Vulnerabilities
53+
and Exposures (CVEs) that are detected is not available in this project at this
54+
time.

examples/ansible-vars-iac.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ V4_CFG_MANAGE_STORAGE: true
1212
V4_CFG_SAS_API_KEY: <api_client_id>
1313
V4_CFG_SAS_API_SECRET: <api_client_secret>
1414
V4_CFG_ORDER_NUMBER: <order_number>
15+
V4_CFG_CADENCE_NAME: <cadence_name> # [lts|stable]
16+
V4_CFG_CADENCE_VERSION: <cadence_version>
1517

1618
## CR Access
1719
V4_CFG_CR_USER: <container_registry_user>

examples/ansible-vars.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ V4_CFG_MANAGE_STORAGE: true
2323
V4_CFG_SAS_API_KEY: <api_client_id>
2424
V4_CFG_SAS_API_SECRET: <api_client_secret>
2525
V4_CFG_ORDER_NUMBER: <order_number>
26+
V4_CFG_CADENCE_NAME: <cadence_name> # [lts|stable]
27+
V4_CFG_CADENCE_VERSION: <cadence_version>
2628

2729
## CR Access
2830
V4_CFG_CR_USER: <container_registry_user>

examples/multi-tenancy/ansible-vars-multi-tenancy.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ V4_CFG_MANAGE_STORAGE: true
1515
V4_CFG_SAS_API_KEY: <api_client_id>
1616
V4_CFG_SAS_API_SECRET: <api_client_secret>
1717
V4_CFG_ORDER_NUMBER: <order_number>
18+
V4_CFG_CADENCE_NAME: <cadence_name> # [lts|stable]
19+
V4_CFG_CADENCE_VERSION: <cadence_version>
1820

1921
## CR Access
2022
V4_CFG_CR_USER: <container_registry_user>

0 commit comments

Comments
 (0)