Added unit testing for write_score_code.py, tasks.py, and model_parameters.py

Author: djm21

src/sasctl/pzmm/model_parameters.py

@@ -171,13 +171,13 @@ def statsmodels_params():
 
         if model.__class__.__module__.__contains__("sklearn"):
             sklearn_params()
-        elif model.__class__.__module__.startswith("keras."):
+        elif model.__class__.__module__.startswith("keras"):
             tf_params()
-        elif model.__class__.__module__.startswith("xgboost."):
+        elif model.__class__.__module__.startswith("xgboost"):
             xg_params()
-        elif model.__class__.__module__.startswith("h2o."):
+        elif model.__class__.__module__.startswith("h2o"):
             h2o_params()
-        elif model.__class__.__module__.startswith("statsmodels."):
+        elif model.__class__.__module__.startswith("statsmodels"):
             statsmodels_params()
 
         else:
@@ -397,6 +397,7 @@ def get_project_kpis(
 
         return kpi_table_df
 
+    @staticmethod
     def sync_model_properties(
         project: Union[str, dict, RestObj], overrwrite: Optional[bool] = False
     ):
@@ -419,4 +420,4 @@ def sync_model_properties(
                     # If property is set in project, check if it's set in model, and update model accordingly
                     if model_property not in model or overrwrite:
                         model[model_property] = project[project_property]
-            mr.update_model(model)
+            mr.update_model(model)

src/sasctl/tasks.py

@@ -192,7 +192,7 @@ def _format_properties(model, input_vars=None, output_vars=None):
     # Get input & output variable lists
     # Note: copying lists to avoid altering original
     input_vars = input_vars or model.get("inputVariables", [])
-    output_vars = output_vars or model.get("outputVariables", [])[:]
+    output_vars = output_vars or model.get("outputVariables", [])
     input_vars = input_vars[:]
     output_vars = output_vars[:]
     unformatted_variables = input_vars + output_vars
@@ -227,7 +227,7 @@ def _format_properties(model, input_vars=None, output_vars=None):
 
 
 def _compare_properties(project_name, model, input_vars=None, output_vars=None):
-    properties, variables = _format_properties(model, input_vars, output_vars)
+    properties, _ = _format_properties(model, input_vars, output_vars)
     project = mr.get_project(project_name)
     same_properties = True
     for p in properties:

tests/unit/test_model_parameters.py

@@ -14,6 +14,13 @@
 
 from sasctl import RestObj, current_session
 from sasctl.pzmm import ModelParameters as mp
+import unittest
+import uuid
+import xgboost
+import h2o
+import tensorflow as tf
+import statsmodels.formula.api as smf
+import numpy as np
 
 
 class BadModel:
@@ -213,3 +220,104 @@ def test_get_project_kpis(self):
                 assert len(kpi_table.columns) == 1
 
                 assert not kpi_table.loc[1]["testName"]
+
+
+class TestSyncModelProperties(unittest.TestCase):
+    MODEL_PROPERTIES = [
+        ("targetVariable", "targetVariable"),
+        ("targetLevel", "targetLevel"),
+        ("targetEventValue", "targetEvent"),
+        ("eventProbabilityVariable", "eventProbVar"),
+        ("function", "function"),
+    ]
+
+    def test_project_id(self):
+        with mock.patch('sasctl._services.model_repository.ModelRepository.get_project') as get_project:
+            with mock.patch('sasctl._services.model_repository.ModelRepository.get') as get:
+                with mock.patch('sasctl._services.model_repository.ModelRepository.get_model') as get_model:
+                    with mock.patch('sasctl._services.model_repository.ModelRepository.update_model') as update:
+                        pUUID = uuid.uuid4()
+                        mp.sync_model_properties(pUUID, False)
+                        get.assert_called_with(f"/projects/{pUUID}/models")
+
+                        project_dict = {'id': 'projectID'}
+                        mp.sync_model_properties(project_dict, False)
+                        get.assert_called_with("/projects/projectID/models")
+
+                        project_name = 'project'
+                        get_project.return_value = {'id': "pid"}
+                        mp.sync_model_properties(project_name, False)
+                        get.assert_called_with("/projects/pid/models")
+
+    def test_overwrite(self):
+        with mock.patch('sasctl._services.model_repository.ModelRepository.get_project') as get_project:
+            with mock.patch('sasctl._services.model_repository.ModelRepository.get') as get:
+                with mock.patch('sasctl._services.model_repository.ModelRepository.get_model') as get_model:
+                    with mock.patch('sasctl._services.model_repository.ModelRepository.update_model') as update:
+                        project_dict = {'id': 'projectID', 'function': 'project_function', 'targetLevel': '1'}
+                        get.return_value = [RestObj({'id': 'modelID'})]
+                        get_model.return_value = {'function': 'classification'}
+                        mp.sync_model_properties(project_dict)
+                        update.assert_called_with({'function': 'classification', 'targetLevel': '1'})
+
+                        project_dict = {'id': 'projectID', 'function': 'project_function', 'targetLevel': '1'}
+                        get.return_value = [RestObj({'id': 'modelID'})]
+                        get_model.return_value = {'function': 'classification'}
+                        mp.sync_model_properties(project_dict, True)
+                        update.assert_called_with({'function': 'project_function', 'targetLevel': '1'})
+
+
+class TestGenerateHyperparameters(unittest.TestCase):
+
+    def test_xgboost(self):
+        model = unittest.mock.Mock()
+        model.__class__ = xgboost.Booster
+        attrs = {'save_config.return_value': json.dumps({'test': 'passed'})}
+        model.configure_mock(**attrs)
+        tmp_dir = tempfile.TemporaryDirectory()
+        mp.generate_hyperparameters(model, 'prefix', Path(tmp_dir.name))
+        assert Path(
+            Path(tmp_dir.name) / f"./prefixHyperparameters.json"
+        ).exists()
+
+    def test_xgboost_sklearn(self):
+        model = unittest.mock.Mock()
+        model.__class__ = xgboost.XGBModel
+        attrs = {'get_params.return_value': json.dumps({'test': 'passed'})}
+        model.configure_mock(**attrs)
+        tmp_dir = tempfile.TemporaryDirectory()
+        mp.generate_hyperparameters(model, 'prefix', Path(tmp_dir.name))
+        assert Path(
+            Path(tmp_dir.name) / f"./prefixHyperparameters.json"
+        ).exists()
+
+    def test_h2o(self):
+        model = unittest.mock.Mock()
+        model.__class__ = h2o.H2OFrame
+        attrs = {'get_params.return_value': json.dumps({'test': 'passed'})}
+        model.configure_mock(**attrs)
+        tmp_dir = tempfile.TemporaryDirectory()
+        mp.generate_hyperparameters(model, 'prefix', Path(tmp_dir.name))
+        assert Path(
+            Path(tmp_dir.name) / f"./prefixHyperparameters.json"
+        ).exists()
+
+    def test_tensorflow(self):
+        model = unittest.mock.Mock()
+        model.__class__ = tf.keras.Sequential
+        attrs = {'get_config.return_value': json.dumps({'test': 'passed'})}
+        model.configure_mock(**attrs)
+        tmp_dir = tempfile.TemporaryDirectory()
+        mp.generate_hyperparameters(model, 'prefix', Path(tmp_dir.name))
+        assert Path(
+            Path(tmp_dir.name) / f"./prefixHyperparameters.json"
+        ).exists()
+
+    def test_statsmodels(self):
+        model = unittest.mock.Mock(exog_names = ['test', 'exog'], weights = np.array([0, 1]))
+        model.__class__ = smf.ols
+        tmp_dir = tempfile.TemporaryDirectory()
+        mp.generate_hyperparameters(model, 'prefix', Path(tmp_dir.name))
+        assert Path(
+            Path(tmp_dir.name) / f"./prefixHyperparameters.json"
+        ).exists()