Skip to content

Commit 104e51a

Browse files
committed
feat(mp4): final version of video output
1 parent 112d2ba commit 104e51a

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ Blazingly fast terminal recorder that generates animated gif images for the web
3333
- Hidden feature: Record every window you want
3434
- Written in Rust 🦀
3535

36+
## Demo video
37+
38+
![demo-video](./docs/demo-video.mp4)
39+
3640
## Installation on MacOS
3741
### with homebrew
3842
```sh

docs/demo-video.mp4

23.2 KB
Binary file not shown.

snap/snapcraft.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ parts:
2626
- libx11-dev
2727
stage-packages:
2828
- imagemagick
29+
- ffmpeg
2930

3031
apps:
3132
t-rec:

src/generators/mp4.rs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ pub fn generate_mp4_with_ffmpeg(
3838
target: &str,
3939
) -> Result<()> {
4040
println!("🎉 🎬 Generating {}", &target);
41-
let out = Command::new(PROGRAM)
41+
Command::new(PROGRAM)
4242
.arg("-y")
4343
.arg("-r")
4444
// framerate
@@ -59,11 +59,6 @@ pub fn generate_mp4_with_ffmpeg(
5959
// end of fix
6060
.arg(target)
6161
.output()
62-
.with_context(|| format!("Cannot start '{}' to generate the final video", PROGRAM))?;
63-
// .map(|_| ())
64-
65-
println!("{}", String::from_utf8(out.stdout).unwrap());
66-
println!("{}", String::from_utf8(out.stderr).unwrap());
67-
68-
Ok(())
62+
.with_context(|| format!("Cannot start '{}' to generate the final video", PROGRAM))
63+
.map(|_| ())
6964
}

0 commit comments

Comments
 (0)