Skip to content

Commit 84f6d7b

Browse files
committed
update the reader in the form builder test
1 parent d37d95e commit 84f6d7b

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

internal/form_builder_test.go

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,21 @@ func (*failingReader) Read([]byte) (int, error) {
5454
}
5555

5656
func TestFormBuilderWithReader(t *testing.T) {
57+
file, err := os.CreateTemp(t.TempDir(), "")
58+
if err != nil {
59+
t.Fatalf("Error creating tmp file: %v", err)
60+
}
61+
defer file.Close()
62+
builder := NewFormBuilder(&failingWriter{})
63+
err = builder.CreateFormFileReader("file", file, file.Name())
64+
checks.ErrorIs(t, err, errMockFailingWriterError, "formbuilder should return error if writer fails")
65+
66+
builder = NewFormBuilder(&bytes.Buffer{})
5767
reader := &failingReader{}
58-
body := &bytes.Buffer{}
59-
builder := NewFormBuilder(body)
60-
err := builder.CreateFormFileReader("file", reader, "")
61-
checks.ErrorIs(t, err, errMockFailingReaderError, "formbuilder should return error if writer fails")
68+
err = builder.CreateFormFileReader("file", reader, "")
69+
checks.ErrorIs(t, err, errMockFailingReaderError, "formbuilder should return error if copy reader fails")
6270

6371
successReader := &bytes.Buffer{}
6472
err = builder.CreateFormFileReader("file", successReader, "")
65-
checks.NoError(t, err, "formbuilder should not return error if writer fails")
73+
checks.NoError(t, err, "formbuilder should not return error")
6674
}

0 commit comments

Comments
 (0)