-
Notifications
You must be signed in to change notification settings - Fork 79
feat(audit-logs): adds otel-collector for auditing purposes, initial version #9892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…version This adds an audit-logs otel-collector for the purpose of audit logs. At this point in time only 'audit-poller' information is ingested and sent to OpenSearch. --------- on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
1cb0218 to
a2ad155
Compare
d858eda to
30d4e07
Compare
--------- on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
30d4e07 to
f3881ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 🚀
Only small remarks
| - name: prometheus | ||
| port: 9999 | ||
| {{- end }} | ||
| image: {{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "repository" }}:{{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "tag" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| image: {{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "repository" }}:{{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "tag" }} | |
| image: {{ index .Values "openTelemetryPlugin.auditLogs" "opentelemetry-operator" "manager" "collectorImage" "repository" }}:{{ index .Values "openTelemetryPlugin.auditLogs" "opentelemetry-operator" "manager" "collectorImage" "tag" }} |
Suggestion: With this we would have the possibility to have separate images for logs and audit-logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm but that is not the idea is it?
Like the split of images would be by having two different GH plugins no? That this audit-logs helm-chart references the audit-log gh plugin and thus has another image. 🤔
--------- on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
568d187 to
81a98f4
Compare
…ge in a different section --------- on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
This adds an audit-logs otel-collector for the purpose of audit logs. At this point in time only 'audit-poller' information is ingested and sent to OpenSearch.
on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)