Skip to content

Conversation

@olandr
Copy link
Contributor

@olandr olandr commented Oct 13, 2025

This adds an audit-logs otel-collector for the purpose of audit logs. At this point in time only 'audit-poller' information is ingested and sent to OpenSearch.


on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)

@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

…version

This adds an audit-logs otel-collector for the purpose of audit logs. At this point in time only 'audit-poller' information is ingested and sent to OpenSearch.

---------

on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
@olandr olandr force-pushed the feat/audit-logs-otel branch from 1cb0218 to a2ad155 Compare October 13, 2025 13:17
@olandr olandr requested review from Kuckkuck and timojohlo October 13, 2025 13:18
@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

@olandr olandr force-pushed the feat/audit-logs-otel branch from d858eda to 30d4e07 Compare October 21, 2025 14:51
@sapcc-bot
Copy link
Contributor

Failed to validate the Prometheus rules. Details. Readme.

@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

---------

on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
@olandr olandr force-pushed the feat/audit-logs-otel branch from 30d4e07 to f3881ab Compare October 21, 2025 14:52
@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

Copy link
Member

@timojohlo timojohlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🚀
Only small remarks

- name: prometheus
port: 9999
{{- end }}
image: {{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "repository" }}:{{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "tag" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: {{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "repository" }}:{{ index .Values "openTelemetryPlugin" "opentelemetry-operator" "manager" "collectorImage" "tag" }}
image: {{ index .Values "openTelemetryPlugin.auditLogs" "opentelemetry-operator" "manager" "collectorImage" "repository" }}:{{ index .Values "openTelemetryPlugin.auditLogs" "opentelemetry-operator" "manager" "collectorImage" "tag" }}

Suggestion: With this we would have the possibility to have separate images for logs and audit-logs.

Copy link
Contributor Author

@olandr olandr Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm but that is not the idea is it?

Like the split of images would be by having two different GH plugins no? That this audit-logs helm-chart references the audit-log gh plugin and thus has another image. 🤔

@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

@olandr olandr requested a review from timojohlo October 29, 2025 10:00
---------

on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
@olandr olandr force-pushed the feat/audit-logs-otel branch from 568d187 to 81a98f4 Compare October 29, 2025 14:26
@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

…ge in a different section

---------

on-behalf-of: @SAP Simon Olander (simon.olander@sap.com)
@sapcc-bot
Copy link
Contributor

Failed to validate the helm chart. Details. Readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants