[Cinder] Split up cinder-api into external and internal #9723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemna
reviewed
Sep 30, 2025
openstack/cinder/Chart.lock
Outdated
| version: 2.2.15 | ||
| - name: redis | ||
| repository: oci://keppel.eu-de-1.cloud.sap/ccloud-helm | ||
| version: 2.2.15 |
There was a problem hiding this comment.
Isn't redis already in this file in the lines above?
There was a problem hiding this comment.
Yes. I'm not sure why helm adds two exact same entries. Probably an implementation detail in helm, because we have 2 entries in Chart.yaml to get 2 redis instances, which use the same version. If the versions would differ, we'd probably had 2 different entries.
Edit: What might not be obvious in my answer: The file is auto-generated with helm dep up openstack/cinder.
In the api-paste.ini we still had sections that were meant to be used with the `mitaka` release. We will not run that release anymore and don't run it for a while, so we clean up that code now.
joker-at-work
force-pushed
the
cinder-multiple-apis
branch
from
a0a362c to
767591c
Compare
joker-at-work
force-pushed
the
cinder-multiple-apis
branch
from
767591c to
c312f0b
Compare
joker-at-work
force-pushed
the
cinder-multiple-apis
branch
from
c312f0b to
5dde93d
Compare
joker-at-work
force-pushed
the
cinder-multiple-apis
branch
from
5dde93d to
18e186e
Compare
|
Merging this, new pods will be created and the |
joker-at-work
force-pushed
the
cinder-multiple-apis
branch
from
18e186e to
5375235
Compare
We want to configure different rate-limits and policies for inter-service communication compared to user communication. To make this work, we need different cinder-api pods. Keystone's service-catalog already supports having different endpoints for these purposes. We spawn a cinder-api-external and a cinder-api-internal deployment each with their own cinder-api-external/internal-ratelimit-redis, since the rate-limit-middleware doesn't support re-using the same redis for multiple apis and it allows us to deploy the redis next to the cinder-api in the same cluster, if we want to. Since most of the configuration/YAML is the same between the two cinder-api pods, we define template function and provide the individual configuration as parameters. During the rollout, there will be a time where the new internal endpoint is not yet synced into the Keystone catalogue. Therefore, we also keep the old "cinder-api" Service alive, pointing to the cinder-api-external Deployment as before. It should be easy to extend this pattern with an "admin" API endpoint as supported by Keystone's catalogue if we choose to use that in the future. This commit contains some restructuring, e.g. introducing new cinder-api-external-etc and cinder-api-internal-etc ConfigMaps to hold and template API configuration and switching to projected volume mounting in the api Deployment for better readability and static config during the runtime.
fwiesel
approved these changes
Oct 29, 2025
hemna
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commits' messages.
This requires a change in the openstack/utils chart to change the endpoint host for the seed to Keystone.
Rolling this out also depends on the secrets getting updated.