Add cinder db-online-migrate-job #10017
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this separates the cinder db online migration out from the migrate-job in case the data migrations take a long time, it doesn't prevent the api from restarting.
hemna
force-pushed
the
cinder-db-online-migration-job
branch
from
adef138 to
32156ab
Compare
joker-at-work
requested changes
Oct 30, 2025
| # since this name changes with every image change, removal and creation of | ||
| # this Job happens on nearly every deployment. Check the helm-chart changes | ||
| # to see if this needs more review. | ||
| name: {{ tuple . "db-online-migrate" | include "job_name" }} |
There was a problem hiding this comment.
Nova has this, Cinder doesn't.
openstack/nova/templates/_helpers.tpl:{{- define "job_name" }}
You'd probably have to rewrite cinder.migration_job_name for that.
Comment on lines
+46
to
+53
| - name: cinder-etc | ||
| mountPath: /etc/cinder/api-paste.ini | ||
| subPath: api-paste.ini | ||
| readOnly: true | ||
| - name: cinder-etc | ||
| mountPath: /etc/cinder/policy.yaml | ||
| subPath: policy.yaml | ||
| readOnly: true |
There was a problem hiding this comment.
I don't think the migration-job should need either of these configs. They are api-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this separates the cinder db online migration out from the migrate-job in case the data migrations take a long time, it doesn't prevent the api from restarting.