Cherry-pick:[vmware] Retry fetch_stream_optimized_image on DuplicateName #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch_stream_optimized_image currently deletes the backing on any error. The same function is used when reimaging a volume in the VolumeManager, so when a volume with the id already exists, which causes the DuplicateName exception to be raised and in turn not only stops the image from being re-imaged, but the backing to be deleted. Retrying the method in that case will result in the desired outcome of the volume being re-created from scratch. Signed-off-by: fabian.wiesel@sap.com Related-Bug: 2097771 Change-Id: I7723ebcd02a7dd4b107aeab1a4c3c12389664fea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch_stream_optimized_image currently deletes the backing on any error. The same function is used when reimaging a volume in the VolumeManager, so when a volume with the id already exists, which causes the DuplicateName exception to be raised and in turn not only stops the image from being re-imaged, but the backing to be deleted.
Retrying the method in that case will result in the desired outcome of the volume being re-created from scratch.
Signed-off-by: fabian.wiesel@sap.com
Related-Bug: 2097771
Change-Id: I7723ebcd02a7dd4b107aeab1a4c3c12389664fea