Implement external scheduler call #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippMatthes
force-pushed
the
external-scheduler-call
branch
from
5e34d65 to
a11d44d
Compare
PhilippMatthes
force-pushed
the
external-scheduler-call
branch
from
a11d44d to
cd13b27
Compare
hemna
reviewed
Aug 15, 2025
| # Note: the result can also be empty. | ||
| weighed_backends = call_external_scheduler_api( | ||
| context, weighed_backends, request_spec) | ||
|
|
There was a problem hiding this comment.
please do not modify the cinder scheduler. This should be in an external weigher that can be enabled/disabled.
There was a problem hiding this comment.
The external scheduler call can do both: weighing and filtering. It can be enabled/disabled by setting/unsetting the external scheduler url.
There was a problem hiding this comment.
The proper way is to create a new weigher and add it to the list of scheduler_default_weighers. Do not modify the cinder scheduler code.
hemna
requested changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for an external service that can perform advanced scheduling
decisions. FilterScheduler now calls a function call_external_scheduler_api
after executing filters and weighers. This function sends the hosts and their
current weights to an external scheduling service. This service then performs
advanced scheduling decisions and returns the sorted list of host names, from
highest priority to lowest priority. To toggle this feature, provide
external_scheduler_api_url to Cinder's configuration.
Also implemented for Nova: sapcc/nova#502
And for Manila: sapcc/manila#263