[SAP] Moved cinder-nanny from nanny repo to /cinder-nanny/scripts #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagoleni
requested review from
Carthaca,
Scsabiii,
hemna,
joker-at-work and
seb-kro
hemna
reviewed
Mar 13, 2025
| unset http_proxy https_proxy all_proxy no_proxy | ||
|
|
||
| echo "INFO: copying cinder config files to /etc/cinder" | ||
| cp -vrL /cinder-etc/* /etc/cinder |
There was a problem hiding this comment.
Shouldn't this be a deployment issue? I don't think we should be copying files around in a deployed container.
|
|
||
| # cinder is now using proxysql by default in its config - change that back to a normal | ||
| # config for the nanny as we do not need it and do not have the proxy around by default | ||
| sed -i 's,@/cinder?unix_socket=/run/proxysql/mysql.sock&,@cinder-mariadb/cinder?,g' "${DB_CONFIG}" |
There was a problem hiding this comment.
Also a deployment issue. temporary hacks turn into permanent hacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies the cinder nanny code from the soon to be deprecated nanny repo (https://github.com/sapcc/openstack-nannies). In a still to come PR, the nanny code will be refactored:
setup.cfgfile moving will be removedIn this PR, nanny code is just formatted differently to pass the linting check, the code itself has not been modified.