lint fixes

Author: rainerleber

.github/workflows/ansible-lint-config

@@ -7,3 +7,4 @@ skip_list:
   - risky-shell-pipe
   - no-changed-when
   - no-handler
+  - ignore-errors

roles/sap_control/tasks/functions/cleanipc.yml

@@ -8,4 +8,4 @@
   become_user: "{{ passed_sap_sid | lower }}adm"
   register: cleanipc
   changed_when:
-    - "'Number of IPC-Objects...........:    0' not in cleanipc.stdout"
+    - "'Number of IPC-Objects...........:    0' not in cleanipc.stdout"

roles/sap_control/tasks/functions/restart_sapstartsrv.yml

@@ -1,6 +1,5 @@
 # Restart sapstartsrv
 
-
 # Get number of sapstartsrv processes running for {{ passed_sap_sid }}-{{ passed_sap_nr }}
 - name: SAPstartsrv - Get number of sapstartsrv processes running for {{ passed_sap_sid }}-{{ passed_sap_nr }}
   ansible.builtin.shell: |
@@ -32,7 +31,7 @@
   become: true
   become_user: "{{ passed_sap_sid | lower }}adm"
   register: sap_start_sapstartsrv
-  
+
 - name: SAPstartsrv - Wait for 10 seconds for sapstartsrv to initialize
   ansible.builtin.pause:
     seconds: 10

roles/sap_fapolicy/defaults/main.yml

@@ -1,4 +1,3 @@
-
 # https://access.redhat.com/discussions/3936201
 
 sap_fapolicy_sid:

roles/sap_fapolicy/tasks/enable_fapolicy.yml

@@ -1,7 +1,6 @@
 ---
-
 - name: SAP Faplocy - Service fapolicy state - start & enable
   ansible.builtin.systemd:
     state: started
     name: fapolicyd
-    enabled: true
+    enabled: true

roles/sap_firewall/tasks/enable_firewall.yml

@@ -4,4 +4,4 @@
     name: firewalld
     state: started
     enabled: true
-    masked: no
+    masked: false

roles/sap_hana_backint/defaults/main.yml

@@ -1,3 +1,4 @@
+---
 # setup, execute, clean
 backup_function:
 
@@ -11,7 +12,7 @@ sap_hana_backint_setup_system_tenant_passwd: NewPass$321
 
 # Variables for Setup function
 log_enable: false
-#sap_hana_backint_setup_backint_directory: "/usr/sap/hana/backint"
+# sap_hana_backint_setup_backint_directory: "/usr/sap/hana/backint"
 sap_hana_backint_setup_hostname: "{{ ansible_hostname }}"
 system_backup_user: "HDB_SYSTEM_BACKUP_USER"
 

roles/sap_hana_backint/tasks/execute/execute.yml

@@ -19,6 +19,6 @@
   when: sap_hana_sid == "all"
 
 - name: SAP HANA Backint - Output NOTICE
-  debug:
+  ansible.builtin.debug:
     msg:
       - "Please note that backups were triggered in the background"

roles/sap_hana_backint/tasks/get_all_sap_hana_tenant.yml

@@ -11,10 +11,10 @@
   register: get_all_sap_hana_tenant
 
 #  Code below doesnt work when running in crontab
-#- name: Get Tenant DBs of SAP HANA Database Server {{ sap_hana_sid }}
-#  shell: |
-#    su - {{ sap_hana_sid | lower }}adm -c "hdbsql -x -a -U {{ system_backup_user }} \"select DATABASE_NAME from SYS.M_DATABASES WHERE DATABASE_NAME != 'SYSTEMDB'\" | sed 's/\"//g'"
-#  register: get_all_sap_hana_tenant
+# - name: Get Tenant DBs of SAP HANA Database Server {{ sap_hana_sid }}
+#   shell: |
+#     su - {{ sap_hana_sid | lower }}adm -c "hdbsql -x -a -U {{ system_backup_user }} \"select DATABASE_NAME from SYS.M_DATABASES WHERE DATABASE_NAME != 'SYSTEMDB'\" | sed 's/\"//g'"
+#   register: get_all_sap_hana_tenant
 
 # Return value - sap_hana_tenant
 - name: SAP HANA Backint - Get info - Set facts for all SAP HANA Tenants

roles/sap_hana_backint/tasks/setup/setup_backint_aws_s3.yml

@@ -103,13 +103,13 @@
     mode: "0755"
 
 # Softlink hdbbackint
-#- name: SAP HANA Backint - Setup - AWS S3 - {{ sap_hana_backint_setup_backint_file }} {{ sap_hana_backint_setup_backint_directory }}/hdbbackint
-#  ansible.builtin.file:
-#    src: "{{ sap_hana_backint_setup_backint_file }}"
-#    dest: "{{ sap_hana_backint_setup_backint_directory }}/hdbbackint"
-#    owner: "{{ passed_sap_hana_sid | lower }}adm"
-#    group: sapsys
-#    state: link
+# - name: SAP HANA Backint - Setup - AWS S3 - {{ sap_hana_backint_setup_backint_file }} {{ sap_hana_backint_setup_backint_directory }}/hdbbackint
+#   ansible.builtin.file:
+#     src: "{{ sap_hana_backint_setup_backint_file }}"
+#     dest: "{{ sap_hana_backint_setup_backint_directory }}/hdbbackint"
+#     owner: "{{ passed_sap_hana_sid | lower }}adm"
+#     group: sapsys
+#     state: link
 
 # Process hdbbackint.cfg
 - name: SAP HANA Backint - Setup - AWS S3 - Process hdbbackint.cfg
@@ -124,7 +124,7 @@
   ansible.builtin.file:
     path: "{{ sap_hana_backint_setup_backint_directory }}"
     state: directory
-    recurse: yes
+    recurse: true
     mode: "0755"
     owner: "{{ passed_sap_hana_sid | lower }}adm"
     group: sapsys