collection: resolve pr comments

Author: sean-freeman

docs/EXEC_EXAMPLES.md

@@ -79,7 +79,7 @@ ansible-playbook --timeout 60 ./community.sap_operations/playbooks/sample-sap-fa
 # Option 2: Use sequential parse/execution, by using include_role inside Task block
   tasks:
   - name: Execute Ansible Role to start/stop SAP Systems
-    include_role:
+    ansible.builtin.include_role:
       name: { role: community.sap_operations.sap_control }
 
 # Option 3: Use task block with import_roles

playbooks/sample-sap-control-all-restart-nw.yml

@@ -4,4 +4,4 @@
   vars:
     sap_control_function: "restart_all_nw"
   roles:
-    - {role: community.sap_operations.sap_control}
+    - { role: community.sap_operations.sap_control }

playbooks/sample-sap-fapolicy-all-update.yml

@@ -14,7 +14,7 @@
   - name: Fapolicy Update - generic
     vars:
       sap_fapolicy_type: "generic"
-    include_role:
+    ansible.builtin.include_role:
       name: community.sap_operations.sap_fapolicy
     loop: "{{ sap_fapolicy_user_generic_list }}"
     loop_control:
@@ -30,6 +30,6 @@
     vars:
       sap_fapolicy_sid: "{{ item.Type }}"
       sap_fapolicy_type: "{{ item.Type }}"
-    include_role:
+    ansible.builtin.include_role:
       name: community.sap_operations.sap_fapolicy
     loop: "{{ sap_facts_register.sap_facts }}"

playbooks/sample-sap-firewall-all-update.yml

@@ -13,6 +13,6 @@
     vars:
       sap_firewall_type: "{{ item.Type }}"
       sap_firewall_instance_nr: "{{ item.InstanceNumber }}"
-    include_role:
+    ansible.builtin.include_role:
       name: community.sap_operations.sap_firewall
     loop: "{{ sap_facts_register.sap_facts }}"

playbooks/sample-sap-profile-update.yml

@@ -32,6 +32,6 @@
     vars:
       sap_update_profile_sid: "{{ item.SID }}"
       sap_update_profile_instance_nr: "{{ item.InstanceNumber }}"
-    include_role:
+    ansible.builtin.include_role:
       name: community.sap_operations.sap_profile_update
     loop: "{{ sap_facts_register.sap_facts }}"

playbooks/sample-sap-rfc.yml

@@ -28,7 +28,7 @@
       target_parameters:
         REQUTEXT: 'Hello SAP!'
       target_connection: "{{ reuse_connection }}"
-    include_role:
+    ansible.builtin.include_role:
       name: community.sap_operations.sap_rfc
     register: sap_rfc_output1
 
@@ -46,7 +46,7 @@
         RFCTABLE:
           - COLUMN0: test
       target_connection: "{{ reuse_connection }}"
-    include_role:
+    ansible.builtin.include_role:
       name: community.sap_operations.sap_rfc
     register: sap_rfc_output2
 

roles/sap_control/tasks/main.yml

@@ -6,22 +6,26 @@
 
 # Check inputs
 - name: Check function validity
-  ansible.builtin.fail: msg="Function {{ sap_control_function }} is invalid"
+  ansible.builtin.fail:
+    msg: "Function {{ sap_control_function }} is invalid"
   when:
     - "sap_control_function not in sap_control_functions_list"
 
 - name: Check function if defined
-  ansible.builtin.fail: msg="No sap_control_function defined"
+  ansible.builtin.fail:
+    msg: "No sap_control_function defined"
   when:
     - "sap_control_function == 'initial'"
 
 # - name: Check function - all and SID
-#   fail: msg="An 'all' function and a 'SID' cant be used at the same time"
+#   ansible.builtin.fail:
+#     msg: "An 'all' function and a 'SID' cant be used at the same time"
 #   when:
 #     - (sap_sid != 'initial') and ('all' in sap_control_function)
 
 - name: Check function - all and SID
-  ansible.builtin.fail: msg="Parameter 'sap_sid' is required when not using an 'all' function"
+  ansible.builtin.fail:
+    msg: "Parameter 'sap_sid' is required when not using an 'all' function"
   when:
     - (sap_sid == 'initial') and ('all' not in sap_control_function)
 
@@ -77,7 +81,7 @@
 # - name: Get SAP Info
 #   vars:
 #     sap_info_get_function: "get_{{ sap_control_get_type }}_{{ sap_control_sap_type }}"
-#   include_role:
+#   ansible.builtin.include_role:
 #     name: roles/sap_info
 
 # Get SAP Facts

roles/sap_fapolicy/README.md

@@ -53,7 +53,7 @@ Fapolicy entries will be updated to allow access to the following directories
       - name: Fapolicy Update - generic
         vars:
           sap_fapolicy_type: "generic"
-        include_role:
+        ansible.builtin.include_role:
           name: community.sap_operations.sap_fapolicy
         loop: "{{ sap_fapolicy_user_generic_list }}"
         loop_control:
@@ -79,7 +79,7 @@ Fapolicy entries will be updated to allow access to the following directories
         vars:
           sap_fapolicy_sid: "{{ item.Type }}"
           sap_fapolicy_type: "{{ item.Type }}"
-        include_role:
+        ansible.builtin.include_role:
           name: community.sap_operations.sap_fapolicy
         loop: "{{ sap_facts_register.sap_facts }}"
     ```

roles/sap_firewall/README.md

@@ -60,7 +60,7 @@ Ansible role for updating firewall port entries based on SAP instance numbers
         vars:
           sap_firewall_type: "{{ item.Type }}"
           sap_firewall_instance_nr: "{{ item.InstanceNumber }}"
-        include_role:
+        ansible.builtin.include_role:
           name: community.sap_operations.sap_firewall
         loop: "{{ sap_facts_register.sap_facts }}"
     ```

roles/sap_hana_backint/tasks/get_all_sap_hana_tenant.yml

@@ -12,7 +12,7 @@
 
 #  Code below doesnt work when running in crontab
 # - name: Get Tenant DBs of SAP HANA Database Server {{ sap_hana_sid }}
-#   shell: |
+#   ansible.builtin.shell: |
 #     su - {{ sap_hana_sid | lower }}adm -c "hdbsql -x -a -U {{ system_backup_user }} \"select DATABASE_NAME from SYS.M_DATABASES WHERE DATABASE_NAME != 'SYSTEMDB'\" | sed 's/\"//g'"
 #   register: get_all_sap_hana_tenant