fixed bugs

Author: santosh79

lib/datastructures/hash.ex

@@ -405,8 +405,11 @@ defmodule Remixdb.Hash do
   end
 
   def handle_call({:hstrlen, hash_name, key}, _from, table) do
-    res = get_hash_key(table, hash_name, key) |>
-      :erlang.byte_size
+    val = get_hash_key(table, hash_name, key)
+    res = case val do
+            nil -> 0
+            _ -> :erlang.byte_size(val)
+    end
 
     {:reply, res, table}
   end
@@ -432,19 +435,10 @@ defmodule Remixdb.Hash do
   end
 
   def handle_call({:hgetall, hash_name}, _from, table) do
-    # The match spec:
-    #   - Pattern: keys matching {hash_name, $"$1"} with value $"$2"
-    #   - No guards.
-    #   - Return a tuple {field, value} for each match.
-    match_spec = [{{{hash_name, :"$1"}, :"$2"}, [], [ {:"$1", :"$2"} ]}]
-    
-    # ETS.select returns a list of tuples, e.g. [{field1, value1}, {field2, value2}, ...]
-    result = :ets.select(table, match_spec)
-    
-    # If you want the results as an interleaved list [field1, value1, field2, value2, ...], you can flatten:
-    interleaved = Enum.flat_map(result, fn {k, v} -> [k, v] end)
-    
-    {:reply, interleaved, table}
+    result =
+      get_all_entries(table, hash_name)
+      |> Enum.flat_map(fn({k, v}) -> [k, v] end)
+    {:reply, result, table}
   end
 
   def handle_call(:flushall, _from, table) do

lib/redis/connection.ex

@@ -103,8 +103,8 @@ defmodule Remixdb.RedisConnection do
           end)
 
         case res do
-          true -> "OK"
-          _ -> "ERR no such key"
+          false -> {:error, "ERR no such key"}
+          _ -> "OK"
         end
 
       {:renamenx, [_old_name, _new_name]} ->

lib/redis/response_handler.ex

@@ -27,6 +27,13 @@ defmodule Remixdb.Redis.ResponseHandler do
     socket
   end
 
+  def send_response(socket, val) when is_boolean(val) do
+    case val do
+      true -> send_response(socket, 1)
+      _ -> send_response(socket, 0)
+    end
+  end
+
   def send_response(socket, val) when is_list(val) do
     header = "*" <> (val |> Enum.count |> Integer.to_string) <> "\r\n"
     :gen_tcp.send socket, header

lib/tcp_server.ex

@@ -13,7 +13,7 @@ defmodule Remixdb.TcpServer do
   end
 
   def handle_info(:long_init, %{port: port} = state) do
-    {:ok, socket} = :gen_tcp.listen(port, [:binary, packet: :line, active: false, reuseaddr: true, backlog: 1_000])
+    {:ok, socket} = :gen_tcp.listen(port, [:binary, packet: :line, active: false, reuseaddr: true, backlog: 4096])
     :io.format("~p at port: ~p ~n", [__MODULE__, port])
 
     updated_state = state |> Map.put(:socket, socket)

test/remixdb_test.exs

@@ -199,7 +199,7 @@ defmodule RemixdbTest do
       assert val === vv
 
       unknown_key = :erlang.make_ref() |> inspect()
-      {:ok, val} = client |> :eredis.q(["RENAME", unknown_key, :erlang.make_ref() |> inspect()])
+      {:error, val} = client |> :eredis.q(["RENAME", unknown_key, :erlang.make_ref() |> inspect()])
       assert val === "ERR no such key"
     end
 
@@ -591,10 +591,10 @@ defmodule RemixdbTest do
       {:ok, val} = client |> :eredis.q(["SREM", key1] ++ full_list)
       assert val === "0"
 
-      # SantoshTODO
-      # val = client |> :eredis.q(["SREM", "key1"] ++ full_list)
-      # val = client |> :eredis.q(["EXISTS", "key1"])
-      # assert val === "0"
+      {:ok, val} = client |> :eredis.q(["SREM", "key1"] ++ full_list)
+      assert val === "0"
+      {:ok, val} = client |> :eredis.q(["EXISTS", "key1"])
+      assert val === "0"
     end
 
     test "SPOP", %{client: client} do
@@ -739,8 +739,9 @@ defmodule RemixdbTest do
       assert val === "1"
       {:ok, val} = client |> :eredis.q(["HSET", my_hash, "name", "john"])
       assert val === "0"
+      # Adding a new key to an existing hash
       client |> :eredis.q(["HSET", my_hash, "age", "30"])
-      assert val === "1"
+      assert val === "0"
 
       {:ok, val} = client |> :eredis.q(["HLEN", my_hash])
       assert val === "2"