Skip to content

Dp24 taxon resources #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

Dp24 taxon resources #191

merged 4 commits into from
Jul 16, 2025

Conversation

DLBPointon
Copy link
Contributor

Addition of resources for BLASTN_TAXON

I have a clutch of assemblies which are all failing at this step due to memory. I've added a multiplier too so they don't end up in a constant cycle of life and death at the same mem requirement.

yumisims and others added 2 commits May 19, 2025 17:46
Addition of resources for BLASTN_TAXON

I have a clutch of assemblies which are all failing at this step due to memory. I've added a multiplier too so they don't end up in a constant cycle of life and death at the same mem requirement.
@DLBPointon DLBPointon requested review from muffato and yumisims July 16, 2025 16:02
@DLBPointon DLBPointon self-assigned this Jul 16, 2025
@DLBPointon DLBPointon added the enhancement Improvement of the existing features label Jul 16, 2025
@sanger-tolsoft
Copy link
Contributor

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link

github-actions bot commented Jul 16, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 118e8ca

+| ✅ 187 tests passed       |+
#| ❔  28 tests were ignored |#
!| ❗  19 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_dark.png
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml
  • template_strings - template_strings
  • merge_markers - merge_markers

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.1
  • Run at 2025-07-16 18:28:52

Damon should use his eyes more
Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you combine with BLAST_BLASTN and use the same rule for both ?

Update based on comments from @muffato
@DLBPointon
Copy link
Contributor Author

Can you combine with BLAST_BLASTN and use the same rule for both ?

Done

@yumisims yumisims merged commit da0ed54 into dev Jul 16, 2025
5 checks passed
@yumisims yumisims deleted the dp24-TAXON-resources branch July 16, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of the existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants