EXODUS: sprintf -> snprintf conversion

Author: gdsjaar

packages/seacas/libraries/exodus/src/ex_field_utils.c

@@ -76,7 +76,7 @@ const char *ex_component_field_name(ex_field *field, int component[EX_MAX_FIELD_
   }
 
   // Build up name incrementally which makes it easier to handle an empty component_separator...
-  sprintf(field_name, "%s", field->name);
+  snprintf(field_name, EX_MAX_NAME + 1, "%s", field->name);
 
   for (int i = 0; i < field->nesting; i++) {
     if (field->component_separator[i]) {
@@ -332,8 +332,8 @@ const char *ex_field_component_suffix(ex_field *field, int nest_level, int compo
     static char user_suffix[32];
     static char format[8];
     int         width = number_width(field->cardinality[nest_level]);
-    sprintf(format, "%c%d%dd", '%', 0, width);
-    sprintf(user_suffix, format, component);
+    snprintf(format, 8, "%c%d%dd", '%', 0, width);
+    snprintf(user_suffix, 32, format, component);
     return user_suffix;
   }
 
@@ -343,8 +343,8 @@ const char *ex_field_component_suffix(ex_field *field, int nest_level, int compo
     static char user_suffix[32];
     static char format[8];
     int         width = number_width(field->cardinality[nest_level]);
-    sprintf(format, "%c%d%dd", '%', 0, width);
-    sprintf(user_suffix, format, component - 1);
+    snprintf(format, 8, "%c%d%dd", '%', 0, width);
+    snprintf(user_suffix, 32, format, component - 1);
     return user_suffix;
   }
 

packages/seacas/libraries/exodus/src/ex_put_field_metadata.c

@@ -79,7 +79,7 @@ int ex_put_field_metadata(int exoid, const ex_field field)
   int          status         = 0;
   static char *field_template = "Field@%s@%s";
   char         attribute_name[NC_MAX_NAME + 1];
-  sprintf(attribute_name, field_template, field.name, "type");
+  snprintf(attribute_name, NC_MAX_NAME + 1, field_template, field.name, "type");
   if ((status = ex_put_integer_attribute(exoid, field.entity_type, field.entity_id, attribute_name,
                                          field.nesting, field.type)) != EX_NOERR) {
     exi_persist_leavedef(exoid, __func__);
@@ -89,7 +89,7 @@ int ex_put_field_metadata(int exoid, const ex_field field)
 
   /* Do not write if empty... */
   if (field.type_name[0] != '\0') {
-    sprintf(attribute_name, field_template, field.name, "type_name");
+    snprintf(attribute_name, NC_MAX_NAME + 1, field_template, field.name, "type_name");
     if ((status = ex_put_text_attribute(exoid, field.entity_type, field.entity_id, attribute_name,
                                         field.type_name)) != EX_NOERR) {
       exi_persist_leavedef(exoid, __func__);
@@ -100,7 +100,7 @@ int ex_put_field_metadata(int exoid, const ex_field field)
 
   /* Default component_separator is '_'.  Avoid writing if that is what it is... */
   if (field.component_separator[0] != '_' || field.nesting > 1) {
-    sprintf(attribute_name, field_template, field.name, "separator");
+    snprintf(attribute_name, NC_MAX_NAME + 1, field_template, field.name, "separator");
     if ((status = ex_put_text_attribute(exoid, field.entity_type, field.entity_id, attribute_name,
                                         field.component_separator)) != EX_NOERR) {
       exi_persist_leavedef(exoid, __func__);
@@ -117,7 +117,7 @@ int ex_put_field_metadata(int exoid, const ex_field field)
     }
   }
   if (needs_cardinality) {
-    sprintf(attribute_name, field_template, field.name, "cardinality");
+    snprintf(attribute_name, NC_MAX_NAME + 1, field_template, field.name, "cardinality");
     if ((status = ex_put_integer_attribute(exoid, field.entity_type, field.entity_id,
                                            attribute_name, field.nesting, field.cardinality)) !=
         EX_NOERR) {
@@ -138,7 +138,7 @@ int exi_put_type_attribute(int exoid, const char *att_root, const char *name, co
   if (entry != NULL) {
     static char *template = "%s@%s@%s";
     char attribute_name[NC_MAX_NAME + 1];
-    sprintf(attribute_name, template, att_root, name, type);
+    snprintf(attribute_name, NC_MAX_NAME + 1, template, att_root, name, type);
     if (value_type == EX_INTEGER) {
       status = ex_put_integer_attribute(exoid, EX_GLOBAL, 0, attribute_name, cardinality, entry);
     }
@@ -329,7 +329,7 @@ int ex_put_field_suffices(int exoid, const ex_field field, const char *suffices)
     return EX_FATAL;
   }
 
-  sprintf(attribute_name, field_template, field.name, "suffices");
+  snprintf(attribute_name, NC_MAX_NAME + 1, field_template, field.name, "suffices");
   if ((status = ex_put_text_attribute(exoid, field.entity_type, field.entity_id, attribute_name,
                                       suffices)) != EX_NOERR) {
     snprintf(errmsg, MAX_ERR_LENGTH,

packages/seacas/libraries/exodus/test/testwt-field-metadata.c

@@ -82,7 +82,7 @@ int main(int argc, char **argv)
   /* Write element block names */
   for (int i = 0; i < num_elem_blk; i++) {
     char block_names[32];
-    sprintf(block_names, "block_%c", i + 'A');
+    snprintf(block_names, 32, "block_%c", i + 'A');
     EXCHECK(ex_put_name(exoid, EX_ELEM_BLOCK, blocks[i].id, block_names));
   }