Merge branch 'master' into coverity

gsjaardema · gsjaardema · commit 6cf9369998f8 · 2025-05-03T09:04:08.000-06:00
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -50,7 +50,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@28deaeda66b76a05916b6923827895f2b14ab387 # v3.28.16
+        uses: github/codeql-action/init@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -60,7 +60,7 @@ jobs:
       # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
       - name: Autobuild
-        uses: github/codeql-action/autobuild@28deaeda66b76a05916b6923827895f2b14ab387 # v3.28.16
+        uses: github/codeql-action/autobuild@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -73,6 +73,6 @@ jobs:
       #   ./location_of_script_within_repo/buildscript.sh
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@28deaeda66b76a05916b6923827895f2b14ab387 # v3.28.16
+        uses: github/codeql-action/analyze@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
         with:
           category: "/language:${{matrix.language}}"
diff --git a/.github/workflows/scorecards.yml b/.github/workflows/scorecards.yml
@@ -71,6 +71,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@28deaeda66b76a05916b6923827895f2b14ab387 # v3.28.16
+        uses: github/codeql-action/upload-sarif@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
         with:
           sarif_file: results.sarif
diff --git a/packages/seacas/applications/ejoin/EJoin.C b/packages/seacas/applications/ejoin/EJoin.C
@@ -215,7 +215,7 @@ int main(int argc, char *argv[])
       if (dbi[p]->int_byte_size_api() > int_byte_size) {
         int_byte_size = dbi[p]->int_byte_size_api();
       }
-      dbi[p]->set_lower_case_database_names(false);
+      dbi[p]->set_lowercase_database_names(false);
     }
 
     for (size_t p = 0; p < interFace.inputFiles_.size(); p++) {
diff --git a/packages/seacas/applications/exomatlab/exomatlab.C b/packages/seacas/applications/exomatlab/exomatlab.C
@@ -114,7 +114,7 @@ namespace {
     }
 
     dbi->set_field_separator(interFace.field_suffix());
-    dbi->set_lower_case_variable_names(false);
+    dbi->set_lowercase_variable_names(false);
 
     // NOTE: 'region' owns 'db' pointer at this time...
     Ioss::Region region(dbi, "region_1");
diff --git a/packages/seacas/applications/slice/Slice.C b/packages/seacas/applications/slice/Slice.C
@@ -397,7 +397,7 @@ int main(int argc, char *argv[])
     dbi->set_int_byte_size_api(Ioss::USE_INT64_API);
   }
 
-  dbi->set_lower_case_database_names(false);
+  dbi->set_lowercase_database_names(false);
   dbi->set_surface_split_type(Ioss::SPLIT_BY_DONT_SPLIT);
   dbi->set_field_separator(0);
 
diff --git a/packages/seacas/libraries/ioss/src/Ioss_DatabaseIO.C b/packages/seacas/libraries/ioss/src/Ioss_DatabaseIO.C
@@ -346,6 +346,10 @@ namespace Ioss {
       }
     }
 
+    Utils::check_set_bool_property(properties, "LOWERCASE_VARIABLE_NAMES", lowerCaseVariableNames);
+    Utils::check_set_bool_property(properties, "LOWERCASE_DATABASE_NAMES", lowerCaseDatabaseNames);
+
+    // Not sure why I spelled it this way...
     Utils::check_set_bool_property(properties, "LOWER_CASE_VARIABLE_NAMES", lowerCaseVariableNames);
     Utils::check_set_bool_property(properties, "LOWER_CASE_DATABASE_NAMES", lowerCaseDatabaseNames);
     Utils::check_set_bool_property(properties, "USE_GENERIC_CANONICAL_NAMES",
diff --git a/packages/seacas/libraries/ioss/src/Ioss_DatabaseIO.h b/packages/seacas/libraries/ioss/src/Ioss_DatabaseIO.h
@@ -526,11 +526,23 @@ namespace Ioss {
       return duplicateFieldBehavior;
     }
 
+    void set_lowercase_variable_names(bool true_false) const
+    {
+      lowerCaseVariableNames = true_false;
+    }
+
+    void set_lowercase_database_names(bool true_false) const
+    {
+      lowerCaseDatabaseNames = true_false;
+    }
+
+    // Retain for backward compatibility
     void set_lower_case_variable_names(bool true_false) const
     {
       lowerCaseVariableNames = true_false;
     }
 
+    // Retain for backward compatibility
     void set_lower_case_database_names(bool true_false) const
     {
       lowerCaseDatabaseNames = true_false;
diff --git a/packages/seacas/libraries/ioss/src/Ioss_Doxygen.h b/packages/seacas/libraries/ioss/src/Ioss_Doxygen.h
@@ -46,8 +46,8 @@ par_cgns         | Input/Output  | alias for parallel CGNS
   Property | Value    | Description
  ----------|:--------:|------------
  LOGGING   | on/[off] | enable/disable logging of field input/output
- LOWER_CASE_VARIABLE_NAMES | [on]/off | Convert all variable names read from input database to lowercase; replace ' ' with '_'
- LOWER_CASE_DATABASE_NAMES | on/[off] | Convert all block/set names read from input database to lowercase; replace ' ' with '_'
+ LOWERCASE_VARIABLE_NAMES | [on]/off | Convert all variable names read from input database to lowercase; replace ' ' with '_'
+ LOWERCASE_DATABASE_NAMES | on/[off] | Convert all block/set names read from input database to lowercase; replace ' ' with '_'
  USE_GENERIC_CANONICAL_NAMES | on/[off]  | use `block_{id}` as canonical name of an element block instead of the name (if any) stored on the database. The database name will be an alias.
  IGNORE_DATABASE_NAMES | on/[off] | Do not read any element block, nodeset, ... names if they exist on the database.  Use only the canonical generated names (entitytype + _ + id)
  IGNORE_ATTRIBUTE_NAMES   | on/[off] | Do not read the attribute names that may exist on an input database. Instead for an element block with N attributes, the fields will be named `attribute_1` ... `attribute_N`
@@ -131,6 +131,11 @@ PARALLEL_IO_MODE | netcdf4, hdf5, pnetcdf, (mpiio and mpiposix are deprecated)
  CYCLE_COUNT           | {cycle}  | If using FILE_PER_STATE, then use {cycle} different files and then overwrite. Otherwise, there will be a maximum of {cycle} time steps in the file. See below.
  OVERLAY_COUNT         | {overlay}| If using FILE_PER_STATE, then put {overlay} timesteps worth of data into each file before going to next file. Otherwise, each output step in the file will be overwritten {overlay} times. See below.
  ENABLE_DATAWARP       | on/[off] | If the system supports Cray DataWarp (burst buffer), should it be used for buffering output files.
+## Deprecated Database-Related Properties
+ Property        | Value  | Description
+-----------------|:------:|-----------------------------------------------------------
+ LOWER_CASE_VARIABLE_NAMES | [on]/off | Use LOWERCASE_VARIABLE_NAMES
+ LOWER_CASE_DATABASE_NAMES | on/[off] | Use LOWERCASE_DATABASE_NAMES
 
 ### Cycle and Overlay Behavior:
 (Properties `CYCLE_COUNT`, `OVERLAY_COUNT`, and `FILE_PER_STATE`)
@@ -225,7 +230,7 @@ throughout the file.
  ENABLE_TRACING | on/[off] | show memory and elapsed time during some IOSS calls (mainly decomp).
  DECOMP_SHOW_PROGRESS | on/[off] | use `ENABLE_TRACING`.
  DECOMP_SHOW_HWM      | on/[off] | show high-water memory during autodecomp
- IOSS_TIME_FILE_OPEN_CLOSE | on/[off] | show elapsed time during parallel-io file open/close/create
+ IOSS_TIME_FILE_OPEN_CLOSE | on/[off] | show elapsed time during parallel-io file open/close/create/flush
  CHECK_PARALLEL_CONSISTENCY | on/[off] | check Ioss::GroupingEntity parallel consistency
  TIME_STATE_INPUT_OUTPUT | on/[off] | show the elapsed time for reading/writing each timestep's data
 
diff --git a/packages/seacas/libraries/ioss/src/exodus/Ioex_Utils.C b/packages/seacas/libraries/ioss/src/exodus/Ioex_Utils.C
@@ -658,7 +658,7 @@ namespace Ioex {
   }
 
   std::string get_entity_name(int exoid, ex_entity_type type, int64_t id,
-                              const std::string &basename, int length, bool lower_case_names,
+                              const std::string &basename, int length, bool lowercase_names,
                               bool &db_has_name)
   {
     std::vector<char> buffer(length + 1);
@@ -669,7 +669,7 @@ namespace Ioex {
     }
     if (buffer[0] != '\0') {
       std::string name{Data(buffer)};
-      if (lower_case_names) {
+      if (lowercase_names) {
         Ioss::Utils::fixup_name(name);
       }
       // Filter out names of the form "basename_id" if the name
diff --git a/packages/seacas/libraries/ioss/src/exodus/Ioex_Utils.h b/packages/seacas/libraries/ioss/src/exodus/Ioex_Utils.h
@@ -126,7 +126,7 @@ namespace Ioex {
 
   IOSS_NODISCARD IOEX_EXPORT std::string get_entity_name(int exoid, ex_entity_type type, int64_t id,
                                                          const std::string &basename, int length,
-                                                         bool lower_case_names, bool &db_has_name);
+                                                         bool lowercase_names, bool &db_has_name);
 
   IOEX_EXPORT bool filter_node_list(Ioss::Int64Vector                &nodes,
                                     const std::vector<unsigned char> &node_connectivity_status);
diff --git a/packages/seacas/libraries/ioss/src/main/io_info.C b/packages/seacas/libraries/ioss/src/main/io_info.C
@@ -709,8 +709,8 @@ namespace Ioss {
       dbi->set_use_generic_canonical_name(true);
     }
 
-    dbi->set_lower_case_variable_names(false);
-    dbi->set_lower_case_database_names(false);
+    dbi->set_lowercase_variable_names(false);
+    dbi->set_lowercase_database_names(false);
 
     if (interFace.surface_split_scheme() != Ioss::SPLIT_INVALID) {
       dbi->set_surface_split_type(Ioss::int_to_surface_split(interFace.surface_split_scheme()));
diff --git a/packages/seacas/libraries/ioss/src/main/io_modify.C b/packages/seacas/libraries/ioss/src/main/io_modify.C
@@ -524,7 +524,7 @@ namespace {
     if (dbi == nullptr || !dbi->ok(true)) {
       std::exit(EXIT_FAILURE);
     }
-    dbi->set_lower_case_database_names(false);
+    dbi->set_lowercase_database_names(false);
   }
 
   void handle_help(const std::string &topic)
diff --git a/packages/seacas/libraries/ioss/src/main/io_shell.C b/packages/seacas/libraries/ioss/src/main/io_shell.C
@@ -272,10 +272,10 @@ namespace {
       if (mem_stats) {
         dbi->progress("Database Creation");
       }
-      if (!interFace.lower_case_variable_names) {
-        dbi->set_lower_case_variable_names(false);
+      if (!interFace.lowercase_variable_names) {
+        dbi->set_lowercase_variable_names(false);
       }
-      dbi->set_lower_case_database_names(interFace.lower_case_database_names);
+      dbi->set_lowercase_database_names(interFace.lowercase_database_names);
 
       if (interFace.outFiletype == "cgns") {
         // CGNS stores BCs (SideSets) on the zones which
@@ -557,10 +557,10 @@ namespace {
     if (mem_stats) {
       dbi1->progress("Database #1 Open");
     }
-    if (!interFace.lower_case_variable_names) {
-      dbi1->set_lower_case_variable_names(false);
+    if (!interFace.lowercase_variable_names) {
+      dbi1->set_lowercase_variable_names(false);
     }
-    dbi1->set_lower_case_database_names(interFace.lower_case_database_names);
+    dbi1->set_lowercase_database_names(interFace.lowercase_database_names);
 
     if (interFace.outFiletype == "cgns") {
       // CGNS stores BCs (SideSets) on the zones which
@@ -602,10 +602,10 @@ namespace {
     if (mem_stats) {
       dbi2->progress("Database #2 Open");
     }
-    if (!interFace.lower_case_variable_names) {
-      dbi2->set_lower_case_variable_names(false);
+    if (!interFace.lowercase_variable_names) {
+      dbi2->set_lowercase_variable_names(false);
     }
-    dbi2->set_lower_case_database_names(interFace.lower_case_database_names);
+    dbi2->set_lowercase_database_names(interFace.lowercase_database_names);
 
     if (interFace.outFiletype == "cgns") {
       // CGNS stores BCs (SideSets) on the zones which
diff --git a/packages/seacas/libraries/ioss/src/main/io_shell_ts.C b/packages/seacas/libraries/ioss/src/main/io_shell_ts.C
@@ -220,8 +220,8 @@ namespace {
       if (mem_stats) {
         dbi->progress("Database Creation");
       }
-      if (!interFace.lower_case_variable_names) {
-        dbi->set_lower_case_variable_names(false);
+      if (!interFace.lowercase_variable_names) {
+        dbi->set_lowercase_variable_names(false);
       }
       dbi->set_surface_split_type(Ioss::int_to_surface_split(interFace.surface_split_type));
       dbi->set_field_separator(interFace.fieldSuffixSeparator);
diff --git a/packages/seacas/libraries/ioss/src/main/shell_interface.C b/packages/seacas/libraries/ioss/src/main/shell_interface.C
@@ -338,11 +338,14 @@ void IOShell::Interface::enroll_options()
                   nullptr);
 
   options_.enroll(
-      "lower_case_database_names", Ioss::GetLongOption::OptType::NoValue,
+      "lowercase_database_names", Ioss::GetLongOption::OptType::NoValue,
       "Lowercase all block/set/assembly names and replace spaces with underscores.\n"
       "\t\tBy default, block/set/assembly names are left as they appear in the input mesh file",
       nullptr);
 
+  options_.enroll("lower_case_database_names", Ioss::GetLongOption::OptType::NoValue,
+                  "[Deprecated] Use lowercase_database_names", nullptr);
+
   options_.enroll("retain_empty_blocks", Ioss::GetLongOption::OptType::NoValue,
                   "If any empty element blocks on input file, keep them and write to output file.\n"
                   "\t\tDefault is to ignore empty blocks.",
@@ -677,8 +680,9 @@ bool IOShell::Interface::parse_options(int argc, char **argv, int my_processor)
   in_memory_read            = (options_.retrieve("memory_read") != nullptr);
   in_memory_write           = (options_.retrieve("memory_write") != nullptr);
   delete_timesteps          = (options_.retrieve("delete_timesteps") != nullptr);
-  lower_case_variable_names = (options_.retrieve("native_variable_names") == nullptr);
-  lower_case_database_names = (options_.retrieve("lower_case_database_names") != nullptr);
+  lowercase_variable_names  = (options_.retrieve("native_variable_names") == nullptr);
+  lowercase_database_names  = (options_.retrieve("lowercase_database_names") != nullptr);
+  lowercase_database_names  = (options_.retrieve("lower_case_database_names") != nullptr);
   disable_field_recognition = (options_.retrieve("disable_field_recognition") != nullptr);
   retain_empty_blocks       = (options_.retrieve("retain_empty_blocks") != nullptr);
   boundary_sideset          = (options_.retrieve("boundary_sideset") != nullptr);
diff --git a/packages/seacas/libraries/ioss/src/main/shell_interface.h b/packages/seacas/libraries/ioss/src/main/shell_interface.h
@@ -103,8 +103,8 @@ namespace IOShell {
     bool quiet{false};
     bool in_memory_read{false};
     bool in_memory_write{false};
-    bool lower_case_variable_names{false};
-    bool lower_case_database_names{false};
+    bool lowercase_variable_names{false};
+    bool lowercase_database_names{false};
     bool delete_timesteps{false};
     bool minimize_open_files{false};
     bool disable_field_recognition{false};
diff --git a/packages/seacas/libraries/ioss/src/main/skinner.C b/packages/seacas/libraries/ioss/src/main/skinner.C
@@ -207,7 +207,7 @@ namespace {
       dbi->set_int_byte_size_api(Ioss::USE_INT64_API);
     }
 
-    dbi->set_lower_case_database_names(false);
+    dbi->set_lowercase_database_names(false);
 
     // NOTE: 'region' owns 'db' pointer at this time...
     Ioss::Region region(dbi, "region_1");
diff --git a/packages/seacas/libraries/ioss/src/main/struc_to_unstruc.C b/packages/seacas/libraries/ioss/src/main/struc_to_unstruc.C
@@ -139,7 +139,7 @@ namespace {
       std::exit(EXIT_FAILURE);
     }
 
-    dbi->set_lower_case_database_names(false);
+    dbi->set_lowercase_database_names(false);
 
     // NOTE: 'region' owns 'db' pointer at this time...
     Ioss::Region region(dbi, "region_1");
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshAssembly.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshAssembly.h
@@ -202,7 +202,7 @@ namespace Iotm {
     private:
       void parse_option(std::string optionName, const std::string &optionValue)
       {
-        convert_to_lower_case(optionName);
+        convert_to_lowercase(optionName);
 
         if (optionName == "name") {
           parse_name(optionValue);
@@ -239,7 +239,7 @@ namespace Iotm {
 
       void parse_assembly_type(std::string type)
       {
-        convert_to_lower_case(type);
+        convert_to_lowercase(type);
 
         if (type == "assembly") {
           m_assemblyType = ASSEMBLY;
@@ -264,7 +264,7 @@ namespace Iotm {
       {
         std::vector<std::string> assemblyData = get_tokens(data, ",");
         for (std::string &member : assemblyData) {
-          convert_to_upper_case(member);
+          convert_to_uppercase(member);
         }
 
         m_members = assemblyData;
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshEntityGroup.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshEntityGroup.h
@@ -124,7 +124,7 @@ namespace Iotm {
 
       const GroupData *get_group_data(std::string name) const
       {
-        convert_to_upper_case(name);
+        convert_to_uppercase(name);
         if (is_registered(name)) {
           return &m_groupDataVec[m_groupDataMap[name]];
         }
@@ -170,7 +170,7 @@ namespace Iotm {
       {
         GroupData &groupData = m_groupDataVec[index];
 
-        convert_to_upper_case(groupData.name);
+        convert_to_uppercase(groupData.name);
         validate_group_meta_data(groupData);
 
         m_partNames.push_back(groupData.name);
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshFuncs.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshFuncs.h
@@ -93,12 +93,12 @@ namespace Iotm {
       return tokens;
     }
 
-    inline void convert_to_upper_case(std::string &str)
+    inline void convert_to_uppercase(std::string &str)
     {
       std::transform(str.begin(), str.end(), str.begin(), ::toupper);
     }
 
-    inline void convert_to_lower_case(std::string &str)
+    inline void convert_to_lowercase(std::string &str)
     {
       std::transform(str.begin(), str.end(), str.begin(), ::tolower);
     }
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshNodeset.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshNodeset.h
@@ -83,7 +83,7 @@ namespace Iotm {
     private:
       void parse_option(std::string optionName, const std::string &optionValue)
       {
-        convert_to_lower_case(optionName);
+        convert_to_lowercase(optionName);
 
         if (optionName == "name") {
           parse_name(optionValue);
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshSideset.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshSideset.h
@@ -173,7 +173,7 @@ namespace Iotm {
     private:
       void parse_option(std::string optionName, const std::string &optionValue)
       {
-        convert_to_lower_case(optionName);
+        convert_to_lowercase(optionName);
 
         if (optionName == "name") {
           parse_name(optionValue);
@@ -240,7 +240,7 @@ namespace Iotm {
 
       void parse_split_type(std::string splitName)
       {
-        convert_to_lower_case(splitName);
+        convert_to_lowercase(splitName);
 
         if (splitName == "none") {
           m_splitType = NO_SPLIT;
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshSidesetSplitter.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshSidesetSplitter.h
@@ -216,7 +216,7 @@ namespace Iotm {
       void fill_split_data(std::string key, size_t index,
                            const ElementData<EntityId, Topology> &elemData, int side)
       {
-        convert_to_upper_case(key);
+        convert_to_uppercase(key);
 
         SplitData &splitData = m_splitMap[key];
 
diff --git a/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshUtils.h b/packages/seacas/libraries/ioss/src/text_mesh/Iotm_TextMeshUtils.h

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ int main(int argc, char *argv[])`
`215`	`215`	`if (dbi[p]->int_byte_size_api() > int_byte_size) {`
`216`	`216`	`int_byte_size = dbi[p]->int_byte_size_api();`
`217`	`217`	`}`
`218`		`- dbi[p]->set_lower_case_database_names(false);`
	`218`	`+ dbi[p]->set_lowercase_database_names(false);`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`for (size_t p = 0; p < interFace.inputFiles_.size(); p++) {`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ namespace {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`dbi->set_field_separator(interFace.field_suffix());`
`117`		`- dbi->set_lower_case_variable_names(false);`
	`117`	`+ dbi->set_lowercase_variable_names(false);`
`118`	`118`
`119`	`119`	`// NOTE: 'region' owns 'db' pointer at this time...`
`120`	`120`	`Ioss::Region region(dbi, "region_1");`
Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ int main(int argc, char *argv[])`
`397`	`397`	`dbi->set_int_byte_size_api(Ioss::USE_INT64_API);`
`398`	`398`	`}`
`399`	`399`
`400`		`- dbi->set_lower_case_database_names(false);`
	`400`	`+ dbi->set_lowercase_database_names(false);`
`401`	`401`	`dbi->set_surface_split_type(Ioss::SPLIT_BY_DONT_SPLIT);`
`402`	`402`	`dbi->set_field_separator(0);`
`403`	`403`
Original file line number	Diff line number	Diff line change
`@@ -346,6 +346,10 @@ namespace Ioss {`
`346`	`346`	`}`
`347`	`347`	`}`
`348`	`348`
	`349`	`+ Utils::check_set_bool_property(properties, "LOWERCASE_VARIABLE_NAMES", lowerCaseVariableNames);`
	`350`	`+ Utils::check_set_bool_property(properties, "LOWERCASE_DATABASE_NAMES", lowerCaseDatabaseNames);`
	`351`	`+`
	`352`	`+ // Not sure why I spelled it this way...`
`349`	`353`	`Utils::check_set_bool_property(properties, "LOWER_CASE_VARIABLE_NAMES", lowerCaseVariableNames);`
`350`	`354`	`Utils::check_set_bool_property(properties, "LOWER_CASE_DATABASE_NAMES", lowerCaseDatabaseNames);`
`351`	`355`	`Utils::check_set_bool_property(properties, "USE_GENERIC_CANONICAL_NAMES",`
Original file line number	Diff line number	Diff line change
`@@ -526,11 +526,23 @@ namespace Ioss {`
`526`	`526`	`return duplicateFieldBehavior;`
`527`	`527`	`}`
`528`	`528`
	`529`	`+ void set_lowercase_variable_names(bool true_false) const`
	`530`	`+ {`
	`531`	`+ lowerCaseVariableNames = true_false;`
	`532`	`+ }`
	`533`	`+`
	`534`	`+ void set_lowercase_database_names(bool true_false) const`
	`535`	`+ {`
	`536`	`+ lowerCaseDatabaseNames = true_false;`
	`537`	`+ }`
	`538`	`+`
	`539`	`+ // Retain for backward compatibility`
`529`	`540`	`void set_lower_case_variable_names(bool true_false) const`
`530`	`541`	`{`
`531`	`542`	`lowerCaseVariableNames = true_false;`
`532`	`543`	`}`
`533`	`544`
	`545`	`+ // Retain for backward compatibility`
`534`	`546`	`void set_lower_case_database_names(bool true_false) const`
`535`	`547`	`{`
`536`	`548`	`lowerCaseDatabaseNames = true_false;`
Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ namespace Ioex {`
`658`	`658`	`}`
`659`	`659`
`660`	`660`	`std::string get_entity_name(int exoid, ex_entity_type type, int64_t id,`
`661`		`- const std::string &basename, int length, bool lower_case_names,`
	`661`	`+ const std::string &basename, int length, bool lowercase_names,`
`662`	`662`	`bool &db_has_name)`
`663`	`663`	`{`
`664`	`664`	`std::vector<char> buffer(length + 1);`
`@@ -669,7 +669,7 @@ namespace Ioex {`
`669`	`669`	`}`
`670`	`670`	`if (buffer[0] != '\0') {`
`671`	`671`	`std::string name{Data(buffer)};`
`672`		`- if (lower_case_names) {`
	`672`	`+ if (lowercase_names) {`
`673`	`673`	`Ioss::Utils::fixup_name(name);`
`674`	`674`	`}`
`675`	`675`	`// Filter out names of the form "basename_id" if the name`