COVERITY: Address issues found by coverity

Author: gsjaardema

packages/seacas/applications/exodiff/exodiff.C

@@ -1,4 +1,4 @@
-// Copyright(C) 1999-, 20242024 National Technology & Engineering Solutions
+// Copyright(C) 1999-, 20242024, ,  National Technology & Engineering Solutions
 // of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
 // NTESS, the U.S. Government retains certain rights in this software.
 //
@@ -610,17 +610,24 @@ int main(int argc, char *argv[])
 
   bool diff_flag       = false;
   bool has_change_sets = false;
-  if (int_size == 4) {
-    auto diff_change = exodiff_setup(file1_name, file2_name, int(0));
-    diff_flag        = diff_change.first;
-    has_change_sets  = diff_change.second;
+  try {
+    if (int_size == 4) {
+      auto diff_change = exodiff_setup(file1_name, file2_name, int(0));
+      diff_flag        = diff_change.first;
+      has_change_sets  = diff_change.second;
+    }
+    else {
+      auto diff_change = exodiff_setup(file1_name, file2_name, int64_t(0));
+      diff_flag        = diff_change.first;
+      has_change_sets  = diff_change.second;
+    }
   }
-  else {
-    auto diff_change = exodiff_setup(file1_name, file2_name, int64_t(0));
-    diff_flag        = diff_change.first;
-    has_change_sets  = diff_change.second;
+  catch (std::exception &e) {
+    fmt::print(stderr, "\n{}\n\nEXODIFF terminated due to exception\n", e.what());
+    exit(EXIT_FAILURE);
   }
 
+
   if (has_change_sets) {
     if (diff_flag) {
       DIFF_OUT("exodiff: At least one change set is different\n");

packages/seacas/libraries/ioss/src/Ioss_ChangeSetFactory.C

@@ -1,4 +1,4 @@
-// Copyright(C) 2024 National Technology & Engineering Solutions
+// Copyright(C) 2024, 2025 National Technology & Engineering Solutions
 // of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
 // NTESS, the U.S. Government retains certain rights in this software.
 //
@@ -63,8 +63,11 @@ std::shared_ptr<Ioss::ChangeSet> Ioss::ChangeSetFactory::create(Ioss::Region *re
                          "       Was Ioss::Init::Initializer() called?\n\n");
       IOSS_ERROR(errmsg);
     }
-    else {
-      iter = registry()->find("ioss");
+    iter = registry()->find("ioss");
+    if (iter == registry()->end()) {
+      std::ostringstream errmsg;
+      fmt::print(errmsg, "ERROR: Could not locate correct change set types.\n\n");
+      IOSS_ERROR(errmsg);
     }
   }
 
@@ -89,8 +92,11 @@ std::shared_ptr<Ioss::ChangeSet> Ioss::ChangeSetFactory::create(Ioss::DatabaseIO
                          "       Was Ioss::Init::Initializer() called?\n\n");
       IOSS_ERROR(errmsg);
     }
-    else {
-      iter = registry()->find("ioss");
+    iter = registry()->find("ioss");
+    if (iter == registry()->end()) {
+      std::ostringstream errmsg;
+      fmt::print(errmsg, "ERROR: Could not locate correct change set types.\n\n");
+      IOSS_ERROR(errmsg);
     }
   }
 

packages/seacas/libraries/ioss/src/Ioss_DynamicTopologyFileControl.C

@@ -1,4 +1,4 @@
-// Copyright(C) 2024 National Technology & Engineering Solutions
+// Copyright(C) 2024, 2025 National Technology & Engineering Solutions
 // of Sandia, LLC (NTESS).  Under the terms of Contract DE-NA0003525 with
 // NTESS, the U.S. Government retains certain rights in this software.
 //
@@ -92,16 +92,19 @@ namespace {
 namespace Ioss {
 
   DynamicTopologyFileControl::DynamicTopologyFileControl(Region *region)
-      : m_region(region), m_fileCyclicCount(region->get_file_cyclic_count()),
-        m_ifDatabaseExists(region->get_if_database_exists_behavior()),
-        m_dbChangeCount(region->get_topology_change_count())
+      : m_region(region)
   {
     if (nullptr == region) {
       std::ostringstream errmsg;
       fmt::print(errmsg, "ERROR: null region passed in as argument to DynamicTopologyFileControl");
       IOSS_ERROR(errmsg);
     }
 
+    // If we are checking for `region == nullptr` above, we cannot 
+    // do these initializations above and must do them here...
+    m_fileCyclicCount = region->get_file_cyclic_count();
+    m_ifDatabaseExists = region->get_if_database_exists_behavior();
+    m_dbChangeCount = region->get_topology_change_count();
     m_ioDB   = region->get_property("base_filename").get_string();
     m_dbType = region->get_property("database_type").get_string();
   }