-
Notifications
You must be signed in to change notification settings - Fork 5
patch: Sign semantic release commits/tags #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideInjects SSH-based signing into the python-semantic-release CI step by supplying committer identity and signing keys via GitHub Actions inputs and repository secrets. Sequence Diagram: Commit and Tag Signing by python-semantic-releasesequenceDiagram
participant WF as GitHub Actions Workflow
participant PSR as python-semantic-release Action
participant GIT as Git Repository
WF->>PSR: Trigger release with committer_email, committer_name, ssh_private_signing_key, ssh_public_signing_key, github_token
activate PSR
PSR->>PSR: Prepare release (e.g., version bump)
PSR->>GIT: Create commit
PSR->>PSR: Sign commit using ssh_private_signing_key
PSR->>GIT: Create tag
PSR->>PSR: Sign tag using ssh_private_signing_key
PSR->>GIT: Push signed commit and tag
deactivate PSR
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 2 2
Lines 166 166
Branches 37 37
=======================================
Hits 156 156
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Type: Task
Description
This PR adds commit and tag signing to changes made by python-semantic-release in CI.
Related Issues/PRs
Thought #255 and #295 would take care of this automatically, but they didn't.
Finally figured out how to do this when researching #260.
Motivation
Signing releases means we have a better security posture.
Implementation Details
release
environment.Testing
I modified the configuration to allow python-semantic-release to create a new release commit and tag on this branch and verified that both were signed.
Summary by Sourcery
Enable commit and tag signing for releases by configuring python-semantic-release in CI to use SSH signing keys.
New Features:
CI: