Skip to content

Commit dd0a798

Browse files
committed
Fix some small warnings.
Disable building SpecFilePreview until I have some more time to get it copying into the final bundle correctly..
1 parent 2b6e5c1 commit dd0a798

File tree

5 files changed

+30
-20
lines changed

5 files changed

+30
-20
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -993,7 +993,7 @@ message( "Linking ${LINK_TO_OBJECT} to ${LIBRARIES_TO_LINK_TO}" )
993993
target_link_libraries( ${LINK_TO_OBJECT} PUBLIC ${LIBRARIES_TO_LINK_TO} )
994994

995995
if( BUILD_AS_OSX_APP )
996-
add_subdirectory( target/macOsQuickLook/SpecFilePreview/SpecFilePreview )
996+
# add_subdirectory( target/macOsQuickLook/SpecFilePreview/SpecFilePreview )
997997
endif( BUILD_AS_OSX_APP )
998998

999999
IF( BUILD_AS_UNIT_TEST_SUITE )

InterSpec/PeakSearchGuiUtils.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
class PeakDef;
4141
class PeakModel;
4242
class InterSpec;
43-
class ColorTheme;
43+
struct ColorTheme;
4444
class Measurement;
45-
class ReferenceLineInfo;
45+
struct ReferenceLineInfo;
4646
class ReferencePhotopeakDisplay;
4747

4848
namespace Wt{

src/ColorThemeWindow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ void ColorThemeWindow::uploadThemeCallback()
482482
}
483483
}) );
484484

485-
upload->fileTooLarge().connect( std::bind( [this,window,upload](){
485+
upload->fileTooLarge().connect( std::bind( [window,upload](){
486486
upload->hide();
487487
new WText( "Too Large of file.", window->contents() );
488488
}) );

src/InterSpec.cpp

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3555,19 +3555,25 @@ void InterSpec::showWelcomeDialog( bool force )
35553555
return;
35563556
}
35573557

3558-
/*
3559-
For Android, showing this useInfoWindow at startup causes some exceptions
3560-
in the JavaScript whenever the loading indicator is shown. I'm pretty
3561-
confused by it.
3562-
I tried setting a new loading indicator in deleteWelcomeCountDialog(), but it didnt work
3563-
*/
3564-
3565-
std::function<void(bool)> dontShowAgainCallback = [this](bool value){
3566-
InterSpecUser::setPreferenceValue<bool>( m_user, "ShowSplashScreen", value, this );
3567-
};
3568-
m_useInfoWindow = new UseInfoWindow( dontShowAgainCallback , this );
3558+
WServer::instance()->post( wApp->sessionId(), std::bind( [this](){
3559+
/*
3560+
For Android, showing this useInfoWindow at startup causes some exceptions
3561+
in the JavaScript whenever the loading indicator is shown. I'm pretty
3562+
confused by it.
3563+
I tried setting a new loading indicator in deleteWelcomeCountDialog(), but it didnt work
3564+
3565+
Havent checked if creating this window via "posting" helps
3566+
*/
3567+
if( m_useInfoWindow )
3568+
return;
3569+
3570+
std::function<void(bool)> dontShowAgainCallback = [this](bool value){
3571+
InterSpecUser::setPreferenceValue<bool>( m_user, "ShowSplashScreen", value, this );
3572+
};
3573+
m_useInfoWindow = new UseInfoWindow( dontShowAgainCallback , this );
35693574

3570-
m_useInfoWindow->finished().connect( this, &InterSpec::deleteWelcomeCountDialog );
3575+
m_useInfoWindow->finished().connect( this, &InterSpec::deleteWelcomeCountDialog );
3576+
} ) );
35713577
}//void showWelcomeDialog()
35723578

35733579

src/PeakDef.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2200,13 +2200,17 @@ std::string PeakDef::gaus_peaks_to_json(const std::vector<std::shared_ptr<const
22002200
}//switch( p.type() )
22012201

22022202
answer << q << "skewType" << q << ":";
2203-
switch (p.type())
2203+
switch( p.skewType() )
22042204
{
2205-
case PeakDef::NoSkew: answer << q << "NoSkew" << q << ","; break;
2206-
case PeakDef::LandauSkew: answer << q << "LandauSkew" << q << ","; break;
2205+
case PeakDef::NoSkew:
2206+
answer << q << "NoSkew" << q << ",";
2207+
break;
2208+
2209+
case PeakDef::LandauSkew:
2210+
answer << q << "LandauSkew" << q << ",";
2211+
break;
22072212
}//switch( p.type() )
22082213

2209-
22102214
for (PeakDef::CoefficientType t = PeakDef::CoefficientType(0);
22112215
t < PeakDef::NumCoefficientTypes; t = PeakDef::CoefficientType(t + 1))
22122216
{

0 commit comments

Comments
 (0)