Skip to content

Commit 9b5009b

Browse files
nvborisenkosandeepsuryaprasad
authored andcommitted
[dotnet] [bidi] Convert RemoteRefrence to an interface
1 parent 10d3fd1 commit 9b5009b

File tree

6 files changed

+11
-10
lines changed

6 files changed

+11
-10
lines changed

dotnet/src/webdriver/BiDi/Modules/BrowsingContext/CaptureScreenshotCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public abstract record ClipRectangle
6262
{
6363
public record Box(double X, double Y, double Width, double Height) : ClipRectangle;
6464

65-
public record Element([property: JsonPropertyName("element")] Script.SharedReference SharedReference) : ClipRectangle;
65+
public record Element([property: JsonPropertyName("element")] Script.ISharedReference SharedReference) : ClipRectangle;
6666
}
6767

6868
public record CaptureScreenshotResult(string Data)

dotnet/src/webdriver/BiDi/Modules/BrowsingContext/LocateNodesCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ internal record LocateNodesCommandParameters(BrowsingContext Context, Locator Lo
3333

3434
public Script.SerializationOptions? SerializationOptions { get; set; }
3535

36-
public IEnumerable<Script.SharedReference>? StartNodes { get; set; }
36+
public IEnumerable<Script.ISharedReference>? StartNodes { get; set; }
3737
}
3838

3939
public record LocateNodesOptions : CommandOptions
@@ -42,7 +42,7 @@ public record LocateNodesOptions : CommandOptions
4242

4343
public Script.SerializationOptions? SerializationOptions { get; set; }
4444

45-
public IEnumerable<Script.SharedReference>? StartNodes { get; set; }
45+
public IEnumerable<Script.ISharedReference>? StartNodes { get; set; }
4646
}
4747

4848
public record LocateNodesResult : IReadOnlyList<Script.RemoteValue.Node>

dotnet/src/webdriver/BiDi/Modules/Input/Origin.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public record Viewport() : Origin;
2929

3030
public record Pointer() : Origin;
3131

32-
public record Element([property: JsonPropertyName("element")] Script.SharedReference SharedReference) : Origin
32+
public record Element([property: JsonPropertyName("element")] Script.ISharedReference SharedReference) : Origin
3333
{
3434
public string Type { get; } = "element";
3535
}

dotnet/src/webdriver/BiDi/Modules/Script/RemoteReference.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,16 @@
2121

2222
namespace OpenQA.Selenium.BiDi.Modules.Script;
2323

24-
public abstract record RemoteReference : LocalValue;
24+
public interface IRemoteReference;
2525

26-
public record SharedReference(string SharedId) : RemoteReference
26+
public interface ISharedReference : IRemoteReference
2727
{
28+
public string SharedId { get; }
29+
2830
public Handle? Handle { get; set; }
2931
}
3032

31-
public record RemoteObjectReference(Handle Handle) : RemoteReference
33+
public record RemoteObjectReference(Handle Handle) : IRemoteReference
3234
{
3335
public string? SharedId { get; set; }
3436
}

dotnet/src/webdriver/BiDi/Modules/Script/RemoteValue.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ public record HtmlCollection : RemoteValue
246246
public IReadOnlyList<RemoteValue>? Value { get; set; }
247247
}
248248

249-
public record Node : RemoteValue
249+
public record Node : RemoteValue, ISharedReference
250250
{
251251
[JsonInclude]
252252
public string? SharedId { get; internal set; }

dotnet/test/common/BiDi/BrowsingContext/BrowsingContextTest.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,7 @@ public async Task CanCaptureScreenshotOfElement()
289289

290290
var screenshot = await context.CaptureScreenshotAsync(new()
291291
{
292-
// TODO: Seems Node implements ISharedReference
293-
Clip = new ClipRectangle.Element(new Modules.Script.SharedReference(nodes[0].SharedId))
292+
Clip = new ClipRectangle.Element(nodes[0])
294293
});
295294

296295
Assert.That(screenshot, Is.Not.Null);

0 commit comments

Comments
 (0)