Merge pull request #201 from samvera-labs/patch-fix-rendering-download

Patch fix for the rendering download button

Author: adamjarling

src/components/Viewer/Viewer/Download.test.tsx

@@ -4,6 +4,7 @@ import { render, screen } from "@testing-library/react";
 import Download from "./Download";
 import React from "react";
 import { Vault } from "@iiif/vault";
+import noRenderingManifest from "src/fixtures/viewer/rendering/manifest-without-renderings.json";
 import renderingManifest from "src/fixtures/iiif-cookbook/0046-rendering.json";
 import renderingMultipleManifest from "src/fixtures/viewer/rendering/manifest-with-renderings.json";
 import userEvent from "@testing-library/user-event";
@@ -81,4 +82,26 @@ describe("Viewer Download popover component", () => {
       screen.getByText("Download the original file (image/tiff)"),
     ).toBeInTheDocument();
   });
+
+  it("should not render the download button when no rendering items are present", async () => {
+    await vault.loadManifest("", noRenderingManifest);
+
+    render(
+      <ViewerProvider
+        initialState={{
+          ...defaultState,
+          activeManifest:
+            "https://iiif.io/api/cookbook/recipe/0046-rendering/manifest.json",
+          activeCanvas:
+            "https://iiif.io/api/cookbook/recipe/0046-rendering/canvas/p1",
+          vault,
+        }}
+      >
+        <Download />
+      </ViewerProvider>,
+    );
+
+    expect(screen.queryByTestId("download-button")).toBeNull();
+    expect(screen.queryByTestId("download-content")).toBeNull();
+  });
 });

src/components/Viewer/Viewer/Download.tsx

@@ -11,11 +11,16 @@ import useViewerDownload from "src/hooks/useViewerDownload";
 
 const ViewerDownload = () => {
   const { allPages, individualPages } = useViewerDownload();
+  const showDownloadButton = allPages.length > 0 || individualPages.length > 0;
 
   const handleDownloadClick = (id: RenderingItem["id"]) => {
     window.open(id, "_blank");
   };
 
+  if (!showDownloadButton) {
+    return null;
+  }
+
   return (
     <Popover>
       <DownloadButton data-testid="download-button">

src/fixtures/viewer/rendering/manifest-without-renderings.json

@@ -0,0 +1,51 @@
+{
+  "@context": "http://iiif.io/api/presentation/3/context.json",
+  "id": "https://iiif.io/api/cookbook/recipe/0046-rendering/manifest.json",
+  "type": "Manifest",
+  "label": {
+    "en": ["No Rendering properties"]
+  },
+  "summary": {
+    "en": ["Test"]
+  },
+  "viewingDirection": "right-to-left",
+  "items": [
+    {
+      "id": "https://iiif.io/api/cookbook/recipe/0046-rendering/canvas/p1",
+      "type": "Canvas",
+      "label": {
+        "en": ["front cover"]
+      },
+      "width": 3497,
+      "height": 4823,
+      "items": [
+        {
+          "id": "https://iiif.io/api/cookbook/recipe/0046-rendering/page/p1/1",
+          "type": "AnnotationPage",
+          "items": [
+            {
+              "id": "https://iiif.io/api/cookbook/recipe/0046-rendering/annotation/p0001-image",
+              "type": "Annotation",
+              "motivation": "painting",
+              "body": {
+                "id": "https://iiif.io/api/image/3.0/example/reference/4f92cceb12dd53b52433425ce44308c7-ucla_bib1987273_no001_rs_001/full/max/0/default.jpg",
+                "type": "Image",
+                "format": "image/jpeg",
+                "width": 3497,
+                "height": 4823,
+                "service": [
+                  {
+                    "id": "https://iiif.io/api/image/3.0/example/reference/4f92cceb12dd53b52433425ce44308c7-ucla_bib1987273_no001_rs_001",
+                    "type": "ImageService3",
+                    "profile": "level1"
+                  }
+                ]
+              },
+              "target": "https://iiif.io/api/cookbook/recipe/0046-rendering/canvas/p1"
+            }
+          ]
+        }
+      ]
+    }
+  ]
+}