Docker login additional configuration options for docker authentication

[c4t3l]

salt/salt/modules/dockermod.py

Line 1393 in 927adb3

registry_auth = __pillar__.get('docker-registries', {})

In reference to the above, would it be possible to make this function use master/minion config files as well as pillar data? I have used the "trifecta" of configuration options in other modules, but my external pillar setup does not easily support this particular configuration.

I am running salt version 2018.3.2 on Centos 7. My external pillar system is etcd.

[c4t3l]

profile = salt'config.option'

• from Cody

[dwoz]

@terminalmage What are your thoughts on this?

[c4t3l]

I would like to submit the PR for this. I will have time to do it over the weekend.

[terminalmage]

See my comments here.

[terminalmage]

Alternate implementation here: #51677

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[terminalmage]

This was fixed 11 months ago. Please close this rather than letting it be closed as "stale".

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.