Add oscodename grain to MacOS

[noelmcloughlin]

Description of Issue

The oscodename grain is absent on MacOS.
Expected values would be Sierra, High Sierra, Mojave, or whatever.

Setup

    os:
        MacOS
    os_family:
        MacOS
    osarch:
        x86_64
    osbuild:
        17G7024
    osfinger:
        Mac OS X 10.13.6-10
    osfullname:
        Mac OS X 10.13.6
    osmajorrelease:
        10
    osrelease:
        10.13.6
    osrelease_info:
        - 10
        - 13

Versions Report

/usr/local/Cellar/salt/2019.2.0_1/libexec/lib/python3.7/site-packages/salt/version.py:632: DeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5
lin_ver = linux_distribution()
Salt Version:
Salt: 2019.2.0

[weswhet]

It looks like this doesn't exist for a good reason. It's hard...

For 10.14 using the PyObjC library that comes with the 2019.2 pkg. And no guarantee this will work on 10.15

from Foundation import NSBundle
SU = NSBundle.bundleWithPath_('/System/Library/PreferencePanes/SoftwareUpdate.prefPane')
SUOSUUpToDateViewController = SU.classNamed_('SUOSUUpToDateViewController')
suo = SUOSUUpToDateViewController.alloc().initWithPreferencePaneController_(None)
suo.marketingNameString()

u'macOS Mojave'

For older Macs, this seems to work.

awk '/SOFTWARE LICENSE AGREEMENT FOR macOS/' '/System/Library/CoreServices/Setup Assistant.app/Contents/Resources/en.lproj/OSXSoftwareLicense.rtf' | awk -F 'macOS ' '{print $NF}' | awk '{print substr($0, 0, length($0))}'

ewww.

[max-arnold]

As ugly as possible:

import re

def guess_macos_codename(osrelease):
    with open(
        '/System/Library/CoreServices/Setup Assistant.app/'
        'Contents/Resources/en.lproj/OSXSoftwareLicense.html',
        'r'
    ) as fp:
        v = re.search(
            'SOFTWARE\s+LICENSE\s+AGREEMENT\s+FOR\s+(OS\s+X|macOS)\s+([^<]+)',
            fp.read()
        )
    return v.group(2) if v and len(v.groups()) == 2 else 'UNKNOWN'

# TODO: if someone wants to write a couple of tests, please make sure that one of them
# fails when a version is missing in the lookup map. It will help a maintainer to
# keep the map up to date.

def oscodename(osrelease):
    oscodemap = {
        '0': 'Cheetah',
        '1': 'Puma',
        '2': 'Jaguar',
        '3': 'Panther',
        '4': 'Tiger',
        '5': 'Leopard',
        '6': 'Snow Leopard',
        '7': 'Lion',
        '8': 'Mountain Lion',
        '9': 'Mavericks',
        '10': 'Yosemite',
        '11': 'El Capitan',
        '12': 'Sierra',
        '13': 'High Sierra',
        '14': 'Mojave',
        '15': 'Catalina',
    }
    v = osrelease.split('.')
    if len(v) >= 2 and v[0] == '10' and v[1] in oscodemap:
        return oscodemap[v[1]]
    return guess_macos_codename(osrelease)

print(oscodename('10.14.1'))
print(oscodename('10.15.0'))

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[Akm0d]

Implemented in "pop_darwin", grains from there will be used in salt for Sodium release:
https://gitlab.com/saltstack/pop/pop_darwin/-/blob/master/pop_darwin/corn/os/sw_vers.py
based it on the information in:
https://support.apple.com/en-us/HT201260

[sagetherage]

since this is in GitLab @Akm0d should we move the issue there, or will there be work in the salt code base, too and thus keeping this in this repo for Magnesium?