kubernetes.secret_present should allow type parameter

[jodok]

Description of Issue/Question

unfortunately the type parameter for a kubernetes secret can't be specified when using the secret_present state. therefor the type of the secret will always be opaque. but e.g. to specify an ImagePullSecret you need the type . dockerconfigjson.

(the python client supports it: https://github.com/kubernetes-client/python/blob/master/kubernetes/client/models/v1_secret.py#L204)

Versions Report

salt 2017.7.3

[Ch3LL]

looks like we are only passing data and metadata shown here: https://github.com/saltstack/salt/blob/v2017.7.3/salt/modules/kubernetes.py#L1073-L1075

seems a very reasonable thing to add. Want to give a go at a PR?

[hbokh]

This has not been added / fixed in 2018.3.3 nor 2019.2, right?

https://github.com/saltstack/salt/blob/v2018.3/salt/modules/kubernetes.py#L1089-L1091

[Ch3LL]

yeah anyone else is welcome to push a PR for this :) would very much welcome that

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.