Have an alias to use dryrun=True instead of test=True

[arthurzenika]

Description of Issue/Question

Some new salt users I came across told me that the test=True could be confusing and would prefer to have a more standard dryrun terminology for what test=True does in salt. I thought I'd start the discussion here about having an alias that does this.

Is it technically difficult to have an alias for dryrun=test which adds test=True early enough to provide such a functionality ?

Doing a grep for dryrun in the code I find that some states already use this argument so if we go down that road we need to make sure they don't break (pkgng, rsync, dockermod)

[garethgreenaway]

@thatch45 Would you weighing in on this one?

[thatch45]

dryrun or dry_run or no-op etc would all be good options here. All we would need to do to add an alias is just take the argument to state.apply/highstate/sls/high/low/pkg/top/sls_id functions, would be to add this:

def apply(mods=None, **kwargs):
    if 'dryrun' in kwargs:
        kwargs['test'] = kwargs.pop('dryrun')

then it would be 100% safe, the trick would be to pop the key from the kwargs

[garethgreenaway]

@thatch45 Thanks! Adding the Feature label.

[thatch45]

Yes, this is something that would take all of 15 minutes to add and we should have added it long ago

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[arthurzenika]

up

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[arthurzenika]

up

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.