[BUG] pkg.uptodate(dist_upgrade=True) with zypper may miss updates

[JanZerebecki]

Description
pkg.uptodate(dist_upgrade=True) with zypper may miss updates as zypperpkg.list_upgrades does not implement dist_upgrade, so only considers normal upgrade. This is not a documented kwarg, but it does work for other implementations, like apt. See uptodate

salt/salt/states/pkg.py

Line 3244 in dc0595c

packages = __salt__["pkg.list_upgrades"](refresh=refresh, **kwargs)

and compare

salt/salt/modules/zypperpkg.py

Line 517 in dc0595c

def list_upgrades(refresh=True, root=None, **kwargs):

with

salt/salt/modules/aptpkg.py

Line 1435 in dc0595c

def list_upgrades(refresh=True, dist_upgrade=True, **kwargs):

.

Setup
(Please provide relevant configs and/or SLS files (be sure to remove sensitive info).
Tested on openSUSE.

pkgs-dist-upgraded:
  pkg.uptodate:
    - refresh: True
    - dist_upgrade: True

Steps to Reproduce the behavior
Create a situation where upgrade and dist-upgrade would do different things. Would probably happen when you install Leap 15.1 and change to 15.2 repos. Then apply state.

Expected behavior
Do the same as zypper dist-upgrade.

Versions Report
Verified in source on master, see links to source above.

[cmcmarrow]

@JanZerebecki if zypperpkg had dist_upgrade I would say this is a consistency problem. But zypperpkg does not have this arg because its has not been implemented. So I believe this to be a feature request more then a bug. I also think the documentation should be updated until the feature is add it.

[sagetherage]

this sounds like two tickets - one to update the docs and one that is a feature request @ScriptAutomate is that how you read this?

[ScriptAutomate]

@cmcmarrow @sagetherage I think this is either a bug or a needed feature, from looking at it more, and should probably not involve documentation updates. pkg.uptodate should be able to pass dist_upgrade=true properly to salt.modules.zypperpkg.list_upgrades(), I think, since zypperpkg.upgrade() itself does support dist_upgrade, and would be in line with what pkg.uptodate is meant to do as far as I can tell.

I'm not sure if there is anything to do at the Documentation level, otherwise Docs would just be saying, "This isn't supported yet for SUSE/SLES systems with the dist_upgrade option, as the execution module for zypperpkg currently doesn't support querying whether a dist_upgrade is available via `zypperpkg.list_upgrades()." or something like that, and then having to remove it once it is. This issue should act as documentation of the bug/need-of-feature until it is fixed/introduced.

Seems like zypperpkg.list_upgrades() needs to be looked at? I'm not familiar enough with this module to know whether OOB it lists dist_upgrade potential, or whether it needs to be extended to support it with an arg.

• Docs: salt.states.pkg.uptodate (the docs to uptodate which should likely be actually passing the values down)
• Docs: salt.modules.zypperpkg.upgrade (where zypperpkg.upgrade() supports dist_upgrade as an option)