feature request: persist option for salt.modules.mount

[alienzrcoming]

Was looking at the documentation for salt.modules.mount (http://docs.saltstack.com/en/latest/ref/modules/all/salt.modules.mount.html) and noticed that there doesn't appear to be a 'persist' option. This would be nice in situations where one needs to ensure a mount is in place with desired options, AND that it is updated in /etc/fstab (hence, the persist option)

[ssgward]

Thanks for the report and good idea. Always feel free to contribute towards this feature request.

[eliasp]

Currently the persist logic resides in the mount state. This should IMHO be moved to the execution module to be re-used by the state then.

[cachedout]

+1 to the suggestion from @eliasp. This definietely seems like the right approach.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[eliasp]

Looking at the current state of the state/execution modules, this seems to be still valid.

Also related: #14103

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.

[dgorissen]

Bumped into this, this does seem fixed now? https://docs.saltstack.com/en/latest/ref/states/all/salt.states.mount.html#salt.states.mount.mounted

[mchugh19]

@dgorissen unfortunately, nope. The linked URL is for the mount state, which does have the persist option. This issue is basically to migrate that functionality to the mount execution module, and then re-use that logic in the state.

Looks like the mount.mount execution module, could possibly use the logic from mount.set_fstab (or mount.set_vfstab when on Solaris, I assume).

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[mchugh19]

Not stale

[stale[bot]]

Thank you for updating this issue. It is no longer marked as stale.