From 829c9a5f115fbe6861f7faee65cc60c0549b0033 Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 4 Nov 2024 12:26:16 -0800 Subject: [PATCH 1/3] fix: customize CI for node v20 @W-16974485@ --- .github/workflows/test.yml | 2 +- .github/workflows/validate-pr.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5c8de402..f7057fe9 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,7 +1,7 @@ name: tests on: push: - branches-ignore: [main] + branches-ignore: [main, 252-patch] workflow_dispatch: jobs: diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index a312052e..adfafbdf 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -4,7 +4,7 @@ on: pull_request: types: [opened, reopened, edited] # only applies to PRs that want to merge to main - branches: [main] + branches: [main, 252-patch] jobs: pr-validation: From 38a95198af1275c2c1ba0f8bc58bd025ba06ff03 Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 4 Nov 2024 09:00:21 -0800 Subject: [PATCH 2/3] fix: add debug logs to figure out npm tag issue @W-16974485@ (#236) --- .github/workflows/onRelease.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/onRelease.yml b/.github/workflows/onRelease.yml index 2230d639..442013a4 100644 --- a/.github/workflows/onRelease.yml +++ b/.github/workflows/onRelease.yml @@ -22,6 +22,10 @@ jobs: ref: ${{ github.event.release.tag_name || inputs.tag }} - uses: salesforcecli/github-workflows/.github/actions/getPreReleaseTag@main id: distTag + - run: echo "[INFO] tag is=$INPUTS_TAG , version is=$INPUTS_VERSION" + env: + INPUTS_TAG: ${{ steps.distTag.outputs.tag }} + INPUTS_VERSION: ${{ steps.distTag.outputs.version }} getMajorVersion: needs: [getDistTag] @@ -30,8 +34,12 @@ jobs: runs-on: ubuntu-latest steps: - uses: salesforcecli/github-workflows/.github/actions/parse-semver@main + id: parsedVersion with: input_string: ${{ needs.getDistTag.outputs.version }} + - run: echo "[INFO] Major version is=$INPUTS_MAJOR_VERSION" + env: + INPUTS_MAJOR_VERSION: ${{ steps.parsedVersion.outputs.major }} npm: uses: salesforcecli/github-workflows/.github/workflows/npmPublish.yml@main From 3df9681dc903063a1e2249652045ce5248c072fb Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 4 Nov 2024 12:13:40 -0800 Subject: [PATCH 3/3] fix: set node version for npm-publish @W-16974485@ (#241) * fix: set node version for npm-publish @W-16974485@ * fix: setup nodejs to v20 for CI scripts * fix: set nodeVersion for nuts workflow --- .github/workflows/onRelease.yml | 1 + .github/workflows/test.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/onRelease.yml b/.github/workflows/onRelease.yml index 442013a4..b1a105ef 100644 --- a/.github/workflows/onRelease.yml +++ b/.github/workflows/onRelease.yml @@ -49,5 +49,6 @@ jobs: sign: true tag: ${{ needs.getDistTag.outputs.tag || (needs.getMajorVersion.outputs.major == '1') && 'latest' || 'next' }} githubTag: ${{ github.event.release.tag_name || inputs.tag }} + nodeVersion: 20.18.0 secrets: inherit diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f7057fe9..f09db51d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -26,3 +26,4 @@ jobs: fail-fast: false with: os: ${{ matrix.os }} + nodeVersion: 20.18.0