From 672925d89a1477eaec9c58b57ade78e1bf631165 Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 4 Nov 2024 11:00:33 -0800 Subject: [PATCH 1/3] fix: set node version for npm-publish @W-16974485@ --- .github/workflows/onRelease.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/onRelease.yml b/.github/workflows/onRelease.yml index 442013a4..b1a105ef 100644 --- a/.github/workflows/onRelease.yml +++ b/.github/workflows/onRelease.yml @@ -49,5 +49,6 @@ jobs: sign: true tag: ${{ needs.getDistTag.outputs.tag || (needs.getMajorVersion.outputs.major == '1') && 'latest' || 'next' }} githubTag: ${{ github.event.release.tag_name || inputs.tag }} + nodeVersion: 20.18.0 secrets: inherit From efa81bc4a98deb5c7bd83beea3a3a1fc9a07b6f8 Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 4 Nov 2024 11:23:30 -0800 Subject: [PATCH 2/3] fix: setup nodejs to v20 for CI scripts --- .github/workflows/test.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f7057fe9..64294298 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,6 +4,10 @@ on: branches-ignore: [main, 252-patch] workflow_dispatch: +env: + # This repo currently runs on nodejs@20 due to a depedency that is incompatible with nodejs@22 + NODE_VERSION_OVERRIDE: 'lts/-1' + jobs: yarn-lockfile-check: uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main From dce616aa66420e34d8360831100648a7ece934a5 Mon Sep 17 00:00:00 2001 From: Ravi Jayaramappa Date: Mon, 4 Nov 2024 11:50:52 -0800 Subject: [PATCH 3/3] fix: set nodeVersion for nuts workflow --- .github/workflows/test.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 64294298..f09db51d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -4,10 +4,6 @@ on: branches-ignore: [main, 252-patch] workflow_dispatch: -env: - # This repo currently runs on nodejs@20 due to a depedency that is incompatible with nodejs@22 - NODE_VERSION_OVERRIDE: 'lts/-1' - jobs: yarn-lockfile-check: uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main @@ -30,3 +26,4 @@ jobs: fail-fast: false with: os: ${{ matrix.os }} + nodeVersion: 20.18.0