Skip to content

Can't distinguish between directory's link and single file's link on smb2 #203

@hengwu0

Description

@hengwu0

The smb2_type only have 3 values:

#define SMB2_TYPE_FILE      0x00000000
#define SMB2_TYPE_DIRECTORY 0x00000001
#define SMB2_TYPE_LINK      0x00000002

it is not enough for Caller to get the file's attributes. For example, a directory's link file is SMB2_TYPE_LINK, and an normal file's link file is also SMB2_TYPE_LINK too! It is hard for Caller to distinguish them. The code now is:

                if (fs->basic.file_attributes & SMB2_FILE_ATTRIBUTE_REPARSE_POINT) {
                        st->smb2_type = SMB2_TYPE_LINK;
                }

From code showed, smb2_type is getted from file_attributes, and file_attributes already saved all attributes. For example, it's value is (SMB2_FILE_ATTRIBUTE_REPARSE_POINT|SMB2_FILE_ATTRIBUTE_DIRECTORY)0x410 for a directory's link.
Let 'file_attributes' equal 'smb2_type', can help the Caller to get full information about the file in smb.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions