terminal: replace some hacks by root cause fixes

- noticed I could reproduce the term control codes problem and fixed it
  by not sending the request in the first place

Author: williamstein

src/packages/frontend/frame-editors/terminal-editor/connected-terminal.ts

@@ -307,6 +307,7 @@ export class Terminal<T extends CodeEditorState = CodeEditorState> {
       });
       conn.on("data", this.handleDataFromProject);
       conn.once("ready", () => {
+        this.terminal.clear();
         delete this.last_geom;
         this.ignore_terminal_data = false;
         this.set_connection_status("connected");
@@ -706,6 +707,12 @@ export class Terminal<T extends CodeEditorState = CodeEditorState> {
 
   init_terminal_data(): void {
     this.terminal.onData((data) => {
+      if (data == "\x1B[>0;276;0c") {
+        // this is a request for term capabilities, sending it just ends up
+        // not helping and putting "control codes" that users see in the terminal,
+        // which is very bad.  So we ignore them.
+        return;
+      }
       if (this.ignore_terminal_data && this.conn?.state == "init") {
         return;
       }
@@ -763,7 +770,11 @@ export class Terminal<T extends CodeEditorState = CodeEditorState> {
       return;
     }
     const { rows, cols } = geom;
-    if (this.last_geom?.rows === rows && this.last_geom?.cols === cols) {
+    if (
+      !kick &&
+      this.last_geom?.rows === rows &&
+      this.last_geom?.cols === cols
+    ) {
       return;
     }
     this.last_geom = { rows, cols };

src/packages/frontend/frame-editors/terminal-editor/nats-terminal-connection.ts

@@ -82,7 +82,7 @@ export class NatsTerminalConnection extends EventEmitter {
     }
     if (typeof data != "string") {
       if (data.cmd == "size") {
-        const { rows, cols } = data;
+        const { rows, cols, kick } = data;
         if (
           rows <= 0 ||
           cols <= 0 ||
@@ -99,6 +99,7 @@ export class NatsTerminalConnection extends EventEmitter {
             rows,
             cols,
             browser_id: webapp_client.browser_id,
+            kick,
           });
         } catch {
           // harmless to ignore
@@ -241,9 +242,6 @@ export class NatsTerminalConnection extends EventEmitter {
   };
 
   private setReady = async () => {
-    // wait until after render loop of terminal before allowing writing,
-    // or we get corruption.
-    await delay(1);
     this.setState("running");
     this.emit("ready");
   };

src/packages/nats/service/terminal.ts

@@ -29,6 +29,7 @@ interface TerminalApi {
     rows: number;
     cols: number;
     browser_id: string;
+    kick?: boolean;
   }) => Promise<void>;
 
   // sent from browser to project when this client is leaving.