perf: narrow Theme.of calls

adil192 · adil192 · commit 2285694d3afd · 2025-10-17T13:33:24.000+01:00
diff --git a/lib/components/canvas/canvas_background_preview.dart b/lib/components/canvas/canvas_background_preview.dart
@@ -33,7 +33,7 @@ class CanvasBackgroundPreview extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     final previewSize = Size(
       fixedWidth,
       pageSize.height / pageSize.width * fixedWidth,
diff --git a/lib/components/canvas/canvas_image.dart b/lib/components/canvas/canvas_image.dart
@@ -111,10 +111,11 @@ class _CanvasImageState extends State<CanvasImage> {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
 
-    Brightness currentBrightness = Theme.of(context).brightness;
-    if (!widget.image.invertible) currentBrightness = Brightness.light;
+    final currentBrightness = widget.image.invertible
+        ? Theme.brightnessOf(context)
+        : Brightness.light;
 
     if (stows.editorAutoInvert.value && currentBrightness != imageBrightness) {
       imageBrightness = currentBrightness;
@@ -304,7 +305,7 @@ class _CanvasImageResizeHandle extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return Positioned(
       left: (position.dx.sign + 1) / 2 * image.dstRect.width - 20,
       top: (position.dy.sign + 1) / 2 * image.dstRect.height - 20,
diff --git a/lib/components/canvas/canvas_image_dialog.dart b/lib/components/canvas/canvas_image_dialog.dart
@@ -166,7 +166,7 @@ class _CanvasImageDialogItem extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return Material(
       color: colorScheme.primary.withValues(alpha: 0.05),
       borderRadius: BorderRadius.circular(8),
diff --git a/lib/components/canvas/hud/canvas_gesture_lock_btn.dart b/lib/components/canvas/hud/canvas_gesture_lock_btn.dart
@@ -21,7 +21,7 @@ class CanvasGestureLockBtn extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return GestureDetector(
       onTap: () => setLock(!lock),
       child: Container(
diff --git a/lib/components/canvas/hud/canvas_zoom_indicator.dart b/lib/components/canvas/hud/canvas_zoom_indicator.dart
@@ -12,7 +12,7 @@ class CanvasZoomIndicator extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return InkWell(
       onTap: resetZoom,
       child: Container(
diff --git a/lib/components/canvas/inner_canvas.dart b/lib/components/canvas/inner_canvas.dart
@@ -64,8 +64,8 @@ class InnerCanvas extends StatefulWidget {
 class _InnerCanvasState extends State<InnerCanvas> {
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
-    final Brightness brightness = Theme.of(context).brightness;
+    final colorScheme = ColorScheme.of(context);
+    final Brightness brightness = Theme.brightnessOf(context);
     final bool invert =
         stows.editorAutoInvert.value && brightness == Brightness.dark;
     final Color backgroundColor =
@@ -196,7 +196,7 @@ class _InnerCanvasState extends State<InnerCanvas> {
 
   /// Adapted from https://github.com/singerdmx/flutter-quill/blob/master/lib/src/editor/widgets/default_styles.dart
   DefaultStyles _getQuillStyles({required bool invert}) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     final backgroundColor = invert ? Colors.black : Colors.white;
     final lineHeight = widget.coreInfo.lineHeight;
 
diff --git a/lib/components/files/file_tree.dart b/lib/components/files/file_tree.dart
@@ -59,7 +59,7 @@ class _FileTreeBranchState extends State<FileTreeBranch> {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     final backgroundColor = Color.alphaBlend(
       colorScheme.primary.withValues(alpha: 0.05),
       colorScheme.surface,
@@ -93,7 +93,7 @@ class _FileTreeBranchState extends State<FileTreeBranch> {
                   Expanded(
                     child: Text(
                       widget.path!.substring(widget.path!.lastIndexOf('/') + 1),
-                      style: Theme.of(context).textTheme.bodyMedium?.copyWith(
+                      style: TextTheme.of(context).bodyMedium?.copyWith(
                             fontSize: 14,
                           ),
                       overflow: TextOverflow.ellipsis,
diff --git a/lib/components/home/grid_folders.dart b/lib/components/home/grid_folders.dart
@@ -103,7 +103,7 @@ class _GridFolderState extends State<_GridFolder> {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     final cardElevatedColor = Color.alphaBlend(
       colorScheme.primary.withValues(alpha: 0.05),
       colorScheme.surface,
diff --git a/lib/components/home/no_files.dart b/lib/components/home/no_files.dart
@@ -7,7 +7,7 @@ class NoFiles extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    var textTheme = Theme.of(context).textTheme;
+    var textTheme = TextTheme.of(context);
     return Center(
       child: Padding(
         padding: const EdgeInsets.all(8),
diff --git a/lib/components/home/welcome.dart b/lib/components/home/welcome.dart
@@ -7,7 +7,7 @@ class Welcome extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    var textTheme = Theme.of(context).textTheme;
+    var textTheme = TextTheme.of(context);
     return Center(
       child: Padding(
         padding: const EdgeInsets.all(8),
diff --git a/lib/components/nextcloud/done_login_step.dart b/lib/components/nextcloud/done_login_step.dart
@@ -39,7 +39,7 @@ class _DoneLoginStepState extends State<DoneLoginStep> {
 
   @override
   Widget build(BuildContext context) {
-    final textTheme = Theme.of(context).textTheme;
+    final textTheme = TextTheme.of(context);
     final screenWidth = MediaQuery.sizeOf(context).width;
     final screenHeight = MediaQuery.sizeOf(context).height;
     final quota = stows.lastStorageQuota.value;
diff --git a/lib/components/nextcloud/enc_login_step.dart b/lib/components/nextcloud/enc_login_step.dart
@@ -41,8 +41,8 @@ class _EncLoginStepState extends State<EncLoginStep> {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
-    final textTheme = Theme.of(context).textTheme;
+    final colorScheme = ColorScheme.of(context);
+    final textTheme = TextTheme.of(context);
     final screenWidth = MediaQuery.sizeOf(context).width;
     final screenHeight = MediaQuery.sizeOf(context).height;
     return ListView(
diff --git a/lib/components/nextcloud/nc_login_step.dart b/lib/components/nextcloud/nc_login_step.dart
@@ -88,8 +88,8 @@ class _NcLoginStepState extends State<NcLoginStep> {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
-    final textTheme = Theme.of(context).textTheme;
+    final colorScheme = ColorScheme.of(context);
+    final textTheme = TextTheme.of(context);
     final screenWidth = MediaQuery.sizeOf(context).width;
     final screenHeight = MediaQuery.sizeOf(context).height;
     return ListView(
diff --git a/lib/components/settings/nextcloud_profile.dart b/lib/components/settings/nextcloud_profile.dart
@@ -71,7 +71,7 @@ class _NextcloudProfileState extends State<NextcloudProfile> {
     };
     const pfpSize = 48.0;
 
-    var colorScheme = Theme.of(context).colorScheme;
+    var colorScheme = ColorScheme.of(context);
     return ListTile(
       visualDensity: VisualDensity.standard,
       onTap: () => context.push(RoutePaths.login),
diff --git a/lib/components/settings/settings_directory_selector.dart b/lib/components/settings/settings_directory_selector.dart
@@ -129,7 +129,7 @@ class _DirectorySelectorState extends State<DirectorySelector> {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
 
     final emptyError = widget.mustBeEmpty && !_isEmpty;
     final syncingError = widget.mustBeDoneSyncing &&
diff --git a/lib/components/settings/settings_subtitle.dart b/lib/components/settings/settings_subtitle.dart
@@ -10,7 +10,7 @@ class SettingsSubtitle extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return Padding(
       padding: const EdgeInsets.only(
         top: 32,
diff --git a/lib/components/settings/update_dialog.dart b/lib/components/settings/update_dialog.dart
@@ -79,7 +79,7 @@ class _UpdateDialogState extends State<UpdateDialog> {
             Text(
               t.update.downloadNotAvailableYet,
               style: TextStyle(
-                color: Theme.of(context).colorScheme.error,
+                color: ColorScheme.of(context).error,
               ),
             ),
         ],
diff --git a/lib/components/toolbar/color_bar.dart b/lib/components/toolbar/color_bar.dart
@@ -171,7 +171,7 @@ class _ColorBarState extends State<ColorBar> {
 
   @override
   Widget build(BuildContext context) {
-    var colorScheme = Theme.of(context).colorScheme;
+    var colorScheme = ColorScheme.of(context);
 
     final children = <Widget>[
       // pinned colors
diff --git a/lib/components/toolbar/color_option.dart b/lib/components/toolbar/color_option.dart
@@ -22,7 +22,7 @@ class ColorOption extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    var colorScheme = Theme.of(context).colorScheme;
+    var colorScheme = ColorScheme.of(context);
     return Tooltip(
       message: tooltip ?? '',
       child: Padding(
@@ -67,7 +67,7 @@ class ColorOptionSeparatorIcon extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    var colorScheme = Theme.of(context).colorScheme;
+    var colorScheme = ColorScheme.of(context);
     return Padding(
       padding: const EdgeInsets.symmetric(
         horizontal: 8,
diff --git a/lib/components/toolbar/editor_bottom_sheet.dart b/lib/components/toolbar/editor_bottom_sheet.dart
@@ -126,7 +126,7 @@ class _EditorBottomSheetState extends State<EditorBottomSheet> {
             if (backgroundImage != null) ...[
               Text(
                 t.editor.menu.backgroundImageFit,
-                style: Theme.of(context).textTheme.titleMedium,
+                style: TextTheme.of(context).titleMedium,
               ),
               SizedBox(
                 height: previewSize.height,
@@ -188,7 +188,7 @@ class _EditorBottomSheetState extends State<EditorBottomSheet> {
             ],
             Text(
               t.editor.menu.backgroundPattern,
-              style: Theme.of(context).textTheme.titleMedium,
+              style: TextTheme.of(context).titleMedium,
             ),
             SizedBox(
               height: previewSize.height,
@@ -238,11 +238,11 @@ class _EditorBottomSheetState extends State<EditorBottomSheet> {
             const SizedBox(height: 16),
             Text(
               t.editor.menu.lineHeight,
-              style: Theme.of(context).textTheme.titleMedium,
+              style: TextTheme.of(context).titleMedium,
             ),
             Text(
               t.editor.menu.lineHeightDescription,
-              style: Theme.of(context).textTheme.bodyMedium,
+              style: TextTheme.of(context).bodyMedium,
             ),
             Row(
               children: [
@@ -262,11 +262,11 @@ class _EditorBottomSheetState extends State<EditorBottomSheet> {
             ),
             Text(
               t.editor.menu.lineThickness,
-              style: Theme.of(context).textTheme.titleMedium,
+              style: TextTheme.of(context).titleMedium,
             ),
             Text(
               t.editor.menu.lineThicknessDescription,
-              style: Theme.of(context).textTheme.bodyMedium,
+              style: TextTheme.of(context).bodyMedium,
             ),
             Row(
               children: [
@@ -287,7 +287,7 @@ class _EditorBottomSheetState extends State<EditorBottomSheet> {
             const SizedBox(height: 16),
             Text(
               t.editor.menu.import,
-              style: Theme.of(context).textTheme.titleMedium,
+              style: TextTheme.of(context).titleMedium,
             ),
             Wrap(
               spacing: 8,
@@ -350,7 +350,7 @@ class _PermanentTooltip extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return DecoratedBox(
       decoration: BoxDecoration(
         borderRadius: BorderRadius.circular(8),
diff --git a/lib/components/toolbar/pen_modal.dart b/lib/components/toolbar/pen_modal.dart
@@ -53,8 +53,8 @@ class _PenModalState extends State<PenModal> {
             }),
             style: TextButton.styleFrom(
               foregroundColor: Pen.currentPen.icon == Pen.fountainPenIcon
-                  ? Theme.of(context).colorScheme.secondary
-                  : Theme.of(context).colorScheme.onSurface,
+                  ? ColorScheme.of(context).secondary
+                  : ColorScheme.of(context).onSurface,
               backgroundColor: Pen.currentPen.icon == Pen.fountainPenIcon
                   ? Theme.of(context)
                       .colorScheme
@@ -70,8 +70,8 @@ class _PenModalState extends State<PenModal> {
               height: 32 / 508 * 374,
               theme: SvgTheme(
                 currentColor: Pen.currentPen.icon == Pen.fountainPenIcon
-                    ? Theme.of(context).colorScheme.secondary
-                    : Theme.of(context).colorScheme.onSurface,
+                    ? ColorScheme.of(context).secondary
+                    : ColorScheme.of(context).onSurface,
               ),
             ),
           ),
@@ -82,8 +82,8 @@ class _PenModalState extends State<PenModal> {
             }),
             style: TextButton.styleFrom(
               foregroundColor: Pen.currentPen.icon == Pen.ballpointPenIcon
-                  ? Theme.of(context).colorScheme.secondary
-                  : Theme.of(context).colorScheme.onSurface,
+                  ? ColorScheme.of(context).secondary
+                  : ColorScheme.of(context).onSurface,
               backgroundColor: Pen.currentPen.icon == Pen.ballpointPenIcon
                   ? Theme.of(context)
                       .colorScheme
@@ -99,8 +99,8 @@ class _PenModalState extends State<PenModal> {
               height: 32 / 508 * 374,
               theme: SvgTheme(
                 currentColor: Pen.currentPen.icon == Pen.ballpointPenIcon
-                    ? Theme.of(context).colorScheme.secondary
-                    : Theme.of(context).colorScheme.onSurface,
+                    ? ColorScheme.of(context).secondary
+                    : ColorScheme.of(context).onSurface,
               ),
             ),
           ),
@@ -111,8 +111,8 @@ class _PenModalState extends State<PenModal> {
             }),
             style: TextButton.styleFrom(
               foregroundColor: Pen.currentPen.icon == ShapePen.shapePenIcon
-                  ? Theme.of(context).colorScheme.secondary
-                  : Theme.of(context).colorScheme.onSurface,
+                  ? ColorScheme.of(context).secondary
+                  : ColorScheme.of(context).onSurface,
               backgroundColor: Pen.currentPen.icon == ShapePen.shapePenIcon
                   ? Theme.of(context)
                       .colorScheme
diff --git a/lib/components/toolbar/selection_bar.dart b/lib/components/toolbar/selection_bar.dart
@@ -21,7 +21,7 @@ class SelectionBar extends StatelessWidget {
         IconButton(
           onPressed: duplicateSelection,
           style: TextButton.styleFrom(
-            foregroundColor: Theme.of(context).colorScheme.secondary,
+            foregroundColor: ColorScheme.of(context).secondary,
             backgroundColor: Colors.transparent,
             shape: const CircleBorder(),
           ),
@@ -34,7 +34,7 @@ class SelectionBar extends StatelessWidget {
         IconButton(
           onPressed: deleteSelection,
           style: TextButton.styleFrom(
-            foregroundColor: Theme.of(context).colorScheme.secondary,
+            foregroundColor: ColorScheme.of(context).secondary,
             backgroundColor: Colors.transparent,
             shape: const CircleBorder(),
           ),
diff --git a/lib/components/toolbar/size_picker.dart b/lib/components/toolbar/size_picker.dart
@@ -32,7 +32,7 @@ String _prettyNum(double num) {
 class _SizePickerState extends State<SizePicker> {
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return Flex(
       direction: widget.axis,
       mainAxisSize: MainAxisSize.min,
@@ -93,7 +93,7 @@ class _SizeSlider extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final colorScheme = Theme.of(context).colorScheme;
+    final colorScheme = ColorScheme.of(context);
     return GestureDetector(
       onHorizontalDragStart: axis == Axis.horizontal
           ? (details) =>
diff --git a/lib/components/toolbar/toolbar.dart b/lib/components/toolbar/toolbar.dart
@@ -162,9 +162,9 @@ class _ToolbarState extends State<Toolbar> {
 
   @override
   Widget build(BuildContext context) {
-    var colorScheme = Theme.of(context).colorScheme;
+    var colorScheme = ColorScheme.of(context);
 
-    Brightness brightness = Theme.of(context).brightness;
+    final brightness = Theme.brightnessOf(context);
     bool invert = stows.editorAutoInvert.value && brightness == Brightness.dark;
 
     final isToolbarVertical =
@@ -264,7 +264,7 @@ class _ToolbarState extends State<Toolbar> {
           valueListenable: widget.quillFocus,
           builder: (context, quill, _) {
             final baseButtonStyle =
-                Theme.of(context).iconButtonTheme.style ?? const ButtonStyle();
+                IconButtonTheme.of(context).style ?? const ButtonStyle();
 
             final iconTheme = QuillIconTheme(
               iconButtonUnselectedData: IconButtonData(
diff --git a/lib/components/toolbar/toolbar_button.dart b/lib/components/toolbar/toolbar_button.dart
diff --git a/lib/pages/editor/editor.dart b/lib/pages/editor/editor.dart
diff --git a/lib/pages/home/browse.dart b/lib/pages/home/browse.dart
diff --git a/lib/pages/home/recent_notes.dart b/lib/pages/home/recent_notes.dart
diff --git a/lib/pages/home/settings.dart b/lib/pages/home/settings.dart
diff --git a/lib/pages/logs.dart b/lib/pages/logs.dart
