Bump Ruby, update Rubocop and Fix few offenses (#29)

* Bump minimum ruby version to 3.2

* Bump rubocop & rubocop-rspec

* Fix: change require_relative path

* Update Rubocop versions

* Fix rubocop offenses on lib/slither.rb

Author: JorgeGarciaxyz

Gemfile

@@ -9,7 +9,7 @@ gem "bundler"
 gem "pry"
 gem "rake", "~> 13.0"
 gem "rspec", "~> 3.0"
-gem "rubocop", "~> 1.21"
-gem "rubocop-rspec", "~> 2.22.0", require: false
+gem "rubocop", "~> 1.76.1"
+gem "rubocop-rspec", "~> 3.6.0", require: false
 # Documentation tool
 gem "yard"

Gemfile.lock

@@ -1,26 +1,30 @@
 PATH
   remote: .
   specs:
-    slither (0.99.5)
+    slither (0.99.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.2)
+    ast (2.4.3)
     coderay (1.1.3)
     diff-lcs (1.5.0)
-    json (2.6.3)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     method_source (1.0.0)
-    parallel (1.22.1)
-    parser (3.2.0.0)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
+      racc
+    prism (1.4.0)
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    racc (1.8.1)
     rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.7.0)
-    rexml (3.2.5)
+    regexp_parser (2.10.0)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
@@ -34,28 +38,27 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)
-    rubocop (1.45.1)
+    rubocop (1.76.1)
       json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.24.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.45.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.24.1)
-      parser (>= 3.1.1.0)
-    rubocop-capybara (2.18.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
-      rubocop (~> 1.33)
-    rubocop-rspec (2.22.0)
-      rubocop (~> 1.33)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-    ruby-progressbar (1.11.0)
-    unicode-display_width (2.4.2)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.45.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    ruby-progressbar (1.13.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
     yard (0.9.34)
 
 PLATFORMS
@@ -66,8 +69,8 @@ DEPENDENCIES
   pry
   rake (~> 13.0)
   rspec (~> 3.0)
-  rubocop (~> 1.21)
-  rubocop-rspec (~> 2.22.0)
+  rubocop (~> 1.76.1)
+  rubocop-rspec (~> 3.6.0)
   slither!
   yard
 

lib/slither.rb

@@ -17,14 +17,26 @@ class ColumnMismatchError < StandardError; end
   class LineWrongSizeError < StandardError; end
   class SectionsNotSameLengthError < StandardError; end
 
+  class << self
+    private
+
+    def definitions
+      @@definitions ||= {} # rubocop:disable Style/ClassVars
+    end
+
+    def definition(name)
+      definitions[name]
+    end
+  end
+
   # Define a Slither's definition to parse a file.
   #
   # name - String name of the definition, this should be unique.
   # options - Hash of options to pass to the definition.
   #           Ex: by_bytes: true, to parse by bytes
   #           Ex: align: :left, to align the columns to the left
   # block - Block to define the sections of the definition. See README.md for more info.
-  def self.define(name, options = {}, &block)
+  def self.define(name, options = {}, &block) # rubocop:disable Lint/UnusedMethodArgument
     definition = Definition.new(options)
     yield(definition)
     definitions[name] = definition
@@ -42,33 +54,21 @@ def self.generate(definition_name, data)
 
   # Writes the File
   def self.write(filename, definition_name, data)
-    File.open(filename, "w") do |f|
-      f.write generate(definition_name, data)
-    end
+    File.write(filename, generate(definition_name, data))
   end
 
   def self.parse(filename, definition_name)
     raise ArgumentError, "File #{filename} does not exist." unless File.exist?(filename)
 
-    file_io = File.open(filename, 'r')
+    file_io = File.open(filename, "r")
     parseIo(file_io, definition_name)
   end
 
-  def self.parseIo(io, definition_name)
+  def self.parseIo(io, definition_name) # rubocop:disable Naming/MethodName
     definition = definition(definition_name)
     raise ArgumentError, "Definition name '#{definition_name}' was not found." unless definition
 
     parser = Parser.new(definition, io)
     definition.options[:by_bytes] ? parser.parse_by_bytes : parser.parse
   end
-
-  private
-
-  def self.definitions
-    @@definitions ||= {}
-  end
-
-  def self.definition(name)
-    definitions[name]
-  end
 end

slither.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |spec|
   spec.authors = ["Ryan Wood"]
   spec.summary = "A simple, clean DSL for describing, writing, and parsing fixed-width text files."
   spec.license = "MIT"
-  spec.required_ruby_version = ">= 3.0.0"
+  spec.required_ruby_version = ">= 3.2.0"
 
   spec.homepage = "https://github.com/ryanwood/slither"
 

spec/slither_spec.rb

@@ -51,10 +51,8 @@
     it "write a file" do
       simple_definition
 
-      file = instance_double(File, "file")
-
-      allow(File).to receive(:open).with(file_name, "w").and_yield(file)
-      expect(file).to receive(:write)
+      allow(File).to receive(:write).with(file_name, anything)
+      expect(File).to receive(:write)
 
       subject.write(file_name, :simple, simple_definition_test_data)
     end

spec/spec_helper.rb

@@ -2,7 +2,7 @@
 
 require "slither"
 require "pry"
-require_relative "./helpers/definition_helper"
+require_relative "helpers/definition_helper"
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure