Various opcodes #499
Merged
Various opcodes #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than the comments, LGTM |
darkf
requested changes
Jun 17, 2018
| @@ -519,8 +519,13 @@ void VehicleObject::tickPhysics(float dt) { | |||
| } | |||
|
|
|||
| bool VehicleObject::isFlipped() const { | |||
| auto up = getRotation() * glm::vec3(0.f, 0.f, 1.f); | |||
| return up.z <= -0.1f; | |||
| auto forward = getRotation() * glm::vec3(0.f, 0.f, 1.f); | |||
There was a problem hiding this comment.
Can you not just make this getRotation().z <= -0.97f?
| } | ||
|
|
||
| bool VehicleObject::isUpright() const { | ||
| auto forward = getRotation() * glm::vec3(0.f, 0.f, 1.f); |
darkf
approved these changes
Jun 17, 2018
ghost
reviewed
Jun 17, 2018
| @@ -25,6 +25,10 @@ void ScriptMachine::executeThread(SCMThread& t, int msPassed) { | |||
| } | |||
| } | |||
|
|
|||
| if (t.allowWaitSkip && getState()->input[0].pressed(GameInputState::Jump)) { | |||
There was a problem hiding this comment.
Can you add comment what's the purpose of this if? thx
ghost
deleted the
NFSMONSTR
pushed a commit
to NFSMONSTR/openrw
that referenced
this pull request
Jun 18, 2018
Various opcodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented various opcodes