Skip to content

Fix vehicle damage #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jun 19, 2018
Merged

Fix vehicle damage #492

merged 1 commit into from Jun 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2018

No description provided.

@ghost
Copy link

ghost commented Jun 7, 2018

Can you add in commit message short note what didn't work and how you fixed it?

Damage was only applied if there was an impulse/impact
@JayFoxRox
Copy link
Collaborator

nit: Commit title is slightly wrong, I think the real message should convey that this was about visual damage / strong impacts.

For future PRs: Always add a PR description to explain the changes - regardless how small the change is.
I think there might be a value in having a threshold for damage (and might already be done elsewhere in the code?). I worry this change might result in too much damage in rare cases (sliding along walls possibly). However, I do not know how damage is calculated in openrw - I think the PR description would have been a good room to explain this, and why we don't need the threshold (which might have been an intentional decision).

Anyhow, I also think this was a bug, and I'd assume this change doesn't break anything.
If it does, we can always fix it again later.

LGTM; Merging.

@JayFoxRox JayFoxRox merged commit 3a05235 into rwengine:master Jun 19, 2018
@ghost ghost deleted the patch-3 branch June 19, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant