commando: don't try putting an integer as the 'string' parameter to "datastore".

rustyrussell · endothermicdev · commit 15a744be8c1b · 2023-02-11T12:22:40.000-06:00
This only worked because we handled the JSON raw: next patch prohibits this.

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
diff --git a/plugins/commando.c b/plugins/commando.c
@@ -968,7 +968,8 @@ static struct command_result *json_commando_rune(struct command *cmd,
 		*rune_counter = 1;
 		json_add_string(req->js, "mode", "must-create");
 	}
-	json_add_u64(req->js, "string", *rune_counter);
+	json_add_string(req->js, "string",
+			tal_fmt(tmpctx, "%"PRIu64, *rune_counter));
 	return send_outreq(plugin, req);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -968,7 +968,8 @@ static struct command_result json_commando_rune(struct command cmd,`
`968`	`968`	`*rune_counter = 1;`
`969`	`969`	`json_add_string(req->js, "mode", "must-create");`
`970`	`970`	`}`
`971`		`- json_add_u64(req->js, "string", *rune_counter);`
	`971`	`+ json_add_string(req->js, "string",`
	`972`	`+ tal_fmt(tmpctx, "%"PRIu64, *rune_counter));`
`972`	`973`	`return send_outreq(plugin, req);`
`973`	`974`	`}`
`974`	`975`