Skip to content

Commit 170ce68

Browse files
committed
Add missing Element::get_elements_by_* methods
1 parent a48a0ae commit 170ce68

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

crates/web-sys/tests/wasm/element.rs

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,4 +196,29 @@ fn element() {
196196
request_fullscreen
197197
request_pointer_lock
198198
*/
199+
200+
let child = new_div();
201+
assert_eq!(
202+
element.get_elements_by_tag_name("div").length(),
203+
0,
204+
"Element should not contain any div child"
205+
);
206+
element.append_child(&child).unwrap();
207+
assert_eq!(
208+
element.get_elements_by_tag_name("div").length(),
209+
1,
210+
"Element should contain one div child"
211+
);
212+
assert_eq!(
213+
element.get_elements_by_class_name("foo").length(),
214+
0,
215+
"Element should not have childs with class foo"
216+
);
217+
child.class_list().add_1("foo").unwrap();
218+
assert_eq!(
219+
element.get_elements_by_class_name("foo").length(),
220+
1,
221+
"Element should have one child with class foo"
222+
);
223+
element.remove_child(&child).unwrap();
199224
}

crates/web-sys/webidls/enabled/Element.webidl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,12 @@ interface Element : Node {
6565
[Throws, Pure, BinaryName="matches"]
6666
boolean webkitMatchesSelector(DOMString selector);
6767

68-
/*TODO
6968
[Pure]
7069
HTMLCollection getElementsByTagName(DOMString localName);
7170
[Throws, Pure]
7271
HTMLCollection getElementsByTagNameNS(DOMString? namespace, DOMString localName);
7372
[Pure]
7473
HTMLCollection getElementsByClassName(DOMString classNames);
75-
*/
7674
[ChromeOnly, Pure]
7775
sequence<Element> getElementsWithGrid();
7876

0 commit comments

Comments
 (0)