Skip to content

Send ws binary message with Blob #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Send ws binary message with Blob #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/net/src/websocket/futures.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,12 @@ impl Sink<Message> for WebSocket {

fn start_send(self: Pin<&mut Self>, item: Message) -> Result<(), Self::Error> {
let result = match item {
Message::Bytes(bytes) => self.ws.send_with_u8_array(&bytes),
Message::Bytes(bytes) => self.ws.send_with_blob(
&web_sys::Blob::new_with_u8_array_sequence(&js_sys::Array::of1(
&js_sys::Uint8Array::from(bytes.as_slice()),
))
.map_err(|e| WebSocketError::MessageSendError(js_to_js_error(e)))?,
),
Message::Text(message) => self.ws.send_with_str(&message),
};
match result {
Expand Down Expand Up @@ -367,7 +372,7 @@ mod tests {
let (mut sender, mut receiver) = ws.split();

sender
.send(Message::Text(String::from("test 1")))
.send(Message::Bytes(String::from("test 1").as_bytes().to_vec()))
.await
.unwrap();
sender
Expand All @@ -381,7 +386,7 @@ mod tests {

assert_eq!(
receiver.next().await.unwrap().unwrap(),
Message::Text("test 1".to_string())
Message::Bytes("test 1".to_string().as_bytes().to_vec())
);
assert_eq!(
receiver.next().await.unwrap().unwrap(),
Expand Down
Loading