Skip to content

Commit fcba82a

Browse files
committed
bettertls: make test suite opt-in
The Netflix bettertls test suite for pathbuilding and name constraint validation take an outsized amount of runtime compared to our other tests. These tests can take ~8s locally and the entire project test suite with these tests ignored can be run in 0.6s. This commit adds an `#[ignore]` flag so it won't be run by default. We will opt-in to running this test in CI w/ `cargo test -- --ignored`.
1 parent eb64dbc commit fcba82a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

tests/better_tls.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use serde::Deserialize;
1212
use webpki::types::{CertificateDer, TrustAnchor};
1313
use webpki::{extract_trust_anchor, KeyUsage, SubjectNameRef};
1414

15+
#[ignore] // Runs slower than other unit tests - opt-in with `cargo test -- --ignored`
1516
#[test]
1617
fn better_tls() {
1718
let better_tls = testdata();
@@ -30,6 +31,7 @@ fn better_tls() {
3031
);
3132
}
3233

34+
#[ignore] // Runs slower than other unit tests - opt-in with `cargo test -- --ignored`
3335
#[test]
3436
fn name_constraints() {
3537
let better_tls = testdata();

0 commit comments

Comments
 (0)