Skip to content

Commit f3d1c27

Browse files
jiangliubonzini
jiangliu
authored and
bonzini
committed
Normalize GuestMemoryMmap constructors
With code evolves, now we have several constructors for GuestMemoryMmap: pub fn new(ranges: &[(GuestAddress, usize)]) -> result::Result<Self, Error> pub fn with_files<A, T>(ranges: T) -> result::Result<Self, Error> pub fn from_regions(mut regions: Vec<GuestRegionMmap>) -> result::Result<Self, Error>; pub fn from_arc_regions(regions: Vec<Arc<GuestRegionMmap>>) -> result::Result<Self, Error>; With these four constructors, we still have no constructors to create an empty GuestMemoryMmap instance. All these constructors assume that memory regions are static and created at boot time. And memory hotplug breaks that assumption. So normalize GuestMemoryMmap constructors as: pub fn new() -> Self; pub fn from_ranges(ranges: &[(GuestAddress, usize)]) -> result::Result<Self, Error>; pub fn from_ranges_with_files<A, T>(ranges: T) -> result::Result<Self, Error>; pub fn from_regions(mut regions: Vec<GuestRegionMmap>) -> result::Result<Self, Error>; pub fn from_arc_regions(regions: Vec<Arc<GuestRegionMmap>>) -> result::Result<Self, Error>; Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
1 parent 4237db3 commit f3d1c27

File tree

4 files changed

+83
-52
lines changed

4 files changed

+83
-52
lines changed

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ multiple virtualization solutions.
2323

2424
```rust
2525
fn provide_mem_to_virt_dev() {
26-
let gm = GuestMemoryMmap::new(&[
26+
let gm = GuestMemoryMmap::from_ranges(&[
2727
(GuestAddress(0), 0x1000),
2828
(GuestAddress(0x1000), 0x1000)
2929
]).unwrap();

‎coverage_config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"coverage_score": 84.4,
2+
"coverage_score": 84.5,
33
"exclude_path": "mmap_windows.rs",
44
"crate_features": "backend-mmap"
55
}

‎src/guest_memory.rs

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,8 @@ pub trait GuestMemory {
297297
/// # fn test_map_fold() -> Result<(), ()> {
298298
/// let start_addr1 = GuestAddress(0x0);
299299
/// let start_addr2 = GuestAddress(0x400);
300-
/// let mem = GuestMemoryMmap::new(&vec![(start_addr1, 1024), (start_addr2, 2048)]).unwrap();
300+
/// let mem = GuestMemoryMmap::from_ranges(&vec![(start_addr1, 1024), (start_addr2, 2048)])
301+
/// .unwrap();
301302
/// let total_size = mem.map_and_fold(
302303
/// 0,
303304
/// |(_, region)| region.len() / 1024,
@@ -327,7 +328,7 @@ pub trait GuestMemory {
327328
/// # #[cfg(feature = "backend-mmap")]
328329
/// # fn test_last_addr() -> Result<(), ()> {
329330
/// let start_addr = GuestAddress(0x1000);
330-
/// let mut gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).map_err(|_| ())?;
331+
/// let mut gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).map_err(|_| ())?;
331332
/// assert_eq!(start_addr.checked_add(0x3ff), Some(gm.last_addr()));
332333
/// Ok(())
333334
/// # }
@@ -436,7 +437,7 @@ pub trait GuestMemory {
436437
/// # #[cfg(feature = "backend-mmap")]
437438
/// # fn test_get_host_address() -> Result<(), ()> {
438439
/// let start_addr = GuestAddress(0x1000);
439-
/// let mut gm = GuestMemoryMmap::new(&vec![(start_addr, 0x500)]).map_err(|_| ())?;
440+
/// let mut gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x500)]).map_err(|_| ())?;
440441
/// let addr = gm.get_host_address(GuestAddress(0x1200)).unwrap();
441442
/// println!("Host address is {:p}", addr);
442443
/// Ok(())
@@ -486,7 +487,8 @@ impl<T: GuestMemory> Bytes<GuestAddress> for T {
486487
/// # fn test_write_u64() {
487488
/// let start_addr = GuestAddress(0x1000);
488489
/// let mut gm =
489-
/// GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).expect("Could not create guest memory");
490+
/// GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)])
491+
/// .expect("Could not create guest memory");
490492
/// let res = gm.write_slice(&[1, 2, 3, 4, 5], start_addr);
491493
/// assert!(res.is_ok());
492494
/// # }
@@ -516,7 +518,8 @@ impl<T: GuestMemory> Bytes<GuestAddress> for T {
516518
/// # fn test_write_u64() {
517519
/// let start_addr = GuestAddress(0x1000);
518520
/// let mut gm =
519-
/// GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).expect("Could not create guest memory");
521+
/// GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)])
522+
/// .expect("Could not create guest memory");
520523
/// let buf = &mut [0u8; 16];
521524
/// let res = gm.read_slice(buf, start_addr);
522525
/// assert!(res.is_ok());
@@ -550,8 +553,10 @@ impl<T: GuestMemory> Bytes<GuestAddress> for T {
550553
/// # fn test_read_random() {
551554
/// let start_addr = GuestAddress(0x1000);
552555
/// let gm =
553-
/// GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).expect("Could not create guest memory");
554-
/// let mut file = File::open(Path::new("/dev/urandom")).expect("could not open /dev/urandom");
556+
/// GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)])
557+
/// .expect("Could not create guest memory");
558+
/// let mut file = File::open(Path::new("/dev/urandom"))
559+
/// .expect("could not open /dev/urandom");
555560
/// let addr = GuestAddress(0x1010);
556561
/// gm.read_from(addr, &mut file, 128)
557562
/// .expect("Could not read from /dev/urandom into guest memory");
@@ -617,7 +622,8 @@ impl<T: GuestMemory> Bytes<GuestAddress> for T {
617622
/// # fn test_write_null() {
618623
/// let start_addr = GuestAddress(0x1000);
619624
/// let gm =
620-
/// GuestMemoryMmap::new(&vec![(start_addr, 1024)]).expect("Could not create guest memory");
625+
/// GuestMemoryMmap::from_ranges(&vec![(start_addr, 1024)])
626+
/// .expect("Could not create guest memory");
621627
/// let mut file = OpenOptions::new()
622628
/// .write(true)
623629
/// .open("/dev/null")
@@ -707,7 +713,7 @@ mod tests {
707713
fn checked_read_from() {
708714
let start_addr1 = GuestAddress(0x0);
709715
let start_addr2 = GuestAddress(0x40);
710-
let mem = GuestMemoryMmap::new(&[(start_addr1, 64), (start_addr2, 64)]).unwrap();
716+
let mem = GuestMemoryMmap::from_ranges(&[(start_addr1, 64), (start_addr2, 64)]).unwrap();
711717
let image = make_image(0x80);
712718
let offset = GuestAddress(0x30);
713719
let count: usize = 0x20;

‎src/mmap.rs

Lines changed: 66 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ impl Bytes<MemoryRegionAddress> for GuestRegionMmap {
158158
/// ```
159159
/// # use vm_memory::{Bytes, GuestAddress, GuestMemoryMmap};
160160
/// # let start_addr = GuestAddress(0x1000);
161-
/// # let mut gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).unwrap();
161+
/// # let mut gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).unwrap();
162162
/// let res = gm.write(&[1,2,3,4,5], GuestAddress(0x1200)).unwrap();
163163
/// assert_eq!(5, res);
164164
/// ```
@@ -175,7 +175,7 @@ impl Bytes<MemoryRegionAddress> for GuestRegionMmap {
175175
/// ```
176176
/// # use vm_memory::{Bytes, GuestAddress, GuestMemoryMmap};
177177
/// # let start_addr = GuestAddress(0x1000);
178-
/// # let mut gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).unwrap();
178+
/// # let mut gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).unwrap();
179179
/// let buf = &mut [0u8; 16];
180180
/// let res = gm.read(buf, GuestAddress(0x1200)).unwrap();
181181
/// assert_eq!(16, res);
@@ -210,7 +210,7 @@ impl Bytes<MemoryRegionAddress> for GuestRegionMmap {
210210
/// # use std::fs::File;
211211
/// # use std::path::Path;
212212
/// # let start_addr = GuestAddress(0x1000);
213-
/// # let gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).unwrap();
213+
/// # let gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).unwrap();
214214
/// let mut file = if cfg!(unix) {
215215
/// File::open(Path::new("/dev/urandom")).unwrap()
216216
/// } else {
@@ -245,7 +245,7 @@ impl Bytes<MemoryRegionAddress> for GuestRegionMmap {
245245
/// # use std::fs::File;
246246
/// # use std::path::Path;
247247
/// # let start_addr = GuestAddress(0x1000);
248-
/// # let gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).unwrap();
248+
/// # let gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).unwrap();
249249
/// let mut file = if cfg!(unix) {
250250
/// File::open(Path::new("/dev/urandom")).unwrap()
251251
/// } else {
@@ -283,7 +283,7 @@ impl Bytes<MemoryRegionAddress> for GuestRegionMmap {
283283
/// # use vm_memory::{Address, Bytes, GuestAddress, GuestMemoryMmap};
284284
/// # use std::fs::OpenOptions;
285285
/// # let start_addr = GuestAddress(0x1000);
286-
/// # let gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).unwrap();
286+
/// # let gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).unwrap();
287287
/// let mut file = TempFile::new().unwrap().into_file();
288288
/// let mut mem = [0u8; 1024];
289289
/// gm.write_to(start_addr, &mut file, 128).unwrap();
@@ -315,7 +315,7 @@ impl Bytes<MemoryRegionAddress> for GuestRegionMmap {
315315
/// # use vm_memory::{Address, Bytes, GuestAddress, GuestMemoryMmap};
316316
/// # use std::fs::OpenOptions;
317317
/// # let start_addr = GuestAddress(0x1000);
318-
/// # let gm = GuestMemoryMmap::new(&vec![(start_addr, 0x400)]).unwrap();
318+
/// # let gm = GuestMemoryMmap::from_ranges(&vec![(start_addr, 0x400)]).unwrap();
319319
/// let mut file = TempFile::new().unwrap().into_file();
320320
/// let mut mem = [0u8; 1024];
321321
/// gm.write_all_to(start_addr, &mut file, 128).unwrap();
@@ -378,18 +378,25 @@ pub struct GuestMemoryMmap {
378378
}
379379

380380
impl GuestMemoryMmap {
381+
/// Creates an empty `GuestMemoryMmap` instance.
382+
pub fn new() -> Self {
383+
GuestMemoryMmap {
384+
regions: Vec::new(),
385+
}
386+
}
387+
381388
/// Creates a container and allocates anonymous memory for guest memory regions.
382389
///
383390
/// Valid memory regions are specified as a slice of (Address, Size) tuples sorted by Address.
384-
pub fn new(ranges: &[(GuestAddress, usize)]) -> result::Result<Self, Error> {
385-
Self::with_files(ranges.iter().map(|r| (r.0, r.1, None)))
391+
pub fn from_ranges(ranges: &[(GuestAddress, usize)]) -> result::Result<Self, Error> {
392+
Self::from_ranges_with_files(ranges.iter().map(|r| (r.0, r.1, None)))
386393
}
387394

388395
/// Creates a container and allocates anonymous memory for guest memory regions.
389396
///
390397
/// Valid memory regions are specified as a sequence of (Address, Size, Option<FileOffset>)
391398
/// tuples sorted by Address.
392-
pub fn with_files<A, T>(ranges: T) -> result::Result<Self, Error>
399+
pub fn from_ranges_with_files<A, T>(ranges: T) -> result::Result<Self, Error>
393400
where
394401
A: Borrow<(GuestAddress, usize, Option<FileOffset>)>,
395402
T: IntoIterator<Item = A>,
@@ -557,7 +564,7 @@ mod tests {
557564
fn new_guest_memory_mmap(
558565
regions_summary: &[(GuestAddress, usize)],
559566
) -> Result<GuestMemoryMmap, Error> {
560-
GuestMemoryMmap::new(regions_summary)
567+
GuestMemoryMmap::from_ranges(regions_summary)
561568
}
562569

563570
fn new_guest_memory_mmap_from_regions(
@@ -603,7 +610,7 @@ mod tests {
603610
})
604611
.collect();
605612

606-
GuestMemoryMmap::with_files(&regions)
613+
GuestMemoryMmap::from_ranges_with_files(&regions)
607614
}
608615

609616
#[test]
@@ -748,6 +755,9 @@ mod tests {
748755
(GuestAddress(100), 100 as usize),
749756
];
750757

758+
let guest_mem = GuestMemoryMmap::new();
759+
assert_eq!(guest_mem.regions.len(), 0);
760+
751761
check_guest_memory_mmap(new_guest_memory_mmap(&regions_summary), &regions_summary);
752762

753763
check_guest_memory_mmap(
@@ -798,8 +808,8 @@ mod tests {
798808
let start_addr1 = GuestAddress(0x0);
799809
let start_addr2 = GuestAddress(0x800);
800810
let guest_mem =
801-
GuestMemoryMmap::new(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
802-
let guest_mem_backed_by_file = GuestMemoryMmap::with_files(&[
811+
GuestMemoryMmap::from_ranges(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
812+
let guest_mem_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[
803813
(start_addr1, 0x400, Some(FileOffset::new(f1, 0))),
804814
(start_addr2, 0x400, Some(FileOffset::new(f2, 0))),
805815
])
@@ -824,8 +834,8 @@ mod tests {
824834
let start_addr1 = GuestAddress(0x0);
825835
let start_addr2 = GuestAddress(0x800);
826836
let guest_mem =
827-
GuestMemoryMmap::new(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
828-
let guest_mem_backed_by_file = GuestMemoryMmap::with_files(&[
837+
GuestMemoryMmap::from_ranges(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
838+
let guest_mem_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[
829839
(start_addr1, 0x400, Some(FileOffset::new(f1, 0))),
830840
(start_addr2, 0x400, Some(FileOffset::new(f2, 0))),
831841
])
@@ -856,8 +866,8 @@ mod tests {
856866
let start_addr1 = GuestAddress(0x0);
857867
let start_addr2 = GuestAddress(0x800);
858868
let guest_mem =
859-
GuestMemoryMmap::new(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
860-
let guest_mem_backed_by_file = GuestMemoryMmap::with_files(&[
869+
GuestMemoryMmap::from_ranges(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
870+
let guest_mem_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[
861871
(start_addr1, 0x400, Some(FileOffset::new(f1, 0))),
862872
(start_addr2, 0x400, Some(FileOffset::new(f2, 0))),
863873
])
@@ -884,8 +894,8 @@ mod tests {
884894
let start_addr1 = GuestAddress(0x0);
885895
let start_addr2 = GuestAddress(0x800);
886896
let guest_mem =
887-
GuestMemoryMmap::new(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
888-
let guest_mem_backed_by_file = GuestMemoryMmap::with_files(&[
897+
GuestMemoryMmap::from_ranges(&[(start_addr1, 0x400), (start_addr2, 0x400)]).unwrap();
898+
let guest_mem_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[
889899
(start_addr1, 0x400, Some(FileOffset::new(f1, 0))),
890900
(start_addr2, 0x400, Some(FileOffset::new(f2, 0))),
891901
])
@@ -910,10 +920,13 @@ mod tests {
910920
f.set_len(0x400).unwrap();
911921

912922
let start_addr = GuestAddress(0x0);
913-
let guest_mem = GuestMemoryMmap::new(&[(start_addr, 0x400)]).unwrap();
914-
let guest_mem_backed_by_file =
915-
GuestMemoryMmap::with_files(&[(start_addr, 0x400, Some(FileOffset::new(f, 0)))])
916-
.unwrap();
923+
let guest_mem = GuestMemoryMmap::from_ranges(&[(start_addr, 0x400)]).unwrap();
924+
let guest_mem_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[(
925+
start_addr,
926+
0x400,
927+
Some(FileOffset::new(f, 0)),
928+
)])
929+
.unwrap();
917930

918931
let guest_mem_list = vec![guest_mem, guest_mem_backed_by_file];
919932
for guest_mem in guest_mem_list.iter() {
@@ -944,8 +957,9 @@ mod tests {
944957
let bad_addr2 = GuestAddress(0x1ffc);
945958
let max_addr = GuestAddress(0x2000);
946959

947-
let gm = GuestMemoryMmap::new(&[(start_addr1, 0x1000), (start_addr2, 0x1000)]).unwrap();
948-
let gm_backed_by_file = GuestMemoryMmap::with_files(&[
960+
let gm =
961+
GuestMemoryMmap::from_ranges(&[(start_addr1, 0x1000), (start_addr2, 0x1000)]).unwrap();
962+
let gm_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[
949963
(start_addr1, 0x1000, Some(FileOffset::new(f1, 0))),
950964
(start_addr2, 0x1000, Some(FileOffset::new(f2, 0))),
951965
])
@@ -983,10 +997,13 @@ mod tests {
983997
f.set_len(0x400).unwrap();
984998

985999
let mut start_addr = GuestAddress(0x1000);
986-
let gm = GuestMemoryMmap::new(&[(start_addr, 0x400)]).unwrap();
987-
let gm_backed_by_file =
988-
GuestMemoryMmap::with_files(&[(start_addr, 0x400, Some(FileOffset::new(f, 0)))])
989-
.unwrap();
1000+
let gm = GuestMemoryMmap::from_ranges(&[(start_addr, 0x400)]).unwrap();
1001+
let gm_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[(
1002+
start_addr,
1003+
0x400,
1004+
Some(FileOffset::new(f, 0)),
1005+
)])
1006+
.unwrap();
9901007

9911008
let gm_list = vec![gm, gm_backed_by_file];
9921009
for gm in gm_list.iter() {
@@ -1011,8 +1028,8 @@ mod tests {
10111028
let f = TempFile::new().unwrap().into_file();
10121029
f.set_len(0x400).unwrap();
10131030

1014-
let gm = GuestMemoryMmap::new(&[(GuestAddress(0x1000), 0x400)]).unwrap();
1015-
let gm_backed_by_file = GuestMemoryMmap::with_files(&[(
1031+
let gm = GuestMemoryMmap::from_ranges(&[(GuestAddress(0x1000), 0x400)]).unwrap();
1032+
let gm_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[(
10161033
GuestAddress(0x1000),
10171034
0x400,
10181035
Some(FileOffset::new(f, 0)),
@@ -1056,7 +1073,7 @@ mod tests {
10561073
(GuestAddress(0x1000), region_size),
10571074
];
10581075
let mut iterated_regions = Vec::new();
1059-
let gm = GuestMemoryMmap::new(&regions).unwrap();
1076+
let gm = GuestMemoryMmap::from_ranges(&regions).unwrap();
10601077
let res: guest_memory::Result<()> = gm.with_regions(|_, region| {
10611078
assert_eq!(region.len(), region_size as GuestUsize);
10621079
Ok(())
@@ -1087,8 +1104,9 @@ mod tests {
10871104

10881105
let start_addr1 = GuestAddress(0x0);
10891106
let start_addr2 = GuestAddress(0x1000);
1090-
let gm = GuestMemoryMmap::new(&[(start_addr1, 0x1000), (start_addr2, 0x1000)]).unwrap();
1091-
let gm_backed_by_file = GuestMemoryMmap::with_files(&[
1107+
let gm =
1108+
GuestMemoryMmap::from_ranges(&[(start_addr1, 0x1000), (start_addr2, 0x1000)]).unwrap();
1109+
let gm_backed_by_file = GuestMemoryMmap::from_ranges_with_files(&[
10921110
(start_addr1, 0x1000, Some(FileOffset::new(f1, 0))),
10931111
(start_addr2, 0x1000, Some(FileOffset::new(f2, 0))),
10941112
])
@@ -1110,13 +1128,17 @@ mod tests {
11101128
f.set_len(0x400).unwrap();
11111129

11121130
let start_addr = GuestAddress(0x0);
1113-
let gm = GuestMemoryMmap::new(&[(start_addr, 0x400)]).unwrap();
1131+
let gm = GuestMemoryMmap::from_ranges(&[(start_addr, 0x400)]).unwrap();
11141132
assert!(gm.find_region(start_addr).is_some());
11151133
let region = gm.find_region(start_addr).unwrap();
11161134
assert!(region.file_offset().is_none());
11171135

1118-
let gm = GuestMemoryMmap::with_files(&[(start_addr, 0x400, Some(FileOffset::new(f, 0)))])
1119-
.unwrap();
1136+
let gm = GuestMemoryMmap::from_ranges_with_files(&[(
1137+
start_addr,
1138+
0x400,
1139+
Some(FileOffset::new(f, 0)),
1140+
)])
1141+
.unwrap();
11201142
assert!(gm.find_region(start_addr).is_some());
11211143
let region = gm.find_region(start_addr).unwrap();
11221144
assert!(region.file_offset().is_some());
@@ -1135,14 +1157,17 @@ mod tests {
11351157
let offset = 0x1000;
11361158

11371159
let start_addr = GuestAddress(0x0);
1138-
let gm = GuestMemoryMmap::new(&[(start_addr, 0x400)]).unwrap();
1160+
let gm = GuestMemoryMmap::from_ranges(&[(start_addr, 0x400)]).unwrap();
11391161
assert!(gm.find_region(start_addr).is_some());
11401162
let region = gm.find_region(start_addr).unwrap();
11411163
assert!(region.file_offset().is_none());
11421164

1143-
let gm =
1144-
GuestMemoryMmap::with_files(&[(start_addr, 0x400, Some(FileOffset::new(f, offset)))])
1145-
.unwrap();
1165+
let gm = GuestMemoryMmap::from_ranges_with_files(&[(
1166+
start_addr,
1167+
0x400,
1168+
Some(FileOffset::new(f, offset)),
1169+
)])
1170+
.unwrap();
11461171
assert!(gm.find_region(start_addr).is_some());
11471172
let region = gm.find_region(start_addr).unwrap();
11481173
assert!(region.file_offset().is_some());

0 commit comments

Comments
 (0)